More PR review changes

This commit is contained in:
ananaysingh 2022-08-18 22:37:00 +05:30
parent c001093379
commit 09b520f20a

View file

@ -43,7 +43,7 @@ func init() {
killTasksCmd.Flags().StringVarP(env, "environment", "e", "", "Aurora Environment") killTasksCmd.Flags().StringVarP(env, "environment", "e", "", "Aurora Environment")
killTasksCmd.Flags().StringVarP(role, "role", "r", "", "Aurora Role") killTasksCmd.Flags().StringVarP(role, "role", "r", "", "Aurora Role")
killTasksCmd.Flags().StringVarP(name, "name", "n", "", "Aurora Name") killTasksCmd.Flags().StringVarP(name, "name", "n", "", "Aurora Name")
killTasksCmd.Flags().StringVarP(instances, "instances", "i", "", "Instances") killTasksCmd.Flags().StringVarP(instances, "instances", "i", "", "Instances e.g. 1, 2, 5")
killTasksCmd.Flags().BoolVarP(&monitor, "monitor", "m", true, "monitor the result after sending the command") killTasksCmd.Flags().BoolVarP(&monitor, "monitor", "m", true, "monitor the result after sending the command")
killTasksCmd.MarkFlagRequired("environment") killTasksCmd.MarkFlagRequired("environment")
killTasksCmd.MarkFlagRequired("role") killTasksCmd.MarkFlagRequired("role")
@ -116,18 +116,16 @@ func killTasks(cmd *cobra.Command, args []string) {
* In the following block, we convert instance numbers, which were passed as strings, to integer values * In the following block, we convert instance numbers, which were passed as strings, to integer values
* After converting them to integers, we add them to a slice of type int32. * After converting them to integers, we add them to a slice of type int32.
*/ */
var intErr error
var instanceNumber int
splitString := strings.Split(*instances, ",") splitString := strings.Split(*instances, ",")
instanceList := make([]int32, len(splitString)) instanceList := make([]int32, len(splitString))
for i := range instanceList { for i := range instanceList {
splitString[i] = strings.TrimSpace(splitString[i]) splitString[i] = strings.TrimSpace(splitString[i])
instanceNumber, intErr = strconv.Atoi(splitString[i]) instanceNumber, intErr := strconv.Atoi(splitString[i])
if intErr != nil { if intErr != nil {
log.Fatalln("Instance passed should be a number. Error: " + intErr.Error()) log.Fatalln("Instance passed should be a number. Error: " + intErr.Error())
break return
} else { } else {
instanceList[i] = int32(instanceNumber) instanceList[i] = int32(instanceNumber)
} }