PR Code Review Changes
This commit is contained in:
parent
ff6c3e1df6
commit
30c06da51d
3 changed files with 45 additions and 75 deletions
43
cmd/kill.go
43
cmd/kill.go
|
@ -15,6 +15,8 @@
|
|||
package cmd
|
||||
|
||||
import (
|
||||
"strconv"
|
||||
|
||||
realis "github.com/aurora-scheduler/gorealis/v2"
|
||||
"github.com/spf13/cobra"
|
||||
)
|
||||
|
@ -26,6 +28,7 @@ func init() {
|
|||
|
||||
// Kill Job
|
||||
killCmd.AddCommand(killJobCmd)
|
||||
killCmd.AddCommand(killTaskCmd)
|
||||
|
||||
killJobCmd.Flags().StringVarP(env, "environment", "e", "", "Aurora Environment")
|
||||
killJobCmd.Flags().StringVarP(role, "role", "r", "", "Aurora Role")
|
||||
|
@ -34,6 +37,17 @@ func init() {
|
|||
killJobCmd.MarkFlagRequired("environment")
|
||||
killJobCmd.MarkFlagRequired("role")
|
||||
killJobCmd.MarkFlagRequired("name")
|
||||
|
||||
//Set flags for killTask sub-command
|
||||
killTaskCmd.Flags().StringVarP(env, "environment", "e", "", "Aurora Environment")
|
||||
killTaskCmd.Flags().StringVarP(role, "role", "r", "", "Aurora Role")
|
||||
killTaskCmd.Flags().StringVarP(name, "name", "n", "", "Aurora Name")
|
||||
killTaskCmd.Flags().StringVarP(instance, "instance", "i", "", "Instance Number")
|
||||
killTaskCmd.Flags().BoolVarP(&monitor, "monitor", "m", true, "monitor the result after sending the command")
|
||||
killTaskCmd.MarkFlagRequired("environment")
|
||||
killTaskCmd.MarkFlagRequired("role")
|
||||
killTaskCmd.MarkFlagRequired("name")
|
||||
killTaskCmd.MarkFlagRequired("instance")
|
||||
}
|
||||
|
||||
var killCmd = &cobra.Command{
|
||||
|
@ -47,6 +61,12 @@ var killJobCmd = &cobra.Command{
|
|||
Run: killJob,
|
||||
}
|
||||
|
||||
var killTaskCmd = &cobra.Command{
|
||||
Use: "task",
|
||||
Short: "Kill an Aurora Task",
|
||||
Run: killTask,
|
||||
}
|
||||
|
||||
func killJob(cmd *cobra.Command, args []string) {
|
||||
log.Infof("Killing job [Env:%s Role:%s Name:%s]\n", *env, *role, *name)
|
||||
|
||||
|
@ -64,3 +84,26 @@ func killJob(cmd *cobra.Command, args []string) {
|
|||
}
|
||||
}
|
||||
}
|
||||
|
||||
func killTask(cmd *cobra.Command, args []string) {
|
||||
log.Infof("Killing task [Env:%s Role:%s Name:%s Instance:%s]\n", *env, *role, *name, *instance)
|
||||
|
||||
//Set jobKey for the task to be killed.
|
||||
task := realis.NewTask().
|
||||
Environment(*env).
|
||||
Role(*role).
|
||||
Name(*name)
|
||||
|
||||
//Convert instance from string type to int32 type, and call the killtasks function
|
||||
instanceNumber, _ := strconv.Atoi(*instance)
|
||||
_, err := client.KillInstances(task.JobKey(), (int32)(instanceNumber))
|
||||
|
||||
if err != nil {
|
||||
log.Fatalln(err)
|
||||
}
|
||||
if monitor {
|
||||
if ok, err := client.MonitorInstances(task.JobKey(), 0, 5, 50); !ok || err != nil {
|
||||
log.Fatalln("Unable to kill the given task")
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue