From 82fe22e013933cea00e9f07ee71a2081cd578e27 Mon Sep 17 00:00:00 2001 From: Renan DelValle Date: Thu, 7 May 2020 20:19:26 -0700 Subject: [PATCH] Adding minimum instances to test data for update. Changing YAML de-serializing field name to match the name od the struct member and to decrease ambiguity. --- internal/updateJob.go | 2 +- test/update_hello_world.yaml | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/internal/updateJob.go b/internal/updateJob.go index 32cafd3..4100e8f 100644 --- a/internal/updateJob.go +++ b/internal/updateJob.go @@ -49,7 +49,7 @@ type UpdateStrategy struct { type UpdateSettings struct { MaxPerInstanceFailures int32 `yaml:"maxPerInstanceFailures"` MaxFailedInstances int32 `yaml:"maxFailedInstances"` - MinTimeInRunning time.Duration `yaml:"minTimeRunning"` + MinTimeInRunning time.Duration `yaml:"minTimeInRunning"` RollbackOnFailure bool `yaml:"rollbackOnFailure"` InstanceRanges []InstanceRange `yaml:"instanceRanges"` InstanceCount int32 `yaml:"instanceCount"` diff --git a/test/update_hello_world.yaml b/test/update_hello_world.yaml index 4caae2d..ae13c27 100644 --- a/test/update_hello_world.yaml +++ b/test/update_hello_world.yaml @@ -18,11 +18,12 @@ updateSettings: maxFailedInstances: 1 minTimeInRunning: 1m rollbackOnFailure: true + instanceCount: 1 instanceRanges: - first: 1 last: 4 pulseTimeout: 1m strategy: - batch: - groupSize: 2 - autoPause: false \ No newline at end of file + variableBatch: + groupSizes: [1,2,3] + autoPause: true