ridv/gorealis-v2
1
0
Fork 0
Code Issues Pull requests Projects Releases 13 Packages Wiki Activity Actions

V2.0 thrift repository migration and cleanup (#98)

Browse source 
* Remove unnecessary files from the thrift repository that come along with the go library.

* Updating thrift generated code to be 0.12.0 final generated code.

* Remove git.apache.org dependency in vendor folder.

* Migrating from git.apache.org/thrift.git to github.com/apache/thrift

* Upgrading dep (although it will not work now that imports are using mod format, it allows for users to easily fix this with a replacement of the import path).

* Upgrading mod dependencies for Thrift to point to github.com location of the repository.

* Bug fix for Thermos Payload generation relating to the GPU being set.
This commit is contained in:
Renan DelValle 2019-02-19 16:40:41 -08:00 • committed by GitHub
parent 9b3593e9d9
commit 461b23400c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2547 changed files with 23855 additions and 483740 deletions
Download patch file Download diff file Expand all files Collapse all files

4
task.go
View file

@ -18,7 +18,7 @@ import (
"encoding/json"
"strconv"
"git.apache.org/thrift.git/lib/go/thrift"
"github.com/apache/thrift/lib/go/thrift"
"github.com/paypal/gorealis/v2/gen-go/apache/aurora"
)
@ -409,7 +409,7 @@ func (t *AuroraTask) BuildThermosPayload() error {
t.thermos.disk(*t.resources[DISK].DiskMb)
}
if t.resources[GPU].NumGpus != nil {
if t.resources[GPU] != nil && t.resources[GPU].NumGpus != nil {
t.thermos.gpu(*t.resources[GPU].NumGpus)
}