ridv/gorealis-v2
1
0
Fork 0
Code Issues Pull requests Projects Releases 13 Packages Wiki Activity Actions

Simplifying code to use bare structs.

Browse source
This commit is contained in:
Renan DelValle 2018-11-08 18:07:38 -08:00
parent 8a9a97c150
commit 573e45a59c
No known key found for this signature in database
GPG key ID: C240AD6D6F443EC9
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
updatejob.go
View file

@ -27,7 +27,7 @@ type UpdateJob struct {
// Create a default UpdateJob object. // Create a default UpdateJob object.
func NewDefaultUpdateJob(config *aurora.TaskConfig) *UpdateJob { func NewDefaultUpdateJob(config *aurora.TaskConfig) *UpdateJob {
req := aurora.NewJobUpdateRequest() req := aurora.JobUpdateRequest{}
req.TaskConfig = config req.TaskConfig = config
req.Settings = NewUpdateSettings() req.Settings = NewUpdateSettings()
@ -62,7 +62,7 @@ func NewDefaultUpdateJob(config *aurora.TaskConfig) *UpdateJob {
req.Settings.RollbackOnFailure = true req.Settings.RollbackOnFailure = true
//TODO(rdelvalle): Deep copy job struct to avoid unexpected behavior //TODO(rdelvalle): Deep copy job struct to avoid unexpected behavior
return &UpdateJob{AuroraJob: job, req: req} return &UpdateJob{AuroraJob: job, req: &req}
} }
func NewUpdateJob(config *aurora.TaskConfig, settings *aurora.JobUpdateSettings) *UpdateJob { func NewUpdateJob(config *aurora.TaskConfig, settings *aurora.JobUpdateSettings) *UpdateJob {
@ -140,7 +140,7 @@ func (u *UpdateJob) RollbackOnFail(rollback bool) *UpdateJob {
func NewUpdateSettings() *aurora.JobUpdateSettings { func NewUpdateSettings() *aurora.JobUpdateSettings {
us := new(aurora.JobUpdateSettings) us := aurora.JobUpdateSettings{}
// Mirrors defaults set by Pystachio // Mirrors defaults set by Pystachio
us.UpdateOnlyTheseInstances = make(map[*aurora.Range]bool) us.UpdateOnlyTheseInstances = make(map[*aurora.Range]bool)
us.UpdateGroupSize = 1 us.UpdateGroupSize = 1
@ -150,5 +150,5 @@ func NewUpdateSettings() *aurora.JobUpdateSettings {
us.MaxFailedInstances = 0 us.MaxFailedInstances = 0
us.RollbackOnFailure = true us.RollbackOnFailure = true
return us return &us
} }