ridv/gorealis-v2
1
0
Fork 0
Code Issues Pull requests Projects Releases 13 Packages Wiki Activity Actions

Eliminating deprecated response code check since retry call does this automatically.

Browse source
This commit is contained in:
Renan DelValle 2018-11-08 18:09:52 -08:00
parent d747a48626
commit 848b5f7971
No known key found for this signature in database
GPG key ID: C240AD6D6F443EC9
1 changed files with 0 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

13
response/response.go
View file

@ -17,7 +17,6 @@ package response
import ( import (
"bytes" "bytes"
"errors"
"github.com/paypal/gorealis/gen-go/apache/aurora" "github.com/paypal/gorealis/gen-go/apache/aurora"
) )
@ -39,18 +38,6 @@ func JobUpdateSummaries(resp *aurora.Response) []*aurora.JobUpdateSummary {
return resp.GetResult_().GetGetJobUpdateSummariesResult_().GetUpdateSummaries() return resp.GetResult_().GetGetJobUpdateSummariesResult_().GetUpdateSummaries()
} }
// Deprecated: Replaced by checks done inside of thriftCallHelper
func ResponseCodeCheck(resp *aurora.Response) (*aurora.Response, error) {
if resp == nil {
return resp, errors.New("Response is nil")
}
if resp.GetResponseCode() != aurora.ResponseCode_OK {
return resp, errors.New(CombineMessage(resp))
}
return resp, nil
}
// Based on aurora client: src/main/python/apache/aurora/client/base.py // Based on aurora client: src/main/python/apache/aurora/client/base.py
func CombineMessage(resp *aurora.Response) string { func CombineMessage(resp *aurora.Response) string {
var buffer bytes.Buffer var buffer bytes.Buffer