ridv/gorealis-v2
1
0
Fork 0
Code Issues Pull requests Projects Releases 13 Packages Wiki Activity Actions

Refactoring URL validation tets to be more terse as suggested by Pinglei.

Browse source
This commit is contained in:
Renan DelValle 2018-12-18 12:44:08 -08:00
parent 11c71b0463
commit 84e8762495
No known key found for this signature in database
GPG key ID: C240AD6D6F443EC9
1 changed files with 22 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

60
realis_e2e_test.go
View file

@ -180,47 +180,31 @@ func TestLeaderFromZK(t *testing.T) {
} }
func TestInvalidAuroraURL(t *testing.T) { func TestInvalidAuroraURL(t *testing.T) {
r, err := realis.NewClient(realis.SchedulerUrl("http://doesntexist.com:8081/apitest")) for _, url := range []string{
assert.Error(t, err) "http://doesntexist.com:8081/apitest",
assert.Nil(t, r) "test://doesntexist.com:8081",
"https://doesntexist.com:8081/testing/api",
r, err = realis.NewClient(realis.SchedulerUrl("test://doesntexist.com:8081")) } {
assert.Error(t, err) r, err := realis.NewClient(realis.SchedulerUrl(url))
assert.Nil(t, r) assert.Error(t, err)
assert.Nil(t, r)
r, err = realis.NewClient(realis.SchedulerUrl("https://doesntexist.com:8081/testing/api")) }
assert.Error(t, err)
assert.Nil(t, r)
} }
func TestValidAuroraURL(t *testing.T) { func TestValidAuroraURL(t *testing.T) {
r, err := realis.NewClient(realis.SchedulerUrl("http://domain.com:8081/api")) for _, url := range []string{
assert.NoError(t, err) "http://domain.com:8081/api",
assert.NotNil(t, r) "https://domain.com:8081/api",
"domain.com:8081",
r, err = realis.NewClient(realis.SchedulerUrl("https://domain.com:8081/api")) "domain.com",
assert.NoError(t, err) "192.168.33.7",
assert.NotNil(t, r) "192.168.33.7:8081",
"192.168.33.7:8081/api",
r, err = realis.NewClient(realis.SchedulerUrl("domain.com:8081")) } {
assert.NoError(t, err) r, err := realis.NewClient(realis.SchedulerUrl(url))
assert.NotNil(t, r) assert.NoError(t, err)
assert.NotNil(t, r)
r, err = realis.NewClient(realis.SchedulerUrl("domain.com")) }
assert.NoError(t, err)
assert.NotNil(t, r)
r, err = realis.NewClient(realis.SchedulerUrl("192.168.33.7"))
assert.NoError(t, err)
assert.NotNil(t, r)
r, err = realis.NewClient(realis.SchedulerUrl("192.168.33.7:8081"))
assert.NoError(t, err)
assert.NotNil(t, r)
r, err = realis.NewClient(realis.SchedulerUrl("192.168.33.7:8081/api"))
assert.NoError(t, err)
assert.NotNil(t, r)
} }
func TestRealisClient_ReestablishConn(t *testing.T) { func TestRealisClient_ReestablishConn(t *testing.T) {