Moving from govendor to dep, updated dependencies (#48)
* Moving from govendor to dep. * Making the pull request template more friendly. * Fixing akward space in PR template. * goimports run on whole project using ` goimports -w $(find . -type f -name '*.go' -not -path "./vendor/*" -not -path "./gen-go/*")` source of command: https://gist.github.com/bgentry/fd1ffef7dbde01857f66
This commit is contained in:
parent
9631aa3aab
commit
8d445c1c77
2186 changed files with 400410 additions and 352 deletions
54
vendor/git.apache.org/thrift.git/doc/committers.md
generated
vendored
Normal file
54
vendor/git.apache.org/thrift.git/doc/committers.md
generated
vendored
Normal file
|
@ -0,0 +1,54 @@
|
|||
## Process used by committers to review and submit patches
|
||||
|
||||
1. Make sure that there is an issue for the patch(s) you are about to commit in our [Jira issue tracker](http://issues.apache.org/jira/browse/THRIFT)
|
||||
|
||||
1. Check out the latest version of the source code
|
||||
|
||||
* git clone https://git-wip-us.apache.org/repos/asf/thrift.git thrift
|
||||
|
||||
1. Apply the patch
|
||||
|
||||
* curl https://issues.apache.org/jira/... |git apply --ignore-space-change
|
||||
|
||||
or
|
||||
|
||||
* curl https://github.com/<GitHub User>/thrift/commit/<Commit ID>.patch |git apply --ignore-space-change
|
||||
|
||||
|
||||
1. Inspect the applied patch to ensure that all [Legal aspects on Submission of Contributions (Patches)](http://www.apache.org/licenses/LICENSE-2.0.html#contributions) are met
|
||||
|
||||
1. Run the necessary unit tests and cross language test cases to verify the patch
|
||||
|
||||
1. Commit the patch
|
||||
|
||||
git --config user.name "Your Name"
|
||||
git --config user.email "YourApacheID@apache.org"
|
||||
git add -A
|
||||
git commit
|
||||
|
||||
1. The commit message should be in the format:
|
||||
|
||||
THRIFT-###:<Jira description>
|
||||
Client: <component>
|
||||
Patch: <Name of person contributing the patch>
|
||||
|
||||
Description of what was fixed or addressed.
|
||||
|
||||
<%
|
||||
if this is a github pull request then add below comment
|
||||
to automaticaly close GitHub request.
|
||||
%>
|
||||
This closes #XX
|
||||
|
||||
|
||||
1. Double check the patch committed and that nothing was missed then push the patch
|
||||
|
||||
git status
|
||||
git show HEAD
|
||||
git push origin master
|
||||
|
||||
|
||||
1. Resolve the jira issue and set the following for the changelog
|
||||
|
||||
* Component the patch is for
|
||||
* fixVersion to the current version on master
|
Loading…
Add table
Add a link
Reference in a new issue