From f72fdacfb004619da97d90df765ac041197e0df9 Mon Sep 17 00:00:00 2001 From: Renan DelValle Date: Thu, 12 Sep 2019 10:11:05 -0700 Subject: [PATCH] Changing the names of the protocol constants to be more descriptive. --- realis.go | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/realis.go b/realis.go index a6925c9..002cd56 100644 --- a/realis.go +++ b/realis.go @@ -80,9 +80,9 @@ var defaultBackoff = Backoff{ type TransportProtocol int const ( - unset TransportProtocol = iota - json - binary + unsetProtocol TransportProtocol = iota + jsonProtocol + binaryProtocol ) type ClientOption func(*clientConfig) @@ -128,13 +128,13 @@ func ZKUrl(url string) ClientOption { func ThriftJSON() ClientOption { return func(config *clientConfig) { - config.transportProtocol = json + config.transportProtocol = jsonProtocol } } func ThriftBinary() ClientOption { return func(config *clientConfig) { - config.transportProtocol = binary + config.transportProtocol = binaryProtocol } } @@ -293,14 +293,14 @@ func NewClient(options ...ClientOption) (*Client, error) { } switch config.transportProtocol { - case binary: + case binaryProtocol: trans, err := newTBinTransport(url, config.timeout, config) if err != nil { return nil, NewTemporaryError(errors.Wrap(err, "error creating realis")) } config.transport = trans config.protoFactory = thrift.NewTBinaryProtocolFactoryDefault() - case json: + case jsonProtocol: fallthrough default: trans, err := newTJSONTransport(url, config.timeout, config)