ridv/gorealis
1
0
Fork 0
Code Issues Pull requests Projects Releases 23 Packages Wiki Activity Actions

Retry switch fallthrough fix and create multiple tests (#77)

Browse source 
* Bugfix: switch statements were missing fallthrough statement thus making them retry non-retriable errors. Using a list to catch cases now.

* Adding tests for CreateService, createService when the executor doesn't exist, and createJob when the executor doesn't exist. Renamed Pulse test to reflect that it's using CreateService instead of CreateJob.

* Repsonse propagate back up to caller for context for CreateJob, CreateService, and StartJobUpdate.

* Deleting PR template as Travis CI takes care of running tests and formatting tests now.
This commit is contained in:
Renan DelValle 2018-10-04 10:47:08 -07:00 • committed by GitHub
parent 9ebf118e71
commit 037c636d6d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 105 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

16
.github/PULL_REQUEST_TEMPLATE.md vendored
View file

@ -1,16 +0,0 @@
<!--
-----------------------------------------
## Please read instructions below ##
Before submitting, please make sure you run a vagrant box running Aurora with the latest version shown in .auroraversion and run go test from the project root.
To run an Aurora Vagrant image, follow the instructions here:
http://aurora.apache.org/documentation/latest/getting-started/vagrant/
## Answer the following questions: ##
-->
* Have you run goformat on the project before submitting?
* Have you run go test on the project before submitting? Do all tests pass?
* Does the Pull Request require a test to be added to the end to end tests? If so, has it been added?