From 0e916ebd7687b10e32cac65b2df5779b8736bf70 Mon Sep 17 00:00:00 2001 From: Renan DelValle Date: Tue, 11 Jun 2019 15:59:57 -0700 Subject: [PATCH] Reducing line size. in some files and shadowing in some test cases. --- monitors.go | 6 ++++-- realis_e2e_test.go | 16 ++++++++-------- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/monitors.go b/monitors.go index bf62eb6..69167df 100644 --- a/monitors.go +++ b/monitors.go @@ -21,8 +21,10 @@ import ( "github.com/pkg/errors" ) -// Monitor is a wrapper for the Realis client which allows us to have functions with the same name for Monitoring purposes. -// TODO(rdelvalle): Deprecate monitors and instead add prefix Monitor to all functions in this file like it is done in V2. +// Monitor is a wrapper for the Realis client which allows us to have functions +// with the same name for Monitoring purposes. +// TODO(rdelvalle): Deprecate monitors and instead add prefix Monitor to +// all functions in this file like it is done in V2. type Monitor struct { Client Realis } diff --git a/realis_e2e_test.go b/realis_e2e_test.go index 9c2d9f3..96e9ee0 100644 --- a/realis_e2e_test.go +++ b/realis_e2e_test.go @@ -77,17 +77,17 @@ func TestNonExistentEndpoint(t *testing.T) { t.Run("WithRetries", func(t *testing.T) { // Attempt to connect to a bad endpoint - r, err := realis.NewRealisClient( + badClient, err := realis.NewRealisClient( realis.SchedulerUrl(badEndpoint), realis.TimeoutMS(200000), realis.BackOff(backoff), ) require.NoError(t, err) - require.NotNil(t, r) - defer r.Close() + require.NotNil(t, badClient) + defer badClient.Close() - _, err = r.GetTasksWithoutConfigs(taskQ) + _, err = badClient.GetTasksWithoutConfigs(taskQ) // Check that we do error out of retrying require.Error(t, err) @@ -101,7 +101,7 @@ func TestNonExistentEndpoint(t *testing.T) { t.Run("FailOnLookup", func(t *testing.T) { // Attempt to connect to a bad endpoint - r, err := realis.NewRealisClient( + badClient, err := realis.NewRealisClient( realis.SchedulerUrl(badEndpoint), realis.TimeoutMS(200000), realis.BackOff(backoff), @@ -109,10 +109,10 @@ func TestNonExistentEndpoint(t *testing.T) { ) require.NoError(t, err) - require.NotNil(t, r) - defer r.Close() + require.NotNil(t, badClient) + defer badClient.Close() - _, err = r.GetTasksWithoutConfigs(taskQ) + _, err = badClient.GetTasksWithoutConfigs(taskQ) // Check that we do error out of retrying require.Error(t, err)