ridv/gorealis
1
0
Fork 0
Code Issues Pull requests Projects Releases 23 Packages Wiki Activity Actions

Making receivers for error pointers. Making new function return pointers. Fixing typo.

Browse source
This commit is contained in:
Renan DelValle 2018-01-16 14:33:56 -08:00
parent c7087c1150
commit 3e90e5db72
No known key found for this signature in database
GPG key ID: C240AD6D6F443EC9
2 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

12
errors.go
View file

@ -32,12 +32,12 @@ type TimeoutErr struct {
timeout bool timeout bool
} }
func (t TimeoutErr) Timeout() bool { func (t *TimeoutErr) Timeout() bool {
return t.timeout return t.timeout
} }
func NewTimeoutError(err error) TimeoutErr { func NewTimeoutError(err error) *TimeoutErr {
return TimeoutErr{error: err, timeout: true} return &TimeoutErr{error: err, timeout: true}
} }
type temporary interface { type temporary interface {
@ -54,13 +54,13 @@ type TemporaryErr struct {
temporary bool temporary bool
} }
func (t TemporaryErr) Temporary() bool { func (t *TemporaryErr) Temporary() bool {
return t.temporary return t.temporary
} }
// Retrying after receiving this error is advised // Retrying after receiving this error is advised
func NewTemporaryError(err error) TemporaryErr { func NewTemporaryError(err error) *TemporaryErr {
return TemporaryErr{error: err, temporary: true} return &TemporaryErr{error: err, temporary: true}
} }
// Nothing can be done about this error // Nothing can be done about this error

2
retry.go
View file

@ -83,7 +83,7 @@ func ExponentialBackoff(backoff Backoff, condition ConditionFunc) error {
func CheckAndRetryConn(r Realis, auroraCall AuroraThriftCall) (*aurora.Response, error) { func CheckAndRetryConn(r Realis, auroraCall AuroraThriftCall) (*aurora.Response, error) {
resp, cliErr := auroraCall() resp, cliErr := auroraCall()
// TODO: Rerturn different error type based on the error that was returned by the API call // TODO: Return different error type based on the error that was returned by the API call
if cliErr != nil { if cliErr != nil {
r.ReestablishConn() r.ReestablishConn()
return resp, NewPermamentError(RetryConnErr) return resp, NewPermamentError(RetryConnErr)