From 4bc0a694aead63bf772ce872d506640fc2f69574 Mon Sep 17 00:00:00 2001 From: Mothiki Date: Tue, 22 Aug 2017 17:03:35 -0700 Subject: [PATCH] use switch instead of if else conditions --- monitors.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/monitors.go b/monitors.go index 53cfe37..caf98d0 100644 --- a/monitors.go +++ b/monitors.go @@ -82,16 +82,17 @@ func (m *Monitor) JobUpdate(updateKey aurora.JobUpdateKey, interval int, timeout // Rolled forward is the only state in which an update has been successfully updated // if we encounter an inactive state and it is not at rolled forward, update failed - if status == aurora.JobUpdateStatus_ROLLED_FORWARD { + switch status { + case aurora.JobUpdateStatus_ROLLED_FORWARD: fmt.Println("Update succeded") return true, nil - } else if status == aurora.JobUpdateStatus_FAILED { + case aurora.JobUpdateStatus_FAILED: fmt.Println("Update failed") return false, errors.New(UpdateFailed) - } else if status == aurora.JobUpdateStatus_ROLLED_BACK { + case aurora.JobUpdateStatus_ROLLED_BACK: fmt.Println("rolled back") return false, errors.New(RolledBack) - } else { + default: return false, nil } }