ridv/gorealis
1
0
Fork 0
Code Issues Pull requests Projects Releases 23 Packages Wiki Activity Actions

Change JobUpdateKey pointers to be literals, then we deep copy the JobKey pointer to a new JobKey in order to avoid side effects.

Browse source
This commit is contained in:
Renan DelValle 2019-09-12 12:12:00 -07:00 • committed by Renan DelValle
parent 119d1c429b
commit 4fc4953ec4
1 changed files with 20 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

24
realis.go
View file

@ -606,12 +606,17 @@ func (c *Client) PauseJobUpdate(updateKey *aurora.JobUpdateKey, message string)
} }
// Resume Paused AuroraJob Update. UpdateID is returned from StartJobUpdate or the Aurora web UI. // Resume Paused AuroraJob Update. UpdateID is returned from StartJobUpdate or the Aurora web UI.
func (c *Client) ResumeJobUpdate(updateKey *aurora.JobUpdateKey, message string) error { func (c *Client) ResumeJobUpdate(updateKey aurora.JobUpdateKey, message string) error {
c.logger.DebugPrintf("ResumeJobUpdate Thrift Payload: %+v %v\n", updateKey, message) c.logger.DebugPrintf("ResumeJobUpdate Thrift Payload: %+v %v\n", updateKey, message)
updateKey.Job = &aurora.JobKey{
Role: updateKey.Job.Role,
Environment: updateKey.Job.Environment,
Name: updateKey.Job.Name,
}
_, retryErr := c.thriftCallWithRetries(false, func() (*aurora.Response, error) { _, retryErr := c.thriftCallWithRetries(false, func() (*aurora.Response, error) {
return c.client.ResumeJobUpdate(context.TODO(), updateKey, message) return c.client.ResumeJobUpdate(context.TODO(), &updateKey, message)
}) })
if retryErr != nil { if retryErr != nil {
@ -622,12 +627,17 @@ func (c *Client) ResumeJobUpdate(updateKey *aurora.JobUpdateKey, message string)
} }
// Pulse AuroraJob Update on Aurora. UpdateID is returned from StartJobUpdate or the Aurora web UI. // Pulse AuroraJob Update on Aurora. UpdateID is returned from StartJobUpdate or the Aurora web UI.
func (c *Client) PulseJobUpdate(updateKey *aurora.JobUpdateKey) (aurora.JobUpdatePulseStatus, error) { func (c *Client) PulseJobUpdate(updateKey aurora.JobUpdateKey) (aurora.JobUpdatePulseStatus, error) {
c.logger.DebugPrintf("PulseJobUpdate Thrift Payload: %+v\n", updateKey) c.logger.DebugPrintf("PulseJobUpdate Thrift Payload: %+v\n", updateKey)
updateKey.Job = &aurora.JobKey{
Role: updateKey.Job.Role,
Environment: updateKey.Job.Environment,
Name: updateKey.Job.Name,
}
resp, retryErr := c.thriftCallWithRetries(false, func() (*aurora.Response, error) { resp, retryErr := c.thriftCallWithRetries(false, func() (*aurora.Response, error) {
return c.client.PulseJobUpdate(context.TODO(), updateKey) return c.client.PulseJobUpdate(context.TODO(), &updateKey)
}) })
if retryErr != nil { if retryErr != nil {
@ -648,6 +658,12 @@ func (c *Client) AddInstances(instKey aurora.InstanceKey, count int32) error {
c.logger.DebugPrintf("AddInstances Thrift Payload: %+v %v\n", instKey, count) c.logger.DebugPrintf("AddInstances Thrift Payload: %+v %v\n", instKey, count)
instKey.JobKey = &aurora.JobKey{
Role: instKey.JobKey.Name,
Environment: instKey.JobKey.Environment,
Name: instKey.JobKey.Name,
}
_, retryErr := c.thriftCallWithRetries(false, func() (*aurora.Response, error) { _, retryErr := c.thriftCallWithRetries(false, func() (*aurora.Response, error) {
return c.client.AddInstances(context.TODO(), &instKey, count) return c.client.AddInstances(context.TODO(), &instKey, count)
}) })