ridv/gorealis
1
0
Fork 0
Code Issues Pull requests Projects Releases 23 Packages Wiki Activity Actions

* Adding a Pull request template to serve as a reminder of what

Browse source 
to do before creating the pull request.

* Updating our thrift API to match changes made by Aurora.

* Update go bindings to match update thrift API.
This commit is contained in:
Renan DelValle 2017-12-13 17:39:13 -08:00
parent 4c8d4ef532
commit 5ae80f2e32
No known key found for this signature in database
GPG key ID: C240AD6D6F443EC9
3 changed files with 12 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
.auroraversion
View file

@ -1 +1 @@
0.16.0
0.19.0

8
.github/PULL_REQUEST_TEMPLATE.md vendored Normal file
View file

@ -0,0 +1,8 @@
Before submitting, please make sure you run a vagrant box running Aurora with the latest version shown in .auroraversion
and run go test from the project root.
* Have you run goformat on the project before submitting?
* Have you run go test on the project before submitting? Do all tests pass?
* Does the Pull Request require a test to be added to the end to end tests? If so, has it been added?

6
realis.go
View file

@ -267,7 +267,7 @@ func NewRealisClient(options ...ClientOption) (Realis, error) {
config.protoFactory = thrift.NewTBinaryProtocolFactoryDefault()
}
config.logger.Printf("gorealis config url: %+v\n", config.url)
config.logger.Printf("gorealis config url: %+v\n", url)
//Basic Authentication.
if config.username != "" && config.password != "" {
@ -579,7 +579,7 @@ func (r *realisClient) KillInstances(key *aurora.JobKey, instances ...int32) (*a
retryErr := ExponentialBackoff(*r.config.backoff, func() (bool, error) {
resp, clientErr = CheckAndRetryConn(r, func() (*aurora.Response, error) {
return r.client.KillTasks(key, instanceIds)
return r.client.KillTasks(key, instanceIds, "")
})
if clientErr != nil && clientErr.Error() == RetryConnErr.Error() {
return false, nil
@ -614,7 +614,7 @@ func (r *realisClient) KillJob(key *aurora.JobKey) (*aurora.Response, error) {
if len(instanceIds) > 0 {
retryErr := ExponentialBackoff(*r.config.backoff, func() (bool, error) {
resp, clientErr = CheckAndRetryConn(r, func() (*aurora.Response, error) {
return r.client.KillTasks(key, instanceIds)
return r.client.KillTasks(key, instanceIds, "")
})
if clientErr != nil && clientErr.Error() == RetryConnErr.Error() {
return false, nil