ridv/gorealis
1
0
Fork 0
Code Issues Pull requests Projects Releases 23 Packages Wiki Activity Actions

Fixing possible race condition when passing backoff around as a pointer.

Browse source
This commit is contained in:
Renan DelValle 2018-03-05 23:23:16 -08:00
parent c0d2969976
commit 7152f568fe
No known key found for this signature in database
GPG key ID: C240AD6D6F443EC9
3 changed files with 13 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

12
realis.go
View file

@ -90,7 +90,7 @@ type RealisConfig struct {
timeoutms int
binTransport, jsonTransport bool
cluster *Cluster
backoff *Backoff
backoff Backoff
transport thrift.TTransport
protoFactory thrift.TProtocolFactory
logger Logger
@ -141,7 +141,7 @@ func ZKUrl(url string) ClientOption {
}
}
func Retries(backoff *Backoff) ClientOption {
func Retries(backoff Backoff) ClientOption {
return func(config *RealisConfig) {
config.backoff = backoff
}
@ -159,7 +159,7 @@ func ThriftBinary() ClientOption {
}
}
func BackOff(b *Backoff) ClientOption {
func BackOff(b Backoff) ClientOption {
return func(config *RealisConfig) {
config.backoff = b
}
@ -220,7 +220,7 @@ func NewRealisClient(options ...ClientOption) (Realis, error) {
// Default configs
config.timeoutms = 10000
config.backoff = &defaultBackoff
config.backoff = defaultBackoff
config.logger = NoopLogger{}
config.options = options
@ -570,14 +570,14 @@ func (r *realisClient) CreateService(auroraJob Job, settings *aurora.JobUpdateSe
resp, err := r.StartJobUpdate(update, "")
if err != nil {
return resp, nil, errors.Wrap(err, "unable to create service")
return nil, nil, errors.Wrap(err, "unable to create service")
}
if resp != nil && resp.GetResult_() != nil {
return resp, resp.GetResult_().GetStartJobUpdateResult_(), nil
}
return resp, nil, errors.New("results object is nil")
return nil, nil, errors.New("results object is nil")
}
func (r *realisClient) ScheduleCronJob(auroraJob Job) (*aurora.Response, error) {