ridv/gorealis
1
0
Fork 0
Code Issues Pull requests Projects Releases 23 Packages Wiki Activity Actions

Changing code comments to reflect getting rid of port override.

Browse source
This commit is contained in:
Renan DelValle 2018-04-12 15:22:25 -07:00
parent 0dec820951
commit 7f104dce70
No known key found for this signature in database
GPG key ID: C240AD6D6F443EC9
2 changed files with 3 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

3
examples/client.go
View file

@ -99,8 +99,7 @@ func main() {
fmt.Println("zkUrl: ", zkUrl)
clientOptions = append(clientOptions, realis.ZKUrl(zkUrl))
} else {
clientOptions = append(clientOptions, realis.SchedulerUrl(url),
realis.ZookeeperOptions(realis.ZKAuroraPortOverride(2343), realis.ZKAuroraSchemeOverride("https")))
clientOptions = append(clientOptions, realis.SchedulerUrl(url))
}
r, err = realis.NewRealisClient(clientOptions...)

5
realis.go
View file

@ -197,9 +197,8 @@ func ClientCerts(clientKey, clientCert string) ClientOption {
}
// Use this option if you'd like to override default settings for connecting to Zookeeper.
// For example, this can be used to override the port on which to communicate with Aurora.
// This may be helpful if Aurora is behind another service and running on a port that is different
// what is advertised in Zookeeper.
// For example, this can be used to override the scheme to be used for communicating with Aurora (e.g. https).
// See zk.go for what is possible to set as an option.
func ZookeeperOptions(opts ...ZKOpt) ClientOption {
return func(config *RealisConfig) {
config.zkOptions = opts