ridv/gorealis
1
0
Fork 0
Code Issues Pull requests Projects Releases 23 Packages Wiki Activity Actions

Bug fix: Modifying wrong field insite od the job update settings.

Browse source
This commit is contained in:
Renan DelValle 2017-07-11 12:37:34 -07:00
parent dd334d3a08
commit 8c29330e06
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
updatejob.go
View file

@ -56,7 +56,7 @@ func NewDefaultUpdateJob(config *aurora.TaskConfig) *UpdateJob {
req.Settings.UpdateOnlyTheseInstances = make(map[*aurora.Range]bool) req.Settings.UpdateOnlyTheseInstances = make(map[*aurora.Range]bool)
req.Settings.UpdateGroupSize = 1 req.Settings.UpdateGroupSize = 1
req.Settings.WaitForBatchCompletion = false req.Settings.WaitForBatchCompletion = false
req.Settings.MinWaitInInstanceRunningMs = 45000 // Deprecated req.Settings.MinWaitInInstanceRunningMs = 45000
req.Settings.MaxPerInstanceFailures = 0 req.Settings.MaxPerInstanceFailures = 0
req.Settings.MaxFailedInstances = 0 req.Settings.MaxFailedInstances = 0
req.Settings.RollbackOnFailure = true req.Settings.RollbackOnFailure = true
@ -110,8 +110,8 @@ func (u *UpdateJob) BatchSize(size int32) *UpdateJob {
} }
// Minimum number of seconds a shard must remain in RUNNING state before considered a success. // Minimum number of seconds a shard must remain in RUNNING state before considered a success.
func (u *UpdateJob) WatchTime(milliseconds int32) *UpdateJob { func (u *UpdateJob) WatchTime(ms int32) *UpdateJob {
u.req.Settings.MaxPerInstanceFailures = milliseconds u.req.Settings.MinWaitInInstanceRunningMs = ms
return u return u
} }