ridv/gorealis
1
0
Fork 0
Code Issues Pull requests Projects Releases 23 Packages Wiki Activity Actions

Integrating batch calculations into an AutoPause monitor which provides some guarantees to the user.

Browse source
This commit is contained in:
Renan DelValle 2019-09-18 15:38:58 -07:00
parent b73954cd7c
commit a0fa99df8a
No known key found for this signature in database
GPG key ID: C240AD6D6F443EC9
3 changed files with 60 additions and 64 deletions
Download patch file Download diff file Expand all files Collapse all files

47
realis.go
View file

@ -68,7 +68,6 @@ type Realis interface {
RollbackJobUpdate(key aurora.JobUpdateKey, message string) (*aurora.Response, error)
ScheduleCronJob(auroraJob Job) (*aurora.Response, error)
StartJobUpdate(updateJob *UpdateJob, message string) (*aurora.Response, error)
VariableBatchStep(key aurora.JobUpdateKey) (int, error)
PauseJobUpdate(key *aurora.JobUpdateKey, message string) (*aurora.Response, error)
ResumeJobUpdate(key *aurora.JobUpdateKey, message string) (*aurora.Response, error)
@ -1060,49 +1059,3 @@ func (r *realisClient) RollbackJobUpdate(key aurora.JobUpdateKey, message string
}
return resp, nil
}
// VariableBatchStep returns the current batch the update is in during a variable batch update.
func (r *realisClient) VariableBatchStep(key aurora.JobUpdateKey) (int, error) {
// Query Aurora for an Update that is either paused or rolling forward
resp, err := r.JobUpdateDetails(aurora.JobUpdateQuery{
UpdateStatuses: []aurora.JobUpdateStatus{
aurora.JobUpdateStatus_ROLLING_FORWARD,
aurora.JobUpdateStatus_ROLL_FORWARD_PAUSED,
},
Key: &key,
Limit: 1,
})
if err != nil {
return 0, errors.Wrap(err, "unable to determine current batch the update is in")
}
jobUpdates := response.JobUpdateDetails(resp)
if len(jobUpdates) == 0 {
return 0, errors.New("update provided could not be found in Aurora")
}
strategy := jobUpdates[0].GetUpdate().GetInstructions().GetSettings().GetUpdateStrategy()
if !strategy.IsSetVarBatchStrategy() {
return 0, errors.New("update strategy used by update config is not supported by this function")
}
// Using a map to create a set to guard against multiple INSTANCE_UPDATING events for the same shard.
updatingInstances := make(map[int32]struct{})
for _, e := range jobUpdates[0].GetInstanceEvents() {
// We only care about INSTANCE_UPDATING actions because we only care that they've been attempted
if e.GetAction() == aurora.JobUpdateAction_INSTANCE_UPDATING {
updatingInstances[e.GetInstanceId()] = struct{}{}
}
}
updatingInstancesCount := int32(len(updatingInstances))
for i, groupSize := range strategy.GetVarBatchStrategy().GetGroupSizes() {
updatingInstancesCount -= groupSize
if updatingInstancesCount <= 0 {
return i, nil
}
}
return 0, errors.New("unable to determine current batch the update is in")
}