From af488ad7c8dd53e39e9c46a11c8a329ec9bf9819 Mon Sep 17 00:00:00 2001 From: Renan DelValle Date: Wed, 9 Jan 2019 20:00:58 -0800 Subject: [PATCH] Using named parameters to be more explicit about what is being set. --- realis.go | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/realis.go b/realis.go index 69a95bc..b5bd391 100644 --- a/realis.go +++ b/realis.go @@ -270,7 +270,11 @@ func NewRealisClient(options ...ClientOption) (Realis, error) { // Default configs config.timeoutms = 10000 config.backoff = defaultBackoff - config.logger = &LevelLogger{log.New(os.Stdout, "realis: ", log.Ltime|log.Ldate|log.LUTC), false, false} + config.logger = &LevelLogger{ + Logger: log.New(os.Stdout, "realis: ", log.Ltime|log.Ldate|log.LUTC), + debug: false, + trace: false, + } // Save options to recreate client if a connection error happens config.options = options @@ -284,12 +288,16 @@ func NewRealisClient(options ...ClientOption) (Realis, error) { // Turn off all logging (including debug) if config.logger == nil { - config.logger = &LevelLogger{NoopLogger{}, false, false} + config.logger = &LevelLogger{Logger: NoopLogger{}, debug: false, trace: false} } // Set a logger if debug has been set to true but no logger has been set if config.logger == nil && config.debug { - config.logger = &LevelLogger{log.New(os.Stdout, "realis: ", log.Ltime|log.Ldate|log.LUTC), true, false} + config.logger = &LevelLogger{ + Logger: log.New(os.Stdout, "realis: ", log.Ltime|log.Ldate|log.LUTC), + debug: true, + trace: false, + } } config.logger.debug = config.debug @@ -361,7 +369,7 @@ func NewRealisClient(options ...ClientOption) (Realis, error) { client: aurora.NewAuroraSchedulerManagerClientFactory(config.transport, config.protoFactory), readonlyClient: aurora.NewReadOnlySchedulerClientFactory(config.transport, config.protoFactory), adminClient: aurora.NewAuroraAdminClientFactory(config.transport, config.protoFactory), - logger: LevelLogger{config.logger, config.debug, config.trace}, + logger: LevelLogger{Logger: config.logger, debug: config.debug, trace: config.trace}, lock: &sync.Mutex{}}, nil }