Thrift API update and Pull Request template. (#43)
* Adding a Pull request template to serve as a reminder of what to do before creating the pull request. * Updating our thrift API to match changes made by Aurora. * Update go bindings to match update thrift API.
This commit is contained in:
parent
d4027bc95c
commit
c338c03355
10 changed files with 1227 additions and 1729 deletions
11
.github/PULL_REQUEST_TEMPLATE.md
vendored
Normal file
11
.github/PULL_REQUEST_TEMPLATE.md
vendored
Normal file
|
@ -0,0 +1,11 @@
|
|||
Before submitting, please make sure you run a vagrant box running Aurora with the latest version shown in .auroraversion
|
||||
and run go test from the project root.
|
||||
|
||||
To run an Aurora Vagrant image, follow the instructions here:
|
||||
http://aurora.apache.org/documentation/latest/getting-started/vagrant/
|
||||
|
||||
* Have you run goformat on the project before submitting?
|
||||
|
||||
* Have you run go test on the project before submitting? Do all tests pass?
|
||||
|
||||
* Does the Pull Request require a test to be added to the end to end tests? If so, has it been added?
|
Loading…
Add table
Add a link
Reference in a new issue