ridv/gorealis
1
0
Fork 0
Code Issues Pull requests Projects Releases 23 Packages Wiki Activity Actions

Updating comments

Browse source
This commit is contained in:
Renán Del Valle 2021-05-01 13:27:07 -07:00
parent 1c732146b1
commit e3518ec407
No known key found for this signature in database
GPG key ID: C240AD6D6F443EC9
1 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

9
retry.go
View file

@ -161,8 +161,7 @@ func (r *realisClient) thriftCallWithRetries(
r.logger.tracePrintf("Aurora Thrift Call ended resp: %v clientErr: %v", resp, clientErr) r.logger.tracePrintf("Aurora Thrift Call ended resp: %v clientErr: %v", resp, clientErr)
}() }()
// Check if our thrift call is returning an error. This is a retryable event as we don't know // Check if our thrift call is returning an error.
// if it was caused by network issues.
if clientErr != nil { if clientErr != nil {
// Print out the error to the user // Print out the error to the user
r.logger.Printf("Client Error: %v", clientErr) r.logger.Printf("Client Error: %v", clientErr)
@ -182,10 +181,12 @@ func (r *realisClient) thriftCallWithRetries(
// Allow caller to provide a function which checks if the original call was successful before // Allow caller to provide a function which checks if the original call was successful before
// it timed out. // it timed out.
if verifyOnTimeout != nil { if verifyOnTimeout != nil {
if verifyResp, ok := verifyOnTimeout(); ok { if verifyResp, ok := verifyOnTimeout(); ok {
r.logger.debugPrint("verified that the call went through successfully") r.logger.debugPrint("verified that the call went through successfully")
// Response here might be different than the original. // Response here might be different than the original as it is no longer constructed
// by the scheduler but mimicked.
// This is OK since the scheduler is very unlikely to change responses at this point in its
// development cycle but we must be careful to not return an incorrectly constructed response.
return verifyResp, nil return verifyResp, nil
} }
} }