ridv/gorealis
1
0
Fork 0
Code Issues Pull requests Projects Releases 23 Packages Wiki Activity Actions

Addressing feedback comments. Running code through goimports.

Browse source
This commit is contained in:
Renan DelValle 2019-01-08 11:06:08 -08:00
parent 25f5ff9f07
commit f39551af14
No known key found for this signature in database
GPG key ID: C240AD6D6F443EC9
2 changed files with 8 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

13
job.go
View file

@ -96,15 +96,8 @@ func NewJob() Job {
ramMb := aurora.NewResource()
diskMb := aurora.NewResource()
resources := make(map[ResourceType]*aurora.Resource)
resources[CPU] = numCpus
resources[RAM] = ramMb
resources[DISK] = diskMb
taskConfig.Resources = make(map[*aurora.Resource]bool)
taskConfig.Resources[numCpus] = true
taskConfig.Resources[ramMb] = true
taskConfig.Resources[diskMb] = true
resources := map[ResourceType]*aurora.Resource{CPU: numCpus, RAM: ramMb, DISK: diskMb}
taskConfig.Resources = map[*aurora.Resource]bool{numCpus: true, ramMb: true, diskMb: true}
numCpus.NumCpus = new(float64)
ramMb.RamMb = new(int64)
@ -178,7 +171,7 @@ func (j *AuroraJob) Disk(disk int64) Job {
}
func (j *AuroraJob) GPU(gpus int64) Job {
if _,ok := j.resources[GPU]; !ok {
if _, ok := j.resources[GPU]; !ok {
numGPUs := &aurora.Resource{NumGpus: new(int64)}
j.resources[GPU] = numGPUs
j.TaskConfig().Resources[numGPUs] = true

11
realis_e2e_test.go
View file

@ -28,6 +28,7 @@ import (
"github.com/paypal/gorealis/response"
"github.com/pkg/errors"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
var r realis.Realis
@ -338,10 +339,9 @@ pulseLoop:
select {
case <-ticker.C:
fmt.Println("sending PulseJobUpdate....")
resp, err = r.PulseJobUpdate(result.GetKey())
assert.NotNil(t, resp)
require.NotNil(t, resp, "received a nil response from Aurora")
assert.Nil(t, err)
respDetail, err := r.JobUpdateDetails(updateQ)
@ -372,14 +372,13 @@ pulseLoop:
_, err := r.AbortJobUpdate(*updateDetails[0].GetUpdate().GetSummary().GetKey(), "")
assert.NoError(t, err)
_, err = r.KillJob(job.JobKey())
assert.NoError(t, err)
assert.FailNow(t, "timed out during pulse update test")
require.NoError(t, err, "timed out during pulse update test")
}
}
resp, err = r.KillJob(job.JobKey())
assert.NoError(t, err)
assert.Equal(t, aurora.ResponseCode_OK, resp.ResponseCode)
assert.NoError(t, err)
assert.Equal(t, aurora.ResponseCode_OK, resp.ResponseCode)
}
// Test configuring an executor that doesn't exist for CreateJob API