* Moving from govendor to dep. * Making the pull request template more friendly. * Fixing akward space in PR template. * goimports run on whole project using ` goimports -w $(find . -type f -name '*.go' -not -path "./vendor/*" -not -path "./gen-go/*")` source of command: https://gist.github.com/bgentry/fd1ffef7dbde01857f66 |
||
---|---|---|
.. | ||
break1.thrift | ||
break2.thrift | ||
break3.thrift | ||
break4.thrift | ||
break5.thrift | ||
break6.thrift | ||
break7.thrift | ||
break8.thrift | ||
break9.thrift | ||
break10.thrift | ||
break11.thrift | ||
break12.thrift | ||
break13.thrift | ||
break14.thrift | ||
break15.thrift | ||
break16.thrift | ||
break17.thrift | ||
break18.thrift | ||
break19.thrift | ||
break20.thrift | ||
break21.thrift | ||
break22.thrift | ||
break23.thrift | ||
break24.thrift | ||
break25.thrift | ||
break26.thrift | ||
break27.thrift | ||
break28.thrift | ||
break29.thrift | ||
break30.thrift | ||
break31.thrift | ||
break32.thrift | ||
break33.thrift | ||
break34.thrift | ||
README.md | ||
test.thrift | ||
thrift_audit_test.pl | ||
warning.thrift |
Typical usage
thrift.exe --audit <oldFile> <newFile>
Example run
> thrift.exe --audit test.thrift break1.thrift
[Thrift Audit Failure:break1.thrift] New Thrift File has missing function base_function3
[Thrift Audit Warning:break1.thrift] Constant const3 has different value
Problems that the audit tool can catch
Errors
- Removing an enum value
- Changing the type of a struct field
- Changing the required-ness of a struct field
- Removing a struct field
- Adding a required struct field
- Adding a struct field 'in the middle'. This usually indicates an old ID has been recycled
- Struct removed
- Oneway-ness change
- Return type change
- Missing function
- Missing service
- Change in service inheritance
Warnings
- Removing a language namespace declaration
- Changing a namespace
- Changing an enum value's name
- Removing an enum class
- Default value changed
- Struct field name change
- Removed constant
- Type of constant changed
- Value of constant changed