* Deleting permament error as it doesn't make sense. Just return a plain old error and that will be considered permanent. * Removing double closure at as it's unmaintainable and can be error prone. Separated back offs into a generic one and a thrift call specific one. * ZK leader finder now returns a temporary error instead of constantly no leader found and quitting. It could be that the leader info is being propagated so it's worth trying another time. * Adding more logging to the retry. * Wrapping lock and unlock in an anonymous function so that we can use defer on unlock such that it is called in the case of a panic.
65 lines
1.6 KiB
Go
65 lines
1.6 KiB
Go
/**
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package realis
|
|
|
|
// Using a pattern described by Dave Cheney to differentiate errors
|
|
// https://dave.cheney.net/2016/04/27/dont-just-check-errors-handle-them-gracefully
|
|
|
|
// Timeout errors are returned when a function has unsuccessfully retried.
|
|
type timeout interface {
|
|
Timeout() bool
|
|
}
|
|
|
|
func IsTimeout(err error) bool {
|
|
temp, ok := err.(timeout)
|
|
return ok && temp.Timeout()
|
|
}
|
|
|
|
type TimeoutErr struct {
|
|
error
|
|
timeout bool
|
|
}
|
|
|
|
func (t *TimeoutErr) Timeout() bool {
|
|
return t.timeout
|
|
}
|
|
|
|
func NewTimeoutError(err error) *TimeoutErr {
|
|
return &TimeoutErr{error: err, timeout: true}
|
|
}
|
|
|
|
// Temporary errors indicate that the action may and should be retried.
|
|
type temporary interface {
|
|
Temporary() bool
|
|
}
|
|
|
|
func IsTemporary(err error) bool {
|
|
temp, ok := err.(temporary)
|
|
return ok && temp.Temporary()
|
|
}
|
|
|
|
type TemporaryErr struct {
|
|
error
|
|
temporary bool
|
|
}
|
|
|
|
func (t *TemporaryErr) Temporary() bool {
|
|
return t.temporary
|
|
}
|
|
|
|
// Retrying after receiving this error is advised
|
|
func NewTemporaryError(err error) *TemporaryErr {
|
|
return &TemporaryErr{error: err, temporary: true}
|
|
}
|