From 1b821735ed6663d9d533c449a54b072a6fb83cb1 Mon Sep 17 00:00:00 2001 From: Pradyumna Kaushik Date: Tue, 20 Dec 2016 13:53:28 -0500 Subject: [PATCH] fixed bug in Remove() where the currentSum and numberOfTasksInWindow weren't getting updated. --- utilities/runAvg/runAvg.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/utilities/runAvg/runAvg.go b/utilities/runAvg/runAvg.go index f832732..993577f 100644 --- a/utilities/runAvg/runAvg.go +++ b/utilities/runAvg/runAvg.go @@ -74,6 +74,8 @@ func (rac *runningAverageCalculator) removeFromWindow(id string) (interface{}, e for element := rac.window.Front(); element != nil; element = element.Next() { if elementToRemove := element.Value.(Interface); elementToRemove.ID() == id { rac.window.Remove(element) + rac.currentSum -= elementToRemove.Val() + rac.numberOfElementsInWindow-- return elementToRemove, nil } }