spdf/elektron
Archived
1
0
Fork 0
Code Issues 4 Pull requests 1 Projects Releases Packages Wiki Activity

Prevented the use of reflect and instead compared the TaskIDs of the tasks.

Browse source
This commit is contained in:
Pradyumna Kaushik 2016-11-28 20:02:03 -05:00 • committed by Renan DelValle
parent 1c8265b87b
commit 6289b8954d
1 changed files with 3 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

13
def/task.go
View file

@ -5,7 +5,6 @@ import (
"encoding/json" "encoding/json"
"github.com/pkg/errors" "github.com/pkg/errors"
"os" "os"
"reflect"
) )
type Task struct { type Task struct {
@ -85,15 +84,9 @@ func Compare(task1 *Task, task2 *Task) bool {
if task1 == task2 { if task1 == task2 {
return true return true
} }
// Checking member equality if task1.TaskID != task2.TaskID {
if reflect.DeepEqual(*task1, *task2) {
// Need to check for the task ID
if task1.TaskID == task2.TaskID {
return true
} else {
return false
}
} else {
return false return false
} else {
return true
} }
} }