Minor code style fixes

Removed the global logger instance and kept it in LoggerImpl
struct.
Changed access level for members of LoggerImpl.
This commit is contained in:
balandi1 2019-12-04 14:56:48 -05:00
parent c914161643
commit 64ab443d25
8 changed files with 111 additions and 105 deletions

View file

@ -12,25 +12,26 @@ type SchedTraceLogger struct {
LoggerImpl
}
func NewSchedTraceLogger(b *baseLogData, logType int, prefix string) *SchedTraceLogger {
func NewSchedTraceLogger(b *baseLogData, logType int, prefix string, logger *log.Logger) *SchedTraceLogger {
sLog := &SchedTraceLogger{}
sLog.Type = logType
sLog.logType = logType
sLog.CreateLogFile(prefix)
sLog.next = nil
sLog.baseLogData = b
sLog.logger = logger
return sLog
}
func (sLog SchedTraceLogger) Log(logType int, level log.Level, message string) {
if sLog.Type == logType {
if sLog.logType == logType {
if config.SchedTraceConfig.Enabled {
if sLog.AllowOnConsole {
logger.SetOutput(os.Stdout)
logger.WithFields(sLog.data).Log(level, message)
if sLog.allowOnConsole {
sLog.logger.SetOutput(os.Stdout)
sLog.logger.WithFields(sLog.data).Log(level, message)
}
logger.SetOutput(sLog.LogFile)
logger.WithFields(sLog.data).Log(level, message)
sLog.logger.SetOutput(sLog.logFile)
sLog.logger.WithFields(sLog.data).Log(level, message)
}
}
if sLog.next != nil {
@ -42,15 +43,15 @@ func (sLog SchedTraceLogger) Log(logType int, level log.Level, message string) {
}
func (sLog SchedTraceLogger) Logf(logType int, level log.Level, msgFmtString string, args ...interface{}) {
if sLog.Type == logType {
if sLog.logType == logType {
if config.SchedTraceConfig.Enabled {
if sLog.AllowOnConsole {
logger.SetOutput(os.Stdout)
logger.WithFields(sLog.data).Logf(level, msgFmtString, args...)
if sLog.allowOnConsole {
sLog.logger.SetOutput(os.Stdout)
sLog.logger.WithFields(sLog.data).Logf(level, msgFmtString, args...)
}
logger.SetOutput(sLog.LogFile)
logger.WithFields(sLog.data).Logf(level, msgFmtString, args...)
sLog.logger.SetOutput(sLog.logFile)
sLog.logger.WithFields(sLog.data).Logf(level, msgFmtString, args...)
}
}
// Forwarding to next logger
@ -70,8 +71,8 @@ func (sLog *SchedTraceLogger) CreateLogFile(prefix string) {
if logFile, err := os.Create(filepath.Join(dirName, filename)); err != nil {
log.Fatal("Unable to create logFile: ", err)
} else {
sLog.LogFile = logFile
sLog.AllowOnConsole = config.SchedTraceConfig.AllowOnConsole
sLog.logFile = logFile
sLog.allowOnConsole = config.SchedTraceConfig.AllowOnConsole
}
}
}