spdf/elektron
Archived
1
0
Fork 0
Code Issues 4 Pull requests 1 Projects Releases Packages Wiki Activity

Changing shortWindow to longWindow as constraint_0 actually points to the long window.

Browse source
This commit is contained in:
Renan DelValle 2020-01-17 09:33:43 -08:00
parent 74545680fc
commit 74b488750d
No known key found for this signature in database
GPG key ID: 3895800E03F17676
1 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

12
rapl-daemon/util.go
View file

@ -12,9 +12,9 @@ import (
const raplPrefixCPU = "intel-rapl" const raplPrefixCPU = "intel-rapl"
// constraint_0 is usually the longer window while constraint_1 is usually the longer window // constraint_0 is usually the longer window while constraint_1 is usually the shorter window
const maxPowerFileShortWindow = "constraint_0_max_power_uw" const maxPowerFileLongWindow = "constraint_0_max_power_uw"
const powerLimitFileShortWindow = "constraint_0_power_limit_uw" const powerLimitFileLongWindow = "constraint_0_power_limit_uw"
// capNode uses pseudo files made available by the Linux kernel // capNode uses pseudo files made available by the Linux kernel
// in order to capNode CPU power. More information is available at: // in order to capNode CPU power. More information is available at:
@ -22,7 +22,7 @@ const powerLimitFileShortWindow = "constraint_0_power_limit_uw"
func capNode(base string, percentage int) error { func capNode(base string, percentage int) error {
if percentage <= 0 || percentage > 100 { if percentage <= 0 || percentage > 100 {
return fmt.Errorf("cap percentage must be between 0 (non-inclusive) and 100 (inclusive): %d", percentage) return fmt.Errorf("cap percentage must be between (0, 100]: %d", percentage)
} }
files, err := ioutil.ReadDir(base) files, err := ioutil.ReadDir(base)
@ -41,7 +41,7 @@ func capNode(base string, percentage int) error {
} }
if fields[0] == raplPrefixCPU { if fields[0] == raplPrefixCPU {
maxPower, err := maxPower(filepath.Join(base, file.Name(), maxPowerFileShortWindow)) maxPower, err := maxPower(filepath.Join(base, file.Name(), maxPowerFileLongWindow))
if err != nil { if err != nil {
fmt.Println("unable to retreive max power for zone ", err) fmt.Println("unable to retreive max power for zone ", err)
continue continue
@ -50,7 +50,7 @@ func capNode(base string, percentage int) error {
// We use floats to mitigate the possibility of an integer overflows. // We use floats to mitigate the possibility of an integer overflows.
powercap := uint64(math.Ceil(float64(maxPower) * (float64(percentage) / 100))) powercap := uint64(math.Ceil(float64(maxPower) * (float64(percentage) / 100)))
err = capZone(filepath.Join(base, file.Name(), powerLimitFileShortWindow), powercap) err = capZone(filepath.Join(base, file.Name(), powerLimitFileLongWindow), powercap)
if err != nil { if err != nil {
fmt.Println("unable to write powercap value: ", err) fmt.Println("unable to write powercap value: ", err)
continue continue