spdf/elektron
Archived
1
0
Fork 0
Code Issues 4 Pull requests 1 Projects Releases Packages Wiki Activity

Removed TODO comment in ResourceOffers(...), that wasn't necessary anymore.

Browse source
This commit is contained in:
Pradyumna Kaushik 2016-11-28 22:38:02 -05:00 • committed by Renan DelValle
parent 7f5d9c58a3
commit 8eda0c68b1
1 changed files with 0 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
schedulers/proactiveclusterwidecappingfcfs.go
View file

@ -234,7 +234,6 @@ func (s *ProactiveClusterwideCapFCFS) stopRecapping() {
}
}
// TODO: Need to reduce the time complexity: looping over offers twice (Possible to do it just once?).
func (s *ProactiveClusterwideCapFCFS) ResourceOffers(driver sched.SchedulerDriver, offers []*mesos.Offer) {
log.Printf("Received %d resource offers", len(offers))
@ -272,8 +271,6 @@ func (s *ProactiveClusterwideCapFCFS) ResourceOffers(driver sched.SchedulerDrive
3. fcfsCurrentCapValue is updated with the determined cluster wide cap.
Cluster wide capping is currently performed at regular intervals of time.
TODO: We can choose to cap the cluster only if the clusterwide cap varies more than the current clusterwide cap.
Although this sounds like a better approach, it only works when the resource requirements of neighbouring tasks are similar.
*/
taken := false