spdf/elektron
Archived
1
0
Fork 0
Code Issues 4 Pull requests 1 Projects Releases Packages Wiki Activity

workload validation before registering elektron. #19

Merged
pradykaushik merged 2 commits from issues/issue-18-workload-validation into master 2019-11-26 08:08:12 +00:00
Conversation 2 Commits 2 Files changed 5 +220 -1
pradykaushik commented 2019-11-23 01:17:47 +00:00 (Migrated from github.com)
Copy link

Added a utility to help with validating structs. This utility accepts
validators and runs them. If any of the validators fail, then the
error is wrapped with a given base message and returned.

Added validators for checking different attributes of a task
definition.

Added test code to test task validators.

Retrofitted scheduler.go to just log the task validation error and
terminate. If task validation does not report any error, then the
tasks are provided to the scheduler and elektron registers itself
with Mesos.

Added a utility to help with validating structs. This utility accepts validators and runs them. If any of the validators fail, then the error is wrapped with a given base message and returned. Added validators for checking different attributes of a task definition. Added test code to test task validators. Retrofitted scheduler.go to just log the task validation error and terminate. If task validation does not report any error, then the tasks are provided to the scheduler and elektron registers itself with Mesos.
ridv (Migrated from github.com) approved these changes 2019-11-25 22:54:11 +00:00
def/task.go
@ -58,0 +67,4 @@
return tasks, err
}
}
ridv (Migrated from github.com) commented 2019-11-25 22:46:17 +00:00

Awesome idea

Awesome idea
utilities/validation/validate.go
ridv (Migrated from github.com) commented 2019-11-25 22:54:02 +00:00

Do we need to keep this around?

Do we need to keep this around?
pradykaushik (Migrated from github.com) reviewed 2019-11-26 07:59:30 +00:00
utilities/validation/validate.go
pradykaushik (Migrated from github.com) commented 2019-11-26 07:59:30 +00:00

Yeah, the example might be an overkill. I'll get rid of it.

Yeah, the example might be an overkill. I'll get rid of it.
This repository is archived. You cannot comment on pull requests.
Reviewers
No reviewers
ridv
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
fix

Fix files/design

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
major

of high importance

  
question

Further information is requested

  
testing

add test code

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
fix
good first issue
help wanted
invalid
major
question
testing
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: spdf/elektron#19
No description provided.
Delete branch "issues/issue-18-workload-validation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?