change Log() and Logf() to be pointer receivers and add test coverage. #23

New issue

Open

opened 2020-02-05 01:43:05 +00:00 by pradykaushik · 0 comments

pradykaushik commented

2020-02-05 01:43:05 +00:00

(Migrated from github.com)

Log and Logf should be pointer receivers for resetFields() to actually reset the fields of the original object and and not the copy.

This also makes adding test coverage all the more pertinent.

[Log](https://github.com/spdfg/elektron/blob/master/logging/pcpLogger.go#L64) and [Logf](https://github.com/spdfg/elektron/blob/master/logging/pcpLogger.go#L84) should be pointer receivers for `resetFields()` to actually reset the fields of the original object and and not the copy. This also makes adding test coverage all the more pertinent.

This repository is archived. You cannot comment on issues.