Refactor imports, Add vendor/ as submodule #5

Merged

pradykaushik merged 6 commits from fix/refactor-imports-vendor-gomod into master

2019-10-31 18:32:47 +00:00

pradykaushik commented

2019-10-25 00:37:08 +00:00

(Migrated from github.com)

Refactored modules to now be prefixed with github.com/spdf/elektron instead of gitlab.com/spdf/elektron.
Ran go mod init github.com/spdf/elektron to regenerate the go.mod and go.sum files.
Ran go mod vendor to update the vendored repositories.

Note: Haven't yet changed the organization name from "spdf" to "spdfg" in the imports. We can do this once we are sure of the name.

1. Refactored modules to now be prefixed with `github.com/spdf/elektron` instead of `gitlab.com/spdf/elektron`. 2. Ran `go mod init github.com/spdf/elektron` to regenerate the go.mod and go.sum files. 3. Ran `go mod vendor` to update the vendored repositories. Note: Haven't yet changed the organization name from "spdf" to "spdfg" in the imports. We can do this once we are sure of the name.

ridv commented

2019-10-25 16:14:13 +00:00

(Migrated from github.com)

This might be a good chance to experiment with keeping a separate repo with the dependencies. Something like elektron-vendor.

We can use git submodules to manage it. https://git-scm.com/book/en/v2/Git-Tools-Submodules

So this is how I would envision it working:

First line of defense using mod to download dependencies.
Second line, if something got moved, using the elektron-vendor repository to download the dependencies.

This might be a good chance to experiment with keeping a separate repo with the dependencies. Something like elektron-vendor. We can use git submodules to manage it. https://git-scm.com/book/en/v2/Git-Tools-Submodules So this is how I would envision it working: First line of defense using mod to download dependencies. Second line, if something got moved, using the elektron-vendor repository to download the dependencies.

👍 1

pradykaushik commented

2019-10-29 19:46:09 +00:00

(Migrated from github.com)

@rdelval pending review.

ridv (Migrated from github.com) approved these changes 2019-10-31 17:44:20 +00:00