WIP : Elektron Logging library #16
|
@ -107,7 +107,7 @@ func BuildLogger(prefix string, logConfigFilename string) error {
|
|||
![]() ditto ditto
![]() ditto ditto
![]() Yes. Removed it from there Yes. Removed it from there
![]() Done Done
![]() Done Done
![]()
`isEnabled()` does not have to be part of the interface.
![]() ditto ditto
![]() ditto ditto
![]() Yes. Removed it from there Yes. Removed it from there
![]() Done Done
![]() Done Done
|
||||
head := &baseElektronLogger{baseLogData: b}
|
||||
|
||||
// Read configuration from yaml.
|
||||
if config, err := GetConfig(logConfigFilename); err != nil {
|
||||
![]()
`isEnabled()` does not have to be part of the interface.
![]() ditto ditto
![]() ditto ditto
![]() Yes. Removed it from there Yes. Removed it from there
![]() Done Done
![]() Done Done
|
||||
if config, err := getConfig(logConfigFilename); err != nil {
|
||||
![]()
`isEnabled()` does not have to be part of the interface.
![]() ditto ditto
![]() ditto ditto
![]() Yes. Removed it from there Yes. Removed it from there
![]() Done Done
![]() Done Done
|
||||
return errors.Wrap(err, "Failed to build logger")
|
||||
} else {
|
||||
cLog := newConsoleLogger(config, b, CONSOLE, prefix, logger, logDir)
|
||||
|
|
|||
![]()
`isEnabled()` does not have to be part of the interface.
![]() ditto ditto
![]() ditto ditto
![]() Yes. Removed it from there Yes. Removed it from there
![]() Done Done
![]() Done Done
![]()
`isEnabled()` does not have to be part of the interface.
![]() ditto ditto
![]() ditto ditto
![]() Yes. Removed it from there Yes. Removed it from there
![]() Done Done
![]() Done Done
|
|
@ -48,7 +48,7 @@ type loggerConfig struct {
|
|||
![]() does this need to be exported outside the package? does this need to be exported outside the package?
![]() No, not needed. Changed it to No, not needed. Changed it to `getConfig` .
![]() does this need to be exported outside the package? does this need to be exported outside the package?
![]() No, not needed. Changed it to No, not needed. Changed it to `getConfig` .
|
||||
Format []string `yaml:"format"`
|
||||
}
|
||||
|
||||
func GetConfig(logConfigFilename string) (*loggerConfig, error) {
|
||||
![]() does this need to be exported outside the package? does this need to be exported outside the package?
![]() No, not needed. Changed it to No, not needed. Changed it to `getConfig` .
|
||||
func getConfig(logConfigFilename string) (*loggerConfig, error) {
|
||||
![]() does this need to be exported outside the package? does this need to be exported outside the package?
![]() No, not needed. Changed it to No, not needed. Changed it to `getConfig` .
|
||||
|
||||
yamlFile, err := ioutil.ReadFile(logConfigFilename)
|
||||
if err != nil {
|
||||
|
|
|||
![]() does this need to be exported outside the package? does this need to be exported outside the package?
![]() No, not needed. Changed it to No, not needed. Changed it to `getConfig` .
![]() does this need to be exported outside the package? does this need to be exported outside the package?
![]() No, not needed. Changed it to No, not needed. Changed it to `getConfig` .
|
isEnabled()
does not have to be part of the interface.