spdf/elektron
Archived
1
0
Fork 0
Code Issues 4 Pull requests 1 Projects Releases Packages Wiki Activity

WIP : Elektron Logging library #16

Merged
balandi1 merged 50 commits from master into master 2019-12-10 01:15:34 +00:00
Conversation 113 Commits 50 Files changed 61 +2 -2
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 0ecbe55398 - Show all commits

2
logging/logger.go
View file

@ -107,7 +107,7 @@ func BuildLogger(prefix string, logConfigFilename string) error {
pradykaushik commented 2019-12-06 22:03:56 +00:00 (Migrated from github.com)
Copy link

isEnabled() does not have to be part of the interface.

`isEnabled()` does not have to be part of the interface.
pradykaushik commented 2019-12-06 22:04:02 +00:00 (Migrated from github.com)
Copy link

ditto

ditto
pradykaushik commented 2019-12-06 22:04:11 +00:00 (Migrated from github.com)
Copy link

ditto

ditto
balandi1 commented 2019-12-09 15:41:29 +00:00 (Migrated from github.com)
Copy link

Yes. Removed it from there

Yes. Removed it from there
balandi1 commented 2019-12-09 15:42:13 +00:00 (Migrated from github.com)
Copy link

Done

Done
balandi1 commented 2019-12-09 15:42:23 +00:00 (Migrated from github.com)
Copy link

Done

Done
pradykaushik commented 2019-12-06 22:03:56 +00:00 (Migrated from github.com)
Copy link

isEnabled() does not have to be part of the interface.

`isEnabled()` does not have to be part of the interface.
pradykaushik commented 2019-12-06 22:04:02 +00:00 (Migrated from github.com)
Copy link

ditto

ditto
pradykaushik commented 2019-12-06 22:04:11 +00:00 (Migrated from github.com)
Copy link

ditto

ditto
balandi1 commented 2019-12-09 15:41:29 +00:00 (Migrated from github.com)
Copy link

Yes. Removed it from there

Yes. Removed it from there
balandi1 commented 2019-12-09 15:42:13 +00:00 (Migrated from github.com)
Copy link

Done

Done
balandi1 commented 2019-12-09 15:42:23 +00:00 (Migrated from github.com)
Copy link

Done

Done
head := &baseElektronLogger{baseLogData: b} head := &baseElektronLogger{baseLogData: b}
// Read configuration from yaml. // Read configuration from yaml.
if config, err := GetConfig(logConfigFilename); err != nil { if config, err := getConfig(logConfigFilename); err != nil {
pradykaushik commented 2019-12-06 22:03:56 +00:00 (Migrated from github.com)
Copy link

isEnabled() does not have to be part of the interface.

`isEnabled()` does not have to be part of the interface.
pradykaushik commented 2019-12-06 22:04:02 +00:00 (Migrated from github.com)
Copy link

ditto

ditto
pradykaushik commented 2019-12-06 22:04:11 +00:00 (Migrated from github.com)
Copy link

ditto

ditto
balandi1 commented 2019-12-09 15:41:29 +00:00 (Migrated from github.com)
Copy link

Yes. Removed it from there

Yes. Removed it from there
balandi1 commented 2019-12-09 15:42:13 +00:00 (Migrated from github.com)
Copy link

Done

Done
balandi1 commented 2019-12-09 15:42:23 +00:00 (Migrated from github.com)
Copy link

Done

Done
pradykaushik commented 2019-12-06 22:03:56 +00:00 (Migrated from github.com)
Copy link

isEnabled() does not have to be part of the interface.

`isEnabled()` does not have to be part of the interface.
pradykaushik commented 2019-12-06 22:04:02 +00:00 (Migrated from github.com)
Copy link

ditto

ditto
pradykaushik commented 2019-12-06 22:04:11 +00:00 (Migrated from github.com)
Copy link

ditto

ditto
balandi1 commented 2019-12-09 15:41:29 +00:00 (Migrated from github.com)
Copy link

Yes. Removed it from there

Yes. Removed it from there
balandi1 commented 2019-12-09 15:42:13 +00:00 (Migrated from github.com)
Copy link

Done

Done
balandi1 commented 2019-12-09 15:42:23 +00:00 (Migrated from github.com)
Copy link

Done

Done
return errors.Wrap(err, "Failed to build logger") return errors.Wrap(err, "Failed to build logger")
} else { } else {
cLog := newConsoleLogger(config, b, CONSOLE, prefix, logger, logDir) cLog := newConsoleLogger(config, b, CONSOLE, prefix, logger, logDir)

pradykaushik commented 2019-12-06 22:03:56 +00:00 (Migrated from github.com)
Copy link

isEnabled() does not have to be part of the interface.

`isEnabled()` does not have to be part of the interface.
pradykaushik commented 2019-12-06 22:04:02 +00:00 (Migrated from github.com)
Copy link

ditto

ditto
pradykaushik commented 2019-12-06 22:04:11 +00:00 (Migrated from github.com)
Copy link

ditto

ditto
balandi1 commented 2019-12-09 15:41:29 +00:00 (Migrated from github.com)
Copy link

Yes. Removed it from there

Yes. Removed it from there
balandi1 commented 2019-12-09 15:42:13 +00:00 (Migrated from github.com)
Copy link

Done

Done
balandi1 commented 2019-12-09 15:42:23 +00:00 (Migrated from github.com)
Copy link

Done

Done
pradykaushik commented 2019-12-06 22:03:56 +00:00 (Migrated from github.com)
Copy link

isEnabled() does not have to be part of the interface.

`isEnabled()` does not have to be part of the interface.
pradykaushik commented 2019-12-06 22:04:02 +00:00 (Migrated from github.com)
Copy link

ditto

ditto
pradykaushik commented 2019-12-06 22:04:11 +00:00 (Migrated from github.com)
Copy link

ditto

ditto
balandi1 commented 2019-12-09 15:41:29 +00:00 (Migrated from github.com)
Copy link

Yes. Removed it from there

Yes. Removed it from there
balandi1 commented 2019-12-09 15:42:13 +00:00 (Migrated from github.com)
Copy link

Done

Done
balandi1 commented 2019-12-09 15:42:23 +00:00 (Migrated from github.com)
Copy link

Done

Done

2
logging/loggerConfig.go
View file

@ -48,7 +48,7 @@ type loggerConfig struct {
pradykaushik commented 2019-12-06 22:05:07 +00:00 (Migrated from github.com)
Copy link

does this need to be exported outside the package?

does this need to be exported outside the package?
balandi1 commented 2019-12-09 16:03:06 +00:00 (Migrated from github.com)
Copy link

No, not needed. Changed it to getConfig .

No, not needed. Changed it to `getConfig` .
pradykaushik commented 2019-12-06 22:05:07 +00:00 (Migrated from github.com)
Copy link

does this need to be exported outside the package?

does this need to be exported outside the package?
balandi1 commented 2019-12-09 16:03:06 +00:00 (Migrated from github.com)
Copy link

No, not needed. Changed it to getConfig .

No, not needed. Changed it to `getConfig` .
Format []string `yaml:"format"` Format []string `yaml:"format"`
} }
func GetConfig(logConfigFilename string) (*loggerConfig, error) { func getConfig(logConfigFilename string) (*loggerConfig, error) {
pradykaushik commented 2019-12-06 22:05:07 +00:00 (Migrated from github.com)
Copy link

does this need to be exported outside the package?

does this need to be exported outside the package?
balandi1 commented 2019-12-09 16:03:06 +00:00 (Migrated from github.com)
Copy link

No, not needed. Changed it to getConfig .

No, not needed. Changed it to `getConfig` .
pradykaushik commented 2019-12-06 22:05:07 +00:00 (Migrated from github.com)
Copy link

does this need to be exported outside the package?

does this need to be exported outside the package?
balandi1 commented 2019-12-09 16:03:06 +00:00 (Migrated from github.com)
Copy link

No, not needed. Changed it to getConfig .

No, not needed. Changed it to `getConfig` .
yamlFile, err := ioutil.ReadFile(logConfigFilename) yamlFile, err := ioutil.ReadFile(logConfigFilename)
if err != nil { if err != nil {

pradykaushik commented 2019-12-06 22:05:07 +00:00 (Migrated from github.com)
Copy link

does this need to be exported outside the package?

does this need to be exported outside the package?
balandi1 commented 2019-12-09 16:03:06 +00:00 (Migrated from github.com)
Copy link

No, not needed. Changed it to getConfig .

No, not needed. Changed it to `getConfig` .
pradykaushik commented 2019-12-06 22:05:07 +00:00 (Migrated from github.com)
Copy link

does this need to be exported outside the package?

does this need to be exported outside the package?
balandi1 commented 2019-12-09 16:03:06 +00:00 (Migrated from github.com)
Copy link

No, not needed. Changed it to getConfig .

No, not needed. Changed it to `getConfig` .