WIP : Elektron Logging library #16

Merged
balandi1 merged 50 commits from master into master 2019-12-10 01:15:34 +00:00
5 changed files with 8 additions and 9 deletions
Showing only changes of commit 24dbbb208f - Show all commits

View file

@ -14,10 +14,10 @@ var formatter ElektronFormatter
pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`
pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`
var ElektronLog *LoggerImpl
var logDir logDirectory
func BuildLogger(prefix string) {
pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`
func BuildLogger(prefix string, logConfigFilename string) {
pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`
// read configuration from yaml
config.GetConfig()
pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`
config.GetConfig(logConfigFilename)
pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`
// create the log directory
startTime := time.Now()

pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`
pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`

View file

@ -2,7 +2,6 @@ package elektronLogging
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
import (
log "github.com/sirupsen/logrus"
elekEnv "github.com/spdfg/elektron/environment"
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
"gopkg.in/yaml.v2"
"io/ioutil"
)
@ -48,9 +47,9 @@ type LoggerConfig struct {
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
Format []string `yaml:"format"`
}
func (c *LoggerConfig) GetConfig() *LoggerConfig {
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
func (c *LoggerConfig) GetConfig(logConfigFilename string) *LoggerConfig {
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
yamlFile, err := ioutil.ReadFile(elekEnv.LogConfigYaml)
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
yamlFile, err := ioutil.ReadFile(logConfigFilename)
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
if err != nil {
log.Printf("Error in reading yaml file #%v ", err)
}

pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done

View file

@ -26,5 +26,3 @@ var RaplPassword = "RAPL_PSSWD"
// Location of the script that sets the powercap value for a host.
var RaplThrottleScriptLocation = "RAPL_PKG_THROTTLE_SCRIPT_LOCATION"
var LogConfigYaml = "logConfig.yaml"

View file

@ -55,6 +55,7 @@ var fixFirstSchedPol = flag.String("fixFirstSchedPol", "", "Name of the scheduli
var fixSchedWindow = flag.Bool("fixSchedWindow", false, "Fix the size of the scheduling window that every deployed scheduling policy should schedule, provided switching is enabled.")
var schedWindowSize = flag.Int("schedWindowSize", 200, "Size of the scheduling window if fixSchedWindow is set.")
var schedPolSwitchCriteria = flag.String("schedPolSwitchCriteria", "taskDist", "Scheduling policy switching criteria.")
var logConfigFilename = flag.String("logConfigFilename", "logConfig.yaml", "Log Configuration file name")
// Short hand args
func init() {
@ -76,6 +77,7 @@ func init() {
flag.BoolVar(fixSchedWindow, "fixSw", false, "Fix the size of the scheduling window that every deployed scheduling policy should schedule, provided switching is enabled (shorthand).")
pradykaushik commented 2019-12-06 22:08:07 +00:00 (Migrated from github.com)

change the shorthand to logCfg

change the shorthand to `logCfg`
balandi1 commented 2019-12-09 15:47:22 +00:00 (Migrated from github.com)

Done

Done
flag.IntVar(schedWindowSize, "swSize", 200, "Size of the scheduling window if fixSchedWindow is set (shorthand).")
flag.StringVar(schedPolSwitchCriteria, "spsCriteria", "taskDist", "Scheduling policy switching criteria (shorthand).")
flag.StringVar(logConfigFilename, "lgConfigName", "logConfig.yaml", "Log Configuration file name (shorthand).")
}
func listAllSchedulingPolicies() {
@ -223,7 +225,7 @@ func main() {
if strings.Contains(*pcplogPrefix, "/") {
log.Fatal("log file prefix should not contain '/'.")
}
elekLog.BuildLogger(*pcplogPrefix)
elekLog.BuildLogger(*pcplogPrefix, *logConfigFilename)
// Starting PCP logging.
if noPowercap {