WIP : Elektron Logging library #16

Merged
balandi1 merged 50 commits from master into master 2019-12-10 01:15:34 +00:00
41 changed files with 472 additions and 475 deletions
Showing only changes of commit 4d15e59d4c - Show all commits

View file

@ -1,20 +1,20 @@
// Copyright (C) 2018 spdfg
//
//
// This file is part of Elektron.
//
//
// Elektron is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// any later version.
//
//
// Elektron is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
//
// You should have received a copy of the GNU General Public License
// along with Elektron. If not, see <http://www.gnu.org/licenses/>.
//
//
// TODO: Clean this up and use Mesos Attributes instead.
package constants

View file

@ -1,20 +1,20 @@
// Copyright (C) 2018 spdfg
//
//
// This file is part of Elektron.
//
//
// Elektron is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
//
// Elektron is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
//
// You should have received a copy of the GNU General Public License
// along with Elektron. If not, see <http://www.gnu.org/licenses/>.
//
//
package def

View file

@ -1,20 +1,20 @@
// Copyright (C) 2018 spdfg
//
//
// This file is part of Elektron.
//
//
// Elektron is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
//
// Elektron is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
//
// You should have received a copy of the GNU General Public License
// along with Elektron. If not, see <http://www.gnu.org/licenses/>.
//
//
package def

View file

@ -1,20 +1,20 @@
// Copyright (C) 2018 spdfg
//
//
// This file is part of Elektron.
//
//
// Elektron is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
//
// Elektron is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
//
// You should have received a copy of the GNU General Public License
// along with Elektron. If not, see <http://www.gnu.org/licenses/>.
//
//
package def

View file

@ -1,20 +1,20 @@
pradykaushik commented 2019-11-21 00:31:57 +00:00 (Migrated from github.com)

I would alias this to elekLog as you seem to be using that prefix when aliasing imports of sub-packages.

I would alias this to _elekLog_ as you seem to be using that prefix when aliasing imports of sub-packages.
balandi1 commented 2019-11-21 19:30:07 +00:00 (Migrated from github.com)

Okay. Done

Okay. Done
pradykaushik commented 2019-11-21 00:31:57 +00:00 (Migrated from github.com)

I would alias this to elekLog as you seem to be using that prefix when aliasing imports of sub-packages.

I would alias this to _elekLog_ as you seem to be using that prefix when aliasing imports of sub-packages.
balandi1 commented 2019-11-21 19:30:07 +00:00 (Migrated from github.com)

Okay. Done

Okay. Done
// Copyright (C) 2018 spdfg
//
pradykaushik commented 2019-11-21 00:31:57 +00:00 (Migrated from github.com)

I would alias this to elekLog as you seem to be using that prefix when aliasing imports of sub-packages.

I would alias this to _elekLog_ as you seem to be using that prefix when aliasing imports of sub-packages.
balandi1 commented 2019-11-21 19:30:07 +00:00 (Migrated from github.com)

Okay. Done

Okay. Done
//
pradykaushik commented 2019-11-21 00:31:57 +00:00 (Migrated from github.com)

I would alias this to elekLog as you seem to be using that prefix when aliasing imports of sub-packages.

I would alias this to _elekLog_ as you seem to be using that prefix when aliasing imports of sub-packages.
balandi1 commented 2019-11-21 19:30:07 +00:00 (Migrated from github.com)

Okay. Done

Okay. Done
// This file is part of Elektron.
//
pradykaushik commented 2019-11-21 00:31:57 +00:00 (Migrated from github.com)

I would alias this to elekLog as you seem to be using that prefix when aliasing imports of sub-packages.

I would alias this to _elekLog_ as you seem to be using that prefix when aliasing imports of sub-packages.
balandi1 commented 2019-11-21 19:30:07 +00:00 (Migrated from github.com)

Okay. Done

Okay. Done
//
pradykaushik commented 2019-11-21 00:31:57 +00:00 (Migrated from github.com)

I would alias this to elekLog as you seem to be using that prefix when aliasing imports of sub-packages.

I would alias this to _elekLog_ as you seem to be using that prefix when aliasing imports of sub-packages.
balandi1 commented 2019-11-21 19:30:07 +00:00 (Migrated from github.com)

Okay. Done

Okay. Done
// Elektron is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
pradykaushik commented 2019-11-21 00:31:57 +00:00 (Migrated from github.com)

I would alias this to elekLog as you seem to be using that prefix when aliasing imports of sub-packages.

I would alias this to _elekLog_ as you seem to be using that prefix when aliasing imports of sub-packages.
balandi1 commented 2019-11-21 19:30:07 +00:00 (Migrated from github.com)

Okay. Done

Okay. Done
//
pradykaushik commented 2019-11-21 00:31:57 +00:00 (Migrated from github.com)

I would alias this to elekLog as you seem to be using that prefix when aliasing imports of sub-packages.

I would alias this to _elekLog_ as you seem to be using that prefix when aliasing imports of sub-packages.
balandi1 commented 2019-11-21 19:30:07 +00:00 (Migrated from github.com)

Okay. Done

Okay. Done
// Elektron is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
pradykaushik commented 2019-11-21 00:31:57 +00:00 (Migrated from github.com)

I would alias this to elekLog as you seem to be using that prefix when aliasing imports of sub-packages.

I would alias this to _elekLog_ as you seem to be using that prefix when aliasing imports of sub-packages.
balandi1 commented 2019-11-21 19:30:07 +00:00 (Migrated from github.com)

Okay. Done

Okay. Done
//
pradykaushik commented 2019-11-21 00:31:57 +00:00 (Migrated from github.com)

I would alias this to elekLog as you seem to be using that prefix when aliasing imports of sub-packages.

I would alias this to _elekLog_ as you seem to be using that prefix when aliasing imports of sub-packages.
balandi1 commented 2019-11-21 19:30:07 +00:00 (Migrated from github.com)

Okay. Done

Okay. Done
// You should have received a copy of the GNU General Public License
// along with Elektron. If not, see <http://www.gnu.org/licenses/>.
//
pradykaushik commented 2019-11-21 00:31:57 +00:00 (Migrated from github.com)

I would alias this to elekLog as you seem to be using that prefix when aliasing imports of sub-packages.

I would alias this to _elekLog_ as you seem to be using that prefix when aliasing imports of sub-packages.
balandi1 commented 2019-11-21 19:30:07 +00:00 (Migrated from github.com)

Okay. Done

Okay. Done
//
pradykaushik commented 2019-11-21 00:31:57 +00:00 (Migrated from github.com)

I would alias this to elekLog as you seem to be using that prefix when aliasing imports of sub-packages.

I would alias this to _elekLog_ as you seem to be using that prefix when aliasing imports of sub-packages.
balandi1 commented 2019-11-21 19:30:07 +00:00 (Migrated from github.com)

Okay. Done

Okay. Done
package def
ridv commented 2019-11-19 02:54:35 +00:00 (Migrated from github.com)

Format error, fix spacing or run through goimports

Format error, fix spacing or run through [goimports](https://godoc.org/golang.org/x/tools/cmd/goimports)
ridv commented 2019-11-19 02:55:10 +00:00 (Migrated from github.com)

Let's pick a better alias, this doesn't really say much about what this package holds.

Let's pick a better alias, this doesn't really say much about what this package holds.
balandi1 commented 2019-11-20 18:44:44 +00:00 (Migrated from github.com)

Yes, I will fix all the formatting errors

Yes, I will fix all the formatting errors
balandi1 commented 2019-11-20 18:47:33 +00:00 (Migrated from github.com)

Okay. Will changing it to elekLogTypes or logTypes simply work ?

Okay. Will changing it to `elekLogTypes` or `logTypes` simply work ?
ridv commented 2019-11-24 18:43:55 +00:00 (Migrated from github.com)

logTypes would be fine

logTypes would be fine
@ -25,9 +25,9 @@ import (
pradykaushik commented 2019-11-21 00:31:57 +00:00 (Migrated from github.com)

I would alias this to elekLog as you seem to be using that prefix when aliasing imports of sub-packages.

I would alias this to _elekLog_ as you seem to be using that prefix when aliasing imports of sub-packages.
balandi1 commented 2019-11-21 19:30:07 +00:00 (Migrated from github.com)

Okay. Done

Okay. Done
pradykaushik commented 2019-11-21 00:31:57 +00:00 (Migrated from github.com)

I would alias this to elekLog as you seem to be using that prefix when aliasing imports of sub-packages.

I would alias this to _elekLog_ as you seem to be using that prefix when aliasing imports of sub-packages.
balandi1 commented 2019-11-21 19:30:07 +00:00 (Migrated from github.com)

Okay. Done

Okay. Done
"github.com/mash/gokmeans"
"github.com/montanaflynn/stats"
"github.com/spdfg/elektron/elektronLogging"
pradykaushik commented 2019-11-21 00:31:57 +00:00 (Migrated from github.com)

I would alias this to elekLog as you seem to be using that prefix when aliasing imports of sub-packages.

I would alias this to _elekLog_ as you seem to be using that prefix when aliasing imports of sub-packages.
balandi1 commented 2019-11-21 19:30:07 +00:00 (Migrated from github.com)

Okay. Done

Okay. Done
log "github.com/sirupsen/logrus"
pradykaushik commented 2019-11-21 00:31:57 +00:00 (Migrated from github.com)

I would alias this to elekLog as you seem to be using that prefix when aliasing imports of sub-packages.

I would alias this to _elekLog_ as you seem to be using that prefix when aliasing imports of sub-packages.
balandi1 commented 2019-11-21 19:30:07 +00:00 (Migrated from github.com)

Okay. Done

Okay. Done
"github.com/spdfg/elektron/elektronLogging"
pradykaushik commented 2019-11-21 00:31:57 +00:00 (Migrated from github.com)

I would alias this to elekLog as you seem to be using that prefix when aliasing imports of sub-packages.

I would alias this to _elekLog_ as you seem to be using that prefix when aliasing imports of sub-packages.
balandi1 commented 2019-11-21 19:30:07 +00:00 (Migrated from github.com)

Okay. Done

Okay. Done
elekLogT "github.com/spdfg/elektron/elektronLogging/types"
log "github.com/sirupsen/logrus"
pradykaushik commented 2019-11-21 00:31:57 +00:00 (Migrated from github.com)

I would alias this to elekLog as you seem to be using that prefix when aliasing imports of sub-packages.

I would alias this to _elekLog_ as you seem to be using that prefix when aliasing imports of sub-packages.
balandi1 commented 2019-11-21 19:30:07 +00:00 (Migrated from github.com)

Okay. Done

Okay. Done
)
// Information about a cluster of tasks.
@ -52,8 +52,8 @@ func (tc TasksToClassify) taskObservationCalculator(task Task) []float64 {
pradykaushik commented 2019-11-21 00:31:57 +00:00 (Migrated from github.com)

I would alias this to elekLog as you seem to be using that prefix when aliasing imports of sub-packages.

I would alias this to _elekLog_ as you seem to be using that prefix when aliasing imports of sub-packages.
balandi1 commented 2019-11-21 19:30:07 +00:00 (Migrated from github.com)

Okay. Done

Okay. Done
pradykaushik commented 2019-11-21 00:31:57 +00:00 (Migrated from github.com)

I would alias this to elekLog as you seem to be using that prefix when aliasing imports of sub-packages.

I would alias this to _elekLog_ as you seem to be using that prefix when aliasing imports of sub-packages.
balandi1 commented 2019-11-21 19:30:07 +00:00 (Migrated from github.com)

Okay. Done

Okay. Done
} else if task.Watts != 0.0 {
return []float64{task.Watts}
} else {
elektronLogging.ElektronLog.Log(elekLogT.ERROR, log.FatalLevel,
pradykaushik commented 2019-11-21 00:31:57 +00:00 (Migrated from github.com)

I would alias this to elekLog as you seem to be using that prefix when aliasing imports of sub-packages.

I would alias this to _elekLog_ as you seem to be using that prefix when aliasing imports of sub-packages.
balandi1 commented 2019-11-21 19:30:07 +00:00 (Migrated from github.com)

Okay. Done

Okay. Done
log.Fields {}, "Unable to classify tasks. Missing Watts or ClassToWatts attribute in workload")
pradykaushik commented 2019-11-21 00:31:57 +00:00 (Migrated from github.com)

I would alias this to elekLog as you seem to be using that prefix when aliasing imports of sub-packages.

I would alias this to _elekLog_ as you seem to be using that prefix when aliasing imports of sub-packages.
balandi1 commented 2019-11-21 19:30:07 +00:00 (Migrated from github.com)

Okay. Done

Okay. Done
elektronLogging.ElektronLog.Log(elekLogT.ERROR, log.FatalLevel,
pradykaushik commented 2019-11-21 00:31:57 +00:00 (Migrated from github.com)

I would alias this to elekLog as you seem to be using that prefix when aliasing imports of sub-packages.

I would alias this to _elekLog_ as you seem to be using that prefix when aliasing imports of sub-packages.
balandi1 commented 2019-11-21 19:30:07 +00:00 (Migrated from github.com)

Okay. Done

Okay. Done
log.Fields{}, "Unable to classify tasks. Missing Watts or ClassToWatts attribute in workload")
pradykaushik commented 2019-11-21 00:31:57 +00:00 (Migrated from github.com)

I would alias this to elekLog as you seem to be using that prefix when aliasing imports of sub-packages.

I would alias this to _elekLog_ as you seem to be using that prefix when aliasing imports of sub-packages.
balandi1 commented 2019-11-21 19:30:07 +00:00 (Migrated from github.com)

Okay. Done

Okay. Done
return []float64{0.0} // Won't reach here.
}
}
@ -108,8 +108,8 @@ func clusterSizeAvgMMMPU(tasks []Task, taskObservation func(task Task) []float64
pradykaushik commented 2019-11-21 00:31:57 +00:00 (Migrated from github.com)

I would alias this to elekLog as you seem to be using that prefix when aliasing imports of sub-packages.

I would alias this to _elekLog_ as you seem to be using that prefix when aliasing imports of sub-packages.
balandi1 commented 2019-11-21 19:30:07 +00:00 (Migrated from github.com)

Okay. Done

Okay. Done
pradykaushik commented 2019-11-21 00:31:57 +00:00 (Migrated from github.com)

I would alias this to elekLog as you seem to be using that prefix when aliasing imports of sub-packages.

I would alias this to _elekLog_ as you seem to be using that prefix when aliasing imports of sub-packages.
balandi1 commented 2019-11-21 19:30:07 +00:00 (Migrated from github.com)

Okay. Done

Okay. Done
} else {
// skip this value
// there is an error in the task config.
elektronLogging.ElektronLog.Log(elekLogT.ERROR, log.ErrorLevel,
pradykaushik commented 2019-11-21 00:31:57 +00:00 (Migrated from github.com)

I would alias this to elekLog as you seem to be using that prefix when aliasing imports of sub-packages.

I would alias this to _elekLog_ as you seem to be using that prefix when aliasing imports of sub-packages.
balandi1 commented 2019-11-21 19:30:07 +00:00 (Migrated from github.com)

Okay. Done

Okay. Done
log.Fields {}, fmt.Sprintf("%s",err))
pradykaushik commented 2019-11-21 00:31:57 +00:00 (Migrated from github.com)

I would alias this to elekLog as you seem to be using that prefix when aliasing imports of sub-packages.

I would alias this to _elekLog_ as you seem to be using that prefix when aliasing imports of sub-packages.
balandi1 commented 2019-11-21 19:30:07 +00:00 (Migrated from github.com)

Okay. Done

Okay. Done
elektronLogging.ElektronLog.Log(elekLogT.ERROR, log.ErrorLevel,
pradykaushik commented 2019-11-21 00:31:57 +00:00 (Migrated from github.com)

I would alias this to elekLog as you seem to be using that prefix when aliasing imports of sub-packages.

I would alias this to _elekLog_ as you seem to be using that prefix when aliasing imports of sub-packages.
balandi1 commented 2019-11-21 19:30:07 +00:00 (Migrated from github.com)

Okay. Done

Okay. Done
log.Fields{}, fmt.Sprintf("%s", err))
pradykaushik commented 2019-11-21 00:31:57 +00:00 (Migrated from github.com)

I would alias this to elekLog as you seem to be using that prefix when aliasing imports of sub-packages.

I would alias this to _elekLog_ as you seem to be using that prefix when aliasing imports of sub-packages.
balandi1 commented 2019-11-21 19:30:07 +00:00 (Migrated from github.com)

Okay. Done

Okay. Done
}
} else {
// There is only one observation for the task.

pradykaushik commented 2019-11-21 00:31:57 +00:00 (Migrated from github.com)

I would alias this to elekLog as you seem to be using that prefix when aliasing imports of sub-packages.

I would alias this to _elekLog_ as you seem to be using that prefix when aliasing imports of sub-packages.
balandi1 commented 2019-11-21 19:30:07 +00:00 (Migrated from github.com)

Okay. Done

Okay. Done
pradykaushik commented 2019-11-21 00:31:57 +00:00 (Migrated from github.com)

I would alias this to elekLog as you seem to be using that prefix when aliasing imports of sub-packages.

I would alias this to _elekLog_ as you seem to be using that prefix when aliasing imports of sub-packages.
balandi1 commented 2019-11-21 19:30:07 +00:00 (Migrated from github.com)

Okay. Done

Okay. Done

View file

@ -3,9 +3,9 @@ package elektronLogging
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
import (
"bytes"
"fmt"
"github.com/fatih/color"
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
log "github.com/sirupsen/logrus"
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
"strings"
"github.com/fatih/color"
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
log "github.com/sirupsen/logrus"
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
)
type ElektronFormatter struct {
@ -13,18 +13,18 @@ type ElektronFormatter struct {
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
}
func (f ElektronFormatter) getColor(entry *log.Entry) *color.Color {
switch entry.Level {
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
case log.InfoLevel:
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
return color.New(color.FgGreen, color.Bold)
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
case log.WarnLevel:
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
return color.New(color.FgYellow, color.Bold)
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
case log.ErrorLevel:
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
return color.New(color.FgRed, color.Bold)
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
case log.FatalLevel:
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
return color.New(color.FgRed, color.Bold)
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
default:
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
return color.New(color.FgWhite, color.Bold)
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
}
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
switch entry.Level {
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
case log.InfoLevel:
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
return color.New(color.FgGreen, color.Bold)
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
case log.WarnLevel:
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
return color.New(color.FgYellow, color.Bold)
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
case log.ErrorLevel:
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
return color.New(color.FgRed, color.Bold)
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
case log.FatalLevel:
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
return color.New(color.FgRed, color.Bold)
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
default:
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
return color.New(color.FgWhite, color.Bold)
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
}
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
}
func (f ElektronFormatter) Format(entry *log.Entry) ([]byte, error) {
var b *bytes.Buffer
@ -35,19 +35,18 @@ func (f ElektronFormatter) Format(entry *log.Entry) ([]byte, error) {
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
b = &bytes.Buffer{}
}
levelColor := f.getColor(entry)
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
level := levelColor.Sprintf("[%s]:",strings.ToUpper(entry.Level.String()))
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
message := fmt.Sprintf("%s %s ",level,entry.Time.Format(f.TimestampFormat))
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
if entry.Message != "" {
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
message = fmt.Sprintf("%s %s %s ",level,entry.Time.Format(f.TimestampFormat), entry.Message)
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
}
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
levelColor := f.getColor(entry)
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
level := levelColor.Sprintf("[%s]:", strings.ToUpper(entry.Level.String()))
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
message := fmt.Sprintf("%s %s ", level, entry.Time.Format(f.TimestampFormat))
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
if entry.Message != "" {
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
message = fmt.Sprintf("%s %s %s ", level, entry.Time.Format(f.TimestampFormat), entry.Message)
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
}
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
var formattedFields []string
for key, value := range entry.Data {
formattedFields = append(formattedFields,
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
strings.Join([]string{key, fmt.Sprintf("%s", value)}, "="))
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
formattedFields = append(formattedFields,
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
strings.Join([]string{key, fmt.Sprintf("%s", value)}, "="))
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
}
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
b.WriteString(message)
b.WriteString(strings.Join(formattedFields, ", "))
b.WriteByte('\n')

ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay
ridv commented 2019-11-19 02:56:40 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:57:02 +00:00 (Migrated from github.com)

Formatting

Formatting
ridv commented 2019-11-19 02:59:56 +00:00 (Migrated from github.com)

Use strings.join instead. You should create the slice and append the message if necessary.

Use [strings.join](https://golang.org/pkg/strings/#Join) instead. You should create the slice and append the message if necessary.
ridv commented 2019-11-19 03:00:54 +00:00 (Migrated from github.com)

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.

This seems really inefficient. Wouldn't value already have to be a string for this to succeed? In which case, I don't think we gain anything here by suing a sprintf.
balandi1 commented 2019-11-20 18:48:25 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-20 19:42:41 +00:00 (Migrated from github.com)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : value.(string)

value is not a string here, it is of type interface{}. But to avoid using sprintf, would it be fine to use type assertion? For eg : `value.(string) `
balandi1 commented 2019-11-21 18:07:31 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 18:07:42 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 22:13:22 +00:00 (Migrated from github.com)

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.

Line 43 and 44 can fit in one line. We currently do not have any style linting setup.
pradykaushik commented 2019-11-21 22:59:52 +00:00 (Migrated from github.com)

Peeked at how logrus serializes values and seems like fmt.Sprint is used if type assertion fails.

Peeked at how [logrus](https://github.com/sirupsen/logrus/blob/67a7fdcf741f4d5cee82cb9800994ccfd4393ad0/text_formatter.go#L315) serializes values and seems like fmt.Sprint is used if type assertion fails.
ridv commented 2019-11-24 18:46:09 +00:00 (Migrated from github.com)

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.

ahh alright, I thought it was a string coming in. Alright, if it's been sanity checked then i'm good with it.
balandi1 commented 2019-11-26 18:14:34 +00:00 (Migrated from github.com)

Okay

Okay

View file

@ -1,8 +1,8 @@
ridv commented 2019-11-19 03:01:56 +00:00 (Migrated from github.com)

Use struct literals instead of new as it's more descriptive:
&ClsfnTaskDistOverheadLogger{}

Use struct literals instead of new as it's more descriptive: `&ClsfnTaskDistOverheadLogger{}`
ridv commented 2019-11-19 03:49:35 +00:00 (Migrated from github.com)

Where is log dir coming from? Shouldn't be a global

Where is log dir coming from? Shouldn't be a global
balandi1 commented 2019-11-20 18:49:00 +00:00 (Migrated from github.com)

Okay, will do the changes

Okay, will do the changes
balandi1 commented 2019-11-20 18:52:01 +00:00 (Migrated from github.com)

It is defined in createLogDir.go. Since all these files belong to same package, I accessed it in this way.

It is defined in `createLogDir.go`. Since all these files belong to same package, I accessed it in this way.
pradykaushik commented 2019-11-21 00:50:06 +00:00 (Migrated from github.com)

I think it will be better if it is encapsulated.
Something like

type logDir struct {
    name string
    // other fields if necessary.
}
I think it will be better if it is encapsulated. Something like ```go type logDir struct { name string // other fields if necessary. } ```
pradykaushik commented 2019-11-21 00:52:08 +00:00 (Migrated from github.com)

Maybe refactor to ClsfnTaskDistrOverheadLogger so that it is clear that we are intending "Distribution" and now "Distance"?

Maybe refactor to `ClsfnTaskDistrOverheadLogger` so that it is clear that we are intending "Distribution" and now "Distance"?
pradykaushik commented 2019-11-21 00:57:11 +00:00 (Migrated from github.com)

You should use filepath.Join(...) to keep it generic.

You should use [filepath.Join(...)](https://golang.org/src/path/filepath/path.go?s=5893:5925#L199) to keep it generic.
pradykaushik commented 2019-11-21 01:06:38 +00:00 (Migrated from github.com)

You can possible rewrite this function to something like the one shown below.

func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) {
    filename := prefix + config.TaskDistConfig.FilenameExtension
    if logDir != "" {
        if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil {
            log.Fatal("Unable to create logFile: ", err)
        } else {
            cLog.LogFileName = logFile
            cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole
        }
    }
}
You can possible rewrite this function to something like the one shown below. ```go func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) { filename := prefix + config.TaskDistConfig.FilenameExtension if logDir != "" { if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil { log.Fatal("Unable to create logFile: ", err) } else { cLog.LogFileName = logFile cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole } } } ```
balandi1 commented 2019-11-21 18:48:26 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:11:44 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:27:31 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-21 22:47:52 +00:00 (Migrated from github.com)

Done

Done
ridv commented 2019-11-24 18:46:34 +00:00 (Migrated from github.com)

looks good now thanks!

looks good now thanks!
ridv commented 2019-11-19 03:01:56 +00:00 (Migrated from github.com)

Use struct literals instead of new as it's more descriptive:
&ClsfnTaskDistOverheadLogger{}

Use struct literals instead of new as it's more descriptive: `&ClsfnTaskDistOverheadLogger{}`
ridv commented 2019-11-19 03:49:35 +00:00 (Migrated from github.com)

Where is log dir coming from? Shouldn't be a global

Where is log dir coming from? Shouldn't be a global
balandi1 commented 2019-11-20 18:49:00 +00:00 (Migrated from github.com)

Okay, will do the changes

Okay, will do the changes
balandi1 commented 2019-11-20 18:52:01 +00:00 (Migrated from github.com)

It is defined in createLogDir.go. Since all these files belong to same package, I accessed it in this way.

It is defined in `createLogDir.go`. Since all these files belong to same package, I accessed it in this way.
pradykaushik commented 2019-11-21 00:50:06 +00:00 (Migrated from github.com)

I think it will be better if it is encapsulated.
Something like

type logDir struct {
    name string
    // other fields if necessary.
}
I think it will be better if it is encapsulated. Something like ```go type logDir struct { name string // other fields if necessary. } ```
pradykaushik commented 2019-11-21 00:52:08 +00:00 (Migrated from github.com)

Maybe refactor to ClsfnTaskDistrOverheadLogger so that it is clear that we are intending "Distribution" and now "Distance"?

Maybe refactor to `ClsfnTaskDistrOverheadLogger` so that it is clear that we are intending "Distribution" and now "Distance"?
pradykaushik commented 2019-11-21 00:57:11 +00:00 (Migrated from github.com)

You should use filepath.Join(...) to keep it generic.

You should use [filepath.Join(...)](https://golang.org/src/path/filepath/path.go?s=5893:5925#L199) to keep it generic.
pradykaushik commented 2019-11-21 01:06:38 +00:00 (Migrated from github.com)

You can possible rewrite this function to something like the one shown below.

func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) {
    filename := prefix + config.TaskDistConfig.FilenameExtension
    if logDir != "" {
        if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil {
            log.Fatal("Unable to create logFile: ", err)
        } else {
            cLog.LogFileName = logFile
            cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole
        }
    }
}
You can possible rewrite this function to something like the one shown below. ```go func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) { filename := prefix + config.TaskDistConfig.FilenameExtension if logDir != "" { if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil { log.Fatal("Unable to create logFile: ", err) } else { cLog.LogFileName = logFile cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole } } } ```
balandi1 commented 2019-11-21 18:48:26 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:11:44 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:27:31 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-21 22:47:52 +00:00 (Migrated from github.com)

Done

Done
ridv commented 2019-11-24 18:46:34 +00:00 (Migrated from github.com)

looks good now thanks!

looks good now thanks!
package elektronLogging
import (
"os"
ridv commented 2019-11-19 03:01:56 +00:00 (Migrated from github.com)

Use struct literals instead of new as it's more descriptive:
&ClsfnTaskDistOverheadLogger{}

Use struct literals instead of new as it's more descriptive: `&ClsfnTaskDistOverheadLogger{}`
ridv commented 2019-11-19 03:49:35 +00:00 (Migrated from github.com)

Where is log dir coming from? Shouldn't be a global

Where is log dir coming from? Shouldn't be a global
balandi1 commented 2019-11-20 18:49:00 +00:00 (Migrated from github.com)

Okay, will do the changes

Okay, will do the changes
balandi1 commented 2019-11-20 18:52:01 +00:00 (Migrated from github.com)

It is defined in createLogDir.go. Since all these files belong to same package, I accessed it in this way.

It is defined in `createLogDir.go`. Since all these files belong to same package, I accessed it in this way.
pradykaushik commented 2019-11-21 00:50:06 +00:00 (Migrated from github.com)

I think it will be better if it is encapsulated.
Something like

type logDir struct {
    name string
    // other fields if necessary.
}
I think it will be better if it is encapsulated. Something like ```go type logDir struct { name string // other fields if necessary. } ```
pradykaushik commented 2019-11-21 00:52:08 +00:00 (Migrated from github.com)

Maybe refactor to ClsfnTaskDistrOverheadLogger so that it is clear that we are intending "Distribution" and now "Distance"?

Maybe refactor to `ClsfnTaskDistrOverheadLogger` so that it is clear that we are intending "Distribution" and now "Distance"?
pradykaushik commented 2019-11-21 00:57:11 +00:00 (Migrated from github.com)

You should use filepath.Join(...) to keep it generic.

You should use [filepath.Join(...)](https://golang.org/src/path/filepath/path.go?s=5893:5925#L199) to keep it generic.
pradykaushik commented 2019-11-21 01:06:38 +00:00 (Migrated from github.com)

You can possible rewrite this function to something like the one shown below.

func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) {
    filename := prefix + config.TaskDistConfig.FilenameExtension
    if logDir != "" {
        if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil {
            log.Fatal("Unable to create logFile: ", err)
        } else {
            cLog.LogFileName = logFile
            cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole
        }
    }
}
You can possible rewrite this function to something like the one shown below. ```go func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) { filename := prefix + config.TaskDistConfig.FilenameExtension if logDir != "" { if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil { log.Fatal("Unable to create logFile: ", err) } else { cLog.LogFileName = logFile cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole } } } ```
balandi1 commented 2019-11-21 18:48:26 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:11:44 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:27:31 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-21 22:47:52 +00:00 (Migrated from github.com)

Done

Done
ridv commented 2019-11-24 18:46:34 +00:00 (Migrated from github.com)

looks good now thanks!

looks good now thanks!
log "github.com/sirupsen/logrus"
"os"
ridv commented 2019-11-19 03:01:56 +00:00 (Migrated from github.com)

Use struct literals instead of new as it's more descriptive:
&ClsfnTaskDistOverheadLogger{}

Use struct literals instead of new as it's more descriptive: `&ClsfnTaskDistOverheadLogger{}`
ridv commented 2019-11-19 03:49:35 +00:00 (Migrated from github.com)

Where is log dir coming from? Shouldn't be a global

Where is log dir coming from? Shouldn't be a global
balandi1 commented 2019-11-20 18:49:00 +00:00 (Migrated from github.com)

Okay, will do the changes

Okay, will do the changes
balandi1 commented 2019-11-20 18:52:01 +00:00 (Migrated from github.com)

It is defined in createLogDir.go. Since all these files belong to same package, I accessed it in this way.

It is defined in `createLogDir.go`. Since all these files belong to same package, I accessed it in this way.
pradykaushik commented 2019-11-21 00:50:06 +00:00 (Migrated from github.com)

I think it will be better if it is encapsulated.
Something like

type logDir struct {
    name string
    // other fields if necessary.
}
I think it will be better if it is encapsulated. Something like ```go type logDir struct { name string // other fields if necessary. } ```
pradykaushik commented 2019-11-21 00:52:08 +00:00 (Migrated from github.com)

Maybe refactor to ClsfnTaskDistrOverheadLogger so that it is clear that we are intending "Distribution" and now "Distance"?

Maybe refactor to `ClsfnTaskDistrOverheadLogger` so that it is clear that we are intending "Distribution" and now "Distance"?
pradykaushik commented 2019-11-21 00:57:11 +00:00 (Migrated from github.com)

You should use filepath.Join(...) to keep it generic.

You should use [filepath.Join(...)](https://golang.org/src/path/filepath/path.go?s=5893:5925#L199) to keep it generic.
pradykaushik commented 2019-11-21 01:06:38 +00:00 (Migrated from github.com)

You can possible rewrite this function to something like the one shown below.

func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) {
    filename := prefix + config.TaskDistConfig.FilenameExtension
    if logDir != "" {
        if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil {
            log.Fatal("Unable to create logFile: ", err)
        } else {
            cLog.LogFileName = logFile
            cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole
        }
    }
}
You can possible rewrite this function to something like the one shown below. ```go func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) { filename := prefix + config.TaskDistConfig.FilenameExtension if logDir != "" { if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil { log.Fatal("Unable to create logFile: ", err) } else { cLog.LogFileName = logFile cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole } } } ```
balandi1 commented 2019-11-21 18:48:26 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:11:44 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:27:31 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-21 22:47:52 +00:00 (Migrated from github.com)

Done

Done
ridv commented 2019-11-24 18:46:34 +00:00 (Migrated from github.com)

looks good now thanks!

looks good now thanks!
)
type ClsfnTaskDistOverheadLogger struct {
@ -16,16 +16,16 @@ func NewClsfnTaskDistOverheadLogger(logType int, prefix string) *ClsfnTaskDistOv
ridv commented 2019-11-19 03:01:56 +00:00 (Migrated from github.com)

Use struct literals instead of new as it's more descriptive:
&ClsfnTaskDistOverheadLogger{}

Use struct literals instead of new as it's more descriptive: `&ClsfnTaskDistOverheadLogger{}`
ridv commented 2019-11-19 03:49:35 +00:00 (Migrated from github.com)

Where is log dir coming from? Shouldn't be a global

Where is log dir coming from? Shouldn't be a global
balandi1 commented 2019-11-20 18:49:00 +00:00 (Migrated from github.com)

Okay, will do the changes

Okay, will do the changes
balandi1 commented 2019-11-20 18:52:01 +00:00 (Migrated from github.com)

It is defined in createLogDir.go. Since all these files belong to same package, I accessed it in this way.

It is defined in `createLogDir.go`. Since all these files belong to same package, I accessed it in this way.
pradykaushik commented 2019-11-21 00:50:06 +00:00 (Migrated from github.com)

I think it will be better if it is encapsulated.
Something like

type logDir struct {
    name string
    // other fields if necessary.
}
I think it will be better if it is encapsulated. Something like ```go type logDir struct { name string // other fields if necessary. } ```
pradykaushik commented 2019-11-21 00:52:08 +00:00 (Migrated from github.com)

Maybe refactor to ClsfnTaskDistrOverheadLogger so that it is clear that we are intending "Distribution" and now "Distance"?

Maybe refactor to `ClsfnTaskDistrOverheadLogger` so that it is clear that we are intending "Distribution" and now "Distance"?
pradykaushik commented 2019-11-21 00:57:11 +00:00 (Migrated from github.com)

You should use filepath.Join(...) to keep it generic.

You should use [filepath.Join(...)](https://golang.org/src/path/filepath/path.go?s=5893:5925#L199) to keep it generic.
pradykaushik commented 2019-11-21 01:06:38 +00:00 (Migrated from github.com)

You can possible rewrite this function to something like the one shown below.

func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) {
    filename := prefix + config.TaskDistConfig.FilenameExtension
    if logDir != "" {
        if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil {
            log.Fatal("Unable to create logFile: ", err)
        } else {
            cLog.LogFileName = logFile
            cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole
        }
    }
}
You can possible rewrite this function to something like the one shown below. ```go func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) { filename := prefix + config.TaskDistConfig.FilenameExtension if logDir != "" { if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil { log.Fatal("Unable to create logFile: ", err) } else { cLog.LogFileName = logFile cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole } } } ```
balandi1 commented 2019-11-21 18:48:26 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:11:44 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:27:31 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-21 22:47:52 +00:00 (Migrated from github.com)

Done

Done
ridv commented 2019-11-24 18:46:34 +00:00 (Migrated from github.com)

looks good now thanks!

looks good now thanks!
ridv commented 2019-11-19 03:01:56 +00:00 (Migrated from github.com)

Use struct literals instead of new as it's more descriptive:
&ClsfnTaskDistOverheadLogger{}

Use struct literals instead of new as it's more descriptive: `&ClsfnTaskDistOverheadLogger{}`
ridv commented 2019-11-19 03:49:35 +00:00 (Migrated from github.com)

Where is log dir coming from? Shouldn't be a global

Where is log dir coming from? Shouldn't be a global
balandi1 commented 2019-11-20 18:49:00 +00:00 (Migrated from github.com)

Okay, will do the changes

Okay, will do the changes
balandi1 commented 2019-11-20 18:52:01 +00:00 (Migrated from github.com)

It is defined in createLogDir.go. Since all these files belong to same package, I accessed it in this way.

It is defined in `createLogDir.go`. Since all these files belong to same package, I accessed it in this way.
pradykaushik commented 2019-11-21 00:50:06 +00:00 (Migrated from github.com)

I think it will be better if it is encapsulated.
Something like

type logDir struct {
    name string
    // other fields if necessary.
}
I think it will be better if it is encapsulated. Something like ```go type logDir struct { name string // other fields if necessary. } ```
pradykaushik commented 2019-11-21 00:52:08 +00:00 (Migrated from github.com)

Maybe refactor to ClsfnTaskDistrOverheadLogger so that it is clear that we are intending "Distribution" and now "Distance"?

Maybe refactor to `ClsfnTaskDistrOverheadLogger` so that it is clear that we are intending "Distribution" and now "Distance"?
pradykaushik commented 2019-11-21 00:57:11 +00:00 (Migrated from github.com)

You should use filepath.Join(...) to keep it generic.

You should use [filepath.Join(...)](https://golang.org/src/path/filepath/path.go?s=5893:5925#L199) to keep it generic.
pradykaushik commented 2019-11-21 01:06:38 +00:00 (Migrated from github.com)

You can possible rewrite this function to something like the one shown below.

func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) {
    filename := prefix + config.TaskDistConfig.FilenameExtension
    if logDir != "" {
        if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil {
            log.Fatal("Unable to create logFile: ", err)
        } else {
            cLog.LogFileName = logFile
            cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole
        }
    }
}
You can possible rewrite this function to something like the one shown below. ```go func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) { filename := prefix + config.TaskDistConfig.FilenameExtension if logDir != "" { if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil { log.Fatal("Unable to create logFile: ", err) } else { cLog.LogFileName = logFile cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole } } } ```
balandi1 commented 2019-11-21 18:48:26 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:11:44 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:27:31 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-21 22:47:52 +00:00 (Migrated from github.com)

Done

Done
ridv commented 2019-11-24 18:46:34 +00:00 (Migrated from github.com)

looks good now thanks!

looks good now thanks!
return cLog
}
func (cLog *ClsfnTaskDistOverheadLogger) Log(logType int, level log.Level, logData log.Fields,message string) {
ridv commented 2019-11-19 03:01:56 +00:00 (Migrated from github.com)

Use struct literals instead of new as it's more descriptive:
&ClsfnTaskDistOverheadLogger{}

Use struct literals instead of new as it's more descriptive: `&ClsfnTaskDistOverheadLogger{}`
ridv commented 2019-11-19 03:49:35 +00:00 (Migrated from github.com)

Where is log dir coming from? Shouldn't be a global

Where is log dir coming from? Shouldn't be a global
balandi1 commented 2019-11-20 18:49:00 +00:00 (Migrated from github.com)

Okay, will do the changes

Okay, will do the changes
balandi1 commented 2019-11-20 18:52:01 +00:00 (Migrated from github.com)

It is defined in createLogDir.go. Since all these files belong to same package, I accessed it in this way.

It is defined in `createLogDir.go`. Since all these files belong to same package, I accessed it in this way.
pradykaushik commented 2019-11-21 00:50:06 +00:00 (Migrated from github.com)

I think it will be better if it is encapsulated.
Something like

type logDir struct {
    name string
    // other fields if necessary.
}
I think it will be better if it is encapsulated. Something like ```go type logDir struct { name string // other fields if necessary. } ```
pradykaushik commented 2019-11-21 00:52:08 +00:00 (Migrated from github.com)

Maybe refactor to ClsfnTaskDistrOverheadLogger so that it is clear that we are intending "Distribution" and now "Distance"?

Maybe refactor to `ClsfnTaskDistrOverheadLogger` so that it is clear that we are intending "Distribution" and now "Distance"?
pradykaushik commented 2019-11-21 00:57:11 +00:00 (Migrated from github.com)

You should use filepath.Join(...) to keep it generic.

You should use [filepath.Join(...)](https://golang.org/src/path/filepath/path.go?s=5893:5925#L199) to keep it generic.
pradykaushik commented 2019-11-21 01:06:38 +00:00 (Migrated from github.com)

You can possible rewrite this function to something like the one shown below.

func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) {
    filename := prefix + config.TaskDistConfig.FilenameExtension
    if logDir != "" {
        if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil {
            log.Fatal("Unable to create logFile: ", err)
        } else {
            cLog.LogFileName = logFile
            cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole
        }
    }
}
You can possible rewrite this function to something like the one shown below. ```go func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) { filename := prefix + config.TaskDistConfig.FilenameExtension if logDir != "" { if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil { log.Fatal("Unable to create logFile: ", err) } else { cLog.LogFileName = logFile cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole } } } ```
balandi1 commented 2019-11-21 18:48:26 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:11:44 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:27:31 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-21 22:47:52 +00:00 (Migrated from github.com)

Done

Done
ridv commented 2019-11-24 18:46:34 +00:00 (Migrated from github.com)

looks good now thanks!

looks good now thanks!
func (cLog *ClsfnTaskDistOverheadLogger) Log(logType int, level log.Level, logData log.Fields, message string) {
ridv commented 2019-11-19 03:01:56 +00:00 (Migrated from github.com)

Use struct literals instead of new as it's more descriptive:
&ClsfnTaskDistOverheadLogger{}

Use struct literals instead of new as it's more descriptive: `&ClsfnTaskDistOverheadLogger{}`
ridv commented 2019-11-19 03:49:35 +00:00 (Migrated from github.com)

Where is log dir coming from? Shouldn't be a global

Where is log dir coming from? Shouldn't be a global
balandi1 commented 2019-11-20 18:49:00 +00:00 (Migrated from github.com)

Okay, will do the changes

Okay, will do the changes
balandi1 commented 2019-11-20 18:52:01 +00:00 (Migrated from github.com)

It is defined in createLogDir.go. Since all these files belong to same package, I accessed it in this way.

It is defined in `createLogDir.go`. Since all these files belong to same package, I accessed it in this way.
pradykaushik commented 2019-11-21 00:50:06 +00:00 (Migrated from github.com)

I think it will be better if it is encapsulated.
Something like

type logDir struct {
    name string
    // other fields if necessary.
}
I think it will be better if it is encapsulated. Something like ```go type logDir struct { name string // other fields if necessary. } ```
pradykaushik commented 2019-11-21 00:52:08 +00:00 (Migrated from github.com)

Maybe refactor to ClsfnTaskDistrOverheadLogger so that it is clear that we are intending "Distribution" and now "Distance"?

Maybe refactor to `ClsfnTaskDistrOverheadLogger` so that it is clear that we are intending "Distribution" and now "Distance"?
pradykaushik commented 2019-11-21 00:57:11 +00:00 (Migrated from github.com)

You should use filepath.Join(...) to keep it generic.

You should use [filepath.Join(...)](https://golang.org/src/path/filepath/path.go?s=5893:5925#L199) to keep it generic.
pradykaushik commented 2019-11-21 01:06:38 +00:00 (Migrated from github.com)

You can possible rewrite this function to something like the one shown below.

func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) {
    filename := prefix + config.TaskDistConfig.FilenameExtension
    if logDir != "" {
        if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil {
            log.Fatal("Unable to create logFile: ", err)
        } else {
            cLog.LogFileName = logFile
            cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole
        }
    }
}
You can possible rewrite this function to something like the one shown below. ```go func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) { filename := prefix + config.TaskDistConfig.FilenameExtension if logDir != "" { if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil { log.Fatal("Unable to create logFile: ", err) } else { cLog.LogFileName = logFile cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole } } } ```
balandi1 commented 2019-11-21 18:48:26 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:11:44 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:27:31 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-21 22:47:52 +00:00 (Migrated from github.com)

Done

Done
ridv commented 2019-11-24 18:46:34 +00:00 (Migrated from github.com)

looks good now thanks!

looks good now thanks!
if cLog.Type == logType {
logger.SetLevel(level)
ridv commented 2019-11-19 03:01:56 +00:00 (Migrated from github.com)

Use struct literals instead of new as it's more descriptive:
&ClsfnTaskDistOverheadLogger{}

Use struct literals instead of new as it's more descriptive: `&ClsfnTaskDistOverheadLogger{}`
ridv commented 2019-11-19 03:49:35 +00:00 (Migrated from github.com)

Where is log dir coming from? Shouldn't be a global

Where is log dir coming from? Shouldn't be a global
balandi1 commented 2019-11-20 18:49:00 +00:00 (Migrated from github.com)

Okay, will do the changes

Okay, will do the changes
balandi1 commented 2019-11-20 18:52:01 +00:00 (Migrated from github.com)

It is defined in createLogDir.go. Since all these files belong to same package, I accessed it in this way.

It is defined in `createLogDir.go`. Since all these files belong to same package, I accessed it in this way.
pradykaushik commented 2019-11-21 00:50:06 +00:00 (Migrated from github.com)

I think it will be better if it is encapsulated.
Something like

type logDir struct {
    name string
    // other fields if necessary.
}
I think it will be better if it is encapsulated. Something like ```go type logDir struct { name string // other fields if necessary. } ```
pradykaushik commented 2019-11-21 00:52:08 +00:00 (Migrated from github.com)

Maybe refactor to ClsfnTaskDistrOverheadLogger so that it is clear that we are intending "Distribution" and now "Distance"?

Maybe refactor to `ClsfnTaskDistrOverheadLogger` so that it is clear that we are intending "Distribution" and now "Distance"?
pradykaushik commented 2019-11-21 00:57:11 +00:00 (Migrated from github.com)

You should use filepath.Join(...) to keep it generic.

You should use [filepath.Join(...)](https://golang.org/src/path/filepath/path.go?s=5893:5925#L199) to keep it generic.
pradykaushik commented 2019-11-21 01:06:38 +00:00 (Migrated from github.com)

You can possible rewrite this function to something like the one shown below.

func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) {
    filename := prefix + config.TaskDistConfig.FilenameExtension
    if logDir != "" {
        if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil {
            log.Fatal("Unable to create logFile: ", err)
        } else {
            cLog.LogFileName = logFile
            cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole
        }
    }
}
You can possible rewrite this function to something like the one shown below. ```go func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) { filename := prefix + config.TaskDistConfig.FilenameExtension if logDir != "" { if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil { log.Fatal("Unable to create logFile: ", err) } else { cLog.LogFileName = logFile cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole } } } ```
balandi1 commented 2019-11-21 18:48:26 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:11:44 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:27:31 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-21 22:47:52 +00:00 (Migrated from github.com)

Done

Done
ridv commented 2019-11-24 18:46:34 +00:00 (Migrated from github.com)

looks good now thanks!

looks good now thanks!
if cLog.AllowOnConsole {
ridv commented 2019-11-19 03:01:56 +00:00 (Migrated from github.com)

Use struct literals instead of new as it's more descriptive:
&ClsfnTaskDistOverheadLogger{}

Use struct literals instead of new as it's more descriptive: `&ClsfnTaskDistOverheadLogger{}`
ridv commented 2019-11-19 03:49:35 +00:00 (Migrated from github.com)

Where is log dir coming from? Shouldn't be a global

Where is log dir coming from? Shouldn't be a global
balandi1 commented 2019-11-20 18:49:00 +00:00 (Migrated from github.com)

Okay, will do the changes

Okay, will do the changes
balandi1 commented 2019-11-20 18:52:01 +00:00 (Migrated from github.com)

It is defined in createLogDir.go. Since all these files belong to same package, I accessed it in this way.

It is defined in `createLogDir.go`. Since all these files belong to same package, I accessed it in this way.
pradykaushik commented 2019-11-21 00:50:06 +00:00 (Migrated from github.com)

I think it will be better if it is encapsulated.
Something like

type logDir struct {
    name string
    // other fields if necessary.
}
I think it will be better if it is encapsulated. Something like ```go type logDir struct { name string // other fields if necessary. } ```
pradykaushik commented 2019-11-21 00:52:08 +00:00 (Migrated from github.com)

Maybe refactor to ClsfnTaskDistrOverheadLogger so that it is clear that we are intending "Distribution" and now "Distance"?

Maybe refactor to `ClsfnTaskDistrOverheadLogger` so that it is clear that we are intending "Distribution" and now "Distance"?
pradykaushik commented 2019-11-21 00:57:11 +00:00 (Migrated from github.com)

You should use filepath.Join(...) to keep it generic.

You should use [filepath.Join(...)](https://golang.org/src/path/filepath/path.go?s=5893:5925#L199) to keep it generic.
pradykaushik commented 2019-11-21 01:06:38 +00:00 (Migrated from github.com)

You can possible rewrite this function to something like the one shown below.

func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) {
    filename := prefix + config.TaskDistConfig.FilenameExtension
    if logDir != "" {
        if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil {
            log.Fatal("Unable to create logFile: ", err)
        } else {
            cLog.LogFileName = logFile
            cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole
        }
    }
}
You can possible rewrite this function to something like the one shown below. ```go func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) { filename := prefix + config.TaskDistConfig.FilenameExtension if logDir != "" { if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil { log.Fatal("Unable to create logFile: ", err) } else { cLog.LogFileName = logFile cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole } } } ```
balandi1 commented 2019-11-21 18:48:26 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:11:44 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:27:31 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-21 22:47:52 +00:00 (Migrated from github.com)

Done

Done
ridv commented 2019-11-24 18:46:34 +00:00 (Migrated from github.com)

looks good now thanks!

looks good now thanks!
logger.SetOutput(os.Stdout)
ridv commented 2019-11-19 03:01:56 +00:00 (Migrated from github.com)

Use struct literals instead of new as it's more descriptive:
&ClsfnTaskDistOverheadLogger{}

Use struct literals instead of new as it's more descriptive: `&ClsfnTaskDistOverheadLogger{}`
ridv commented 2019-11-19 03:49:35 +00:00 (Migrated from github.com)

Where is log dir coming from? Shouldn't be a global

Where is log dir coming from? Shouldn't be a global
balandi1 commented 2019-11-20 18:49:00 +00:00 (Migrated from github.com)

Okay, will do the changes

Okay, will do the changes
balandi1 commented 2019-11-20 18:52:01 +00:00 (Migrated from github.com)

It is defined in createLogDir.go. Since all these files belong to same package, I accessed it in this way.

It is defined in `createLogDir.go`. Since all these files belong to same package, I accessed it in this way.
pradykaushik commented 2019-11-21 00:50:06 +00:00 (Migrated from github.com)

I think it will be better if it is encapsulated.
Something like

type logDir struct {
    name string
    // other fields if necessary.
}
I think it will be better if it is encapsulated. Something like ```go type logDir struct { name string // other fields if necessary. } ```
pradykaushik commented 2019-11-21 00:52:08 +00:00 (Migrated from github.com)

Maybe refactor to ClsfnTaskDistrOverheadLogger so that it is clear that we are intending "Distribution" and now "Distance"?

Maybe refactor to `ClsfnTaskDistrOverheadLogger` so that it is clear that we are intending "Distribution" and now "Distance"?
pradykaushik commented 2019-11-21 00:57:11 +00:00 (Migrated from github.com)

You should use filepath.Join(...) to keep it generic.

You should use [filepath.Join(...)](https://golang.org/src/path/filepath/path.go?s=5893:5925#L199) to keep it generic.
pradykaushik commented 2019-11-21 01:06:38 +00:00 (Migrated from github.com)

You can possible rewrite this function to something like the one shown below.

func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) {
    filename := prefix + config.TaskDistConfig.FilenameExtension
    if logDir != "" {
        if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil {
            log.Fatal("Unable to create logFile: ", err)
        } else {
            cLog.LogFileName = logFile
            cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole
        }
    }
}
You can possible rewrite this function to something like the one shown below. ```go func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) { filename := prefix + config.TaskDistConfig.FilenameExtension if logDir != "" { if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil { log.Fatal("Unable to create logFile: ", err) } else { cLog.LogFileName = logFile cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole } } } ```
balandi1 commented 2019-11-21 18:48:26 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:11:44 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:27:31 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-21 22:47:52 +00:00 (Migrated from github.com)

Done

Done
ridv commented 2019-11-24 18:46:34 +00:00 (Migrated from github.com)

looks good now thanks!

looks good now thanks!
logger.WithFields(logData).Println(message)
ridv commented 2019-11-19 03:01:56 +00:00 (Migrated from github.com)

Use struct literals instead of new as it's more descriptive:
&ClsfnTaskDistOverheadLogger{}

Use struct literals instead of new as it's more descriptive: `&ClsfnTaskDistOverheadLogger{}`
ridv commented 2019-11-19 03:49:35 +00:00 (Migrated from github.com)

Where is log dir coming from? Shouldn't be a global

Where is log dir coming from? Shouldn't be a global
balandi1 commented 2019-11-20 18:49:00 +00:00 (Migrated from github.com)

Okay, will do the changes

Okay, will do the changes
balandi1 commented 2019-11-20 18:52:01 +00:00 (Migrated from github.com)

It is defined in createLogDir.go. Since all these files belong to same package, I accessed it in this way.

It is defined in `createLogDir.go`. Since all these files belong to same package, I accessed it in this way.
pradykaushik commented 2019-11-21 00:50:06 +00:00 (Migrated from github.com)

I think it will be better if it is encapsulated.
Something like

type logDir struct {
    name string
    // other fields if necessary.
}
I think it will be better if it is encapsulated. Something like ```go type logDir struct { name string // other fields if necessary. } ```
pradykaushik commented 2019-11-21 00:52:08 +00:00 (Migrated from github.com)

Maybe refactor to ClsfnTaskDistrOverheadLogger so that it is clear that we are intending "Distribution" and now "Distance"?

Maybe refactor to `ClsfnTaskDistrOverheadLogger` so that it is clear that we are intending "Distribution" and now "Distance"?
pradykaushik commented 2019-11-21 00:57:11 +00:00 (Migrated from github.com)

You should use filepath.Join(...) to keep it generic.

You should use [filepath.Join(...)](https://golang.org/src/path/filepath/path.go?s=5893:5925#L199) to keep it generic.
pradykaushik commented 2019-11-21 01:06:38 +00:00 (Migrated from github.com)

You can possible rewrite this function to something like the one shown below.

func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) {
    filename := prefix + config.TaskDistConfig.FilenameExtension
    if logDir != "" {
        if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil {
            log.Fatal("Unable to create logFile: ", err)
        } else {
            cLog.LogFileName = logFile
            cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole
        }
    }
}
You can possible rewrite this function to something like the one shown below. ```go func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) { filename := prefix + config.TaskDistConfig.FilenameExtension if logDir != "" { if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil { log.Fatal("Unable to create logFile: ", err) } else { cLog.LogFileName = logFile cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole } } } ```
balandi1 commented 2019-11-21 18:48:26 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:11:44 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:27:31 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-21 22:47:52 +00:00 (Migrated from github.com)

Done

Done
ridv commented 2019-11-24 18:46:34 +00:00 (Migrated from github.com)

looks good now thanks!

looks good now thanks!
}
ridv commented 2019-11-19 03:01:56 +00:00 (Migrated from github.com)

Use struct literals instead of new as it's more descriptive:
&ClsfnTaskDistOverheadLogger{}

Use struct literals instead of new as it's more descriptive: `&ClsfnTaskDistOverheadLogger{}`
ridv commented 2019-11-19 03:49:35 +00:00 (Migrated from github.com)

Where is log dir coming from? Shouldn't be a global

Where is log dir coming from? Shouldn't be a global
balandi1 commented 2019-11-20 18:49:00 +00:00 (Migrated from github.com)

Okay, will do the changes

Okay, will do the changes
balandi1 commented 2019-11-20 18:52:01 +00:00 (Migrated from github.com)

It is defined in createLogDir.go. Since all these files belong to same package, I accessed it in this way.

It is defined in `createLogDir.go`. Since all these files belong to same package, I accessed it in this way.
pradykaushik commented 2019-11-21 00:50:06 +00:00 (Migrated from github.com)

I think it will be better if it is encapsulated.
Something like

type logDir struct {
    name string
    // other fields if necessary.
}
I think it will be better if it is encapsulated. Something like ```go type logDir struct { name string // other fields if necessary. } ```
pradykaushik commented 2019-11-21 00:52:08 +00:00 (Migrated from github.com)

Maybe refactor to ClsfnTaskDistrOverheadLogger so that it is clear that we are intending "Distribution" and now "Distance"?

Maybe refactor to `ClsfnTaskDistrOverheadLogger` so that it is clear that we are intending "Distribution" and now "Distance"?
pradykaushik commented 2019-11-21 00:57:11 +00:00 (Migrated from github.com)

You should use filepath.Join(...) to keep it generic.

You should use [filepath.Join(...)](https://golang.org/src/path/filepath/path.go?s=5893:5925#L199) to keep it generic.
pradykaushik commented 2019-11-21 01:06:38 +00:00 (Migrated from github.com)

You can possible rewrite this function to something like the one shown below.

func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) {
    filename := prefix + config.TaskDistConfig.FilenameExtension
    if logDir != "" {
        if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil {
            log.Fatal("Unable to create logFile: ", err)
        } else {
            cLog.LogFileName = logFile
            cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole
        }
    }
}
You can possible rewrite this function to something like the one shown below. ```go func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) { filename := prefix + config.TaskDistConfig.FilenameExtension if logDir != "" { if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil { log.Fatal("Unable to create logFile: ", err) } else { cLog.LogFileName = logFile cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole } } } ```
balandi1 commented 2019-11-21 18:48:26 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:11:44 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:27:31 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-21 22:47:52 +00:00 (Migrated from github.com)

Done

Done
ridv commented 2019-11-24 18:46:34 +00:00 (Migrated from github.com)

looks good now thanks!

looks good now thanks!
ridv commented 2019-11-19 03:01:56 +00:00 (Migrated from github.com)

Use struct literals instead of new as it's more descriptive:
&ClsfnTaskDistOverheadLogger{}

Use struct literals instead of new as it's more descriptive: `&ClsfnTaskDistOverheadLogger{}`
ridv commented 2019-11-19 03:49:35 +00:00 (Migrated from github.com)

Where is log dir coming from? Shouldn't be a global

Where is log dir coming from? Shouldn't be a global
balandi1 commented 2019-11-20 18:49:00 +00:00 (Migrated from github.com)

Okay, will do the changes

Okay, will do the changes
balandi1 commented 2019-11-20 18:52:01 +00:00 (Migrated from github.com)

It is defined in createLogDir.go. Since all these files belong to same package, I accessed it in this way.

It is defined in `createLogDir.go`. Since all these files belong to same package, I accessed it in this way.
pradykaushik commented 2019-11-21 00:50:06 +00:00 (Migrated from github.com)

I think it will be better if it is encapsulated.
Something like

type logDir struct {
    name string
    // other fields if necessary.
}
I think it will be better if it is encapsulated. Something like ```go type logDir struct { name string // other fields if necessary. } ```
pradykaushik commented 2019-11-21 00:52:08 +00:00 (Migrated from github.com)

Maybe refactor to ClsfnTaskDistrOverheadLogger so that it is clear that we are intending "Distribution" and now "Distance"?

Maybe refactor to `ClsfnTaskDistrOverheadLogger` so that it is clear that we are intending "Distribution" and now "Distance"?
pradykaushik commented 2019-11-21 00:57:11 +00:00 (Migrated from github.com)

You should use filepath.Join(...) to keep it generic.

You should use [filepath.Join(...)](https://golang.org/src/path/filepath/path.go?s=5893:5925#L199) to keep it generic.
pradykaushik commented 2019-11-21 01:06:38 +00:00 (Migrated from github.com)

You can possible rewrite this function to something like the one shown below.

func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) {
    filename := prefix + config.TaskDistConfig.FilenameExtension
    if logDir != "" {
        if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil {
            log.Fatal("Unable to create logFile: ", err)
        } else {
            cLog.LogFileName = logFile
            cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole
        }
    }
}
You can possible rewrite this function to something like the one shown below. ```go func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) { filename := prefix + config.TaskDistConfig.FilenameExtension if logDir != "" { if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil { log.Fatal("Unable to create logFile: ", err) } else { cLog.LogFileName = logFile cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole } } } ```
balandi1 commented 2019-11-21 18:48:26 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:11:44 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:27:31 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-21 22:47:52 +00:00 (Migrated from github.com)

Done

Done
ridv commented 2019-11-24 18:46:34 +00:00 (Migrated from github.com)

looks good now thanks!

looks good now thanks!
ridv commented 2019-11-19 03:01:56 +00:00 (Migrated from github.com)

Use struct literals instead of new as it's more descriptive:
&ClsfnTaskDistOverheadLogger{}

Use struct literals instead of new as it's more descriptive: `&ClsfnTaskDistOverheadLogger{}`
ridv commented 2019-11-19 03:49:35 +00:00 (Migrated from github.com)

Where is log dir coming from? Shouldn't be a global

Where is log dir coming from? Shouldn't be a global
balandi1 commented 2019-11-20 18:49:00 +00:00 (Migrated from github.com)

Okay, will do the changes

Okay, will do the changes
balandi1 commented 2019-11-20 18:52:01 +00:00 (Migrated from github.com)

It is defined in createLogDir.go. Since all these files belong to same package, I accessed it in this way.

It is defined in `createLogDir.go`. Since all these files belong to same package, I accessed it in this way.
pradykaushik commented 2019-11-21 00:50:06 +00:00 (Migrated from github.com)

I think it will be better if it is encapsulated.
Something like

type logDir struct {
    name string
    // other fields if necessary.
}
I think it will be better if it is encapsulated. Something like ```go type logDir struct { name string // other fields if necessary. } ```
pradykaushik commented 2019-11-21 00:52:08 +00:00 (Migrated from github.com)

Maybe refactor to ClsfnTaskDistrOverheadLogger so that it is clear that we are intending "Distribution" and now "Distance"?

Maybe refactor to `ClsfnTaskDistrOverheadLogger` so that it is clear that we are intending "Distribution" and now "Distance"?
pradykaushik commented 2019-11-21 00:57:11 +00:00 (Migrated from github.com)

You should use filepath.Join(...) to keep it generic.

You should use [filepath.Join(...)](https://golang.org/src/path/filepath/path.go?s=5893:5925#L199) to keep it generic.
pradykaushik commented 2019-11-21 01:06:38 +00:00 (Migrated from github.com)

You can possible rewrite this function to something like the one shown below.

func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) {
    filename := prefix + config.TaskDistConfig.FilenameExtension
    if logDir != "" {
        if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil {
            log.Fatal("Unable to create logFile: ", err)
        } else {
            cLog.LogFileName = logFile
            cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole
        }
    }
}
You can possible rewrite this function to something like the one shown below. ```go func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) { filename := prefix + config.TaskDistConfig.FilenameExtension if logDir != "" { if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil { log.Fatal("Unable to create logFile: ", err) } else { cLog.LogFileName = logFile cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole } } } ```
balandi1 commented 2019-11-21 18:48:26 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:11:44 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:27:31 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-21 22:47:52 +00:00 (Migrated from github.com)

Done

Done
ridv commented 2019-11-24 18:46:34 +00:00 (Migrated from github.com)

looks good now thanks!

looks good now thanks!
if cLog.AllowOnConsole {
ridv commented 2019-11-19 03:01:56 +00:00 (Migrated from github.com)

Use struct literals instead of new as it's more descriptive:
&ClsfnTaskDistOverheadLogger{}

Use struct literals instead of new as it's more descriptive: `&ClsfnTaskDistOverheadLogger{}`
ridv commented 2019-11-19 03:49:35 +00:00 (Migrated from github.com)

Where is log dir coming from? Shouldn't be a global

Where is log dir coming from? Shouldn't be a global
balandi1 commented 2019-11-20 18:49:00 +00:00 (Migrated from github.com)

Okay, will do the changes

Okay, will do the changes
balandi1 commented 2019-11-20 18:52:01 +00:00 (Migrated from github.com)

It is defined in createLogDir.go. Since all these files belong to same package, I accessed it in this way.

It is defined in `createLogDir.go`. Since all these files belong to same package, I accessed it in this way.
pradykaushik commented 2019-11-21 00:50:06 +00:00 (Migrated from github.com)

I think it will be better if it is encapsulated.
Something like

type logDir struct {
    name string
    // other fields if necessary.
}
I think it will be better if it is encapsulated. Something like ```go type logDir struct { name string // other fields if necessary. } ```
pradykaushik commented 2019-11-21 00:52:08 +00:00 (Migrated from github.com)

Maybe refactor to ClsfnTaskDistrOverheadLogger so that it is clear that we are intending "Distribution" and now "Distance"?

Maybe refactor to `ClsfnTaskDistrOverheadLogger` so that it is clear that we are intending "Distribution" and now "Distance"?
pradykaushik commented 2019-11-21 00:57:11 +00:00 (Migrated from github.com)

You should use filepath.Join(...) to keep it generic.

You should use [filepath.Join(...)](https://golang.org/src/path/filepath/path.go?s=5893:5925#L199) to keep it generic.
pradykaushik commented 2019-11-21 01:06:38 +00:00 (Migrated from github.com)

You can possible rewrite this function to something like the one shown below.

func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) {
    filename := prefix + config.TaskDistConfig.FilenameExtension
    if logDir != "" {
        if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil {
            log.Fatal("Unable to create logFile: ", err)
        } else {
            cLog.LogFileName = logFile
            cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole
        }
    }
}
You can possible rewrite this function to something like the one shown below. ```go func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) { filename := prefix + config.TaskDistConfig.FilenameExtension if logDir != "" { if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil { log.Fatal("Unable to create logFile: ", err) } else { cLog.LogFileName = logFile cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole } } } ```
balandi1 commented 2019-11-21 18:48:26 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:11:44 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:27:31 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-21 22:47:52 +00:00 (Migrated from github.com)

Done

Done
ridv commented 2019-11-24 18:46:34 +00:00 (Migrated from github.com)

looks good now thanks!

looks good now thanks!
logger.SetOutput(os.Stdout)
ridv commented 2019-11-19 03:01:56 +00:00 (Migrated from github.com)

Use struct literals instead of new as it's more descriptive:
&ClsfnTaskDistOverheadLogger{}

Use struct literals instead of new as it's more descriptive: `&ClsfnTaskDistOverheadLogger{}`
ridv commented 2019-11-19 03:49:35 +00:00 (Migrated from github.com)

Where is log dir coming from? Shouldn't be a global

Where is log dir coming from? Shouldn't be a global
balandi1 commented 2019-11-20 18:49:00 +00:00 (Migrated from github.com)

Okay, will do the changes

Okay, will do the changes
balandi1 commented 2019-11-20 18:52:01 +00:00 (Migrated from github.com)

It is defined in createLogDir.go. Since all these files belong to same package, I accessed it in this way.

It is defined in `createLogDir.go`. Since all these files belong to same package, I accessed it in this way.
pradykaushik commented 2019-11-21 00:50:06 +00:00 (Migrated from github.com)

I think it will be better if it is encapsulated.
Something like

type logDir struct {
    name string
    // other fields if necessary.
}
I think it will be better if it is encapsulated. Something like ```go type logDir struct { name string // other fields if necessary. } ```
pradykaushik commented 2019-11-21 00:52:08 +00:00 (Migrated from github.com)

Maybe refactor to ClsfnTaskDistrOverheadLogger so that it is clear that we are intending "Distribution" and now "Distance"?

Maybe refactor to `ClsfnTaskDistrOverheadLogger` so that it is clear that we are intending "Distribution" and now "Distance"?
pradykaushik commented 2019-11-21 00:57:11 +00:00 (Migrated from github.com)

You should use filepath.Join(...) to keep it generic.

You should use [filepath.Join(...)](https://golang.org/src/path/filepath/path.go?s=5893:5925#L199) to keep it generic.
pradykaushik commented 2019-11-21 01:06:38 +00:00 (Migrated from github.com)

You can possible rewrite this function to something like the one shown below.

func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) {
    filename := prefix + config.TaskDistConfig.FilenameExtension
    if logDir != "" {
        if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil {
            log.Fatal("Unable to create logFile: ", err)
        } else {
            cLog.LogFileName = logFile
            cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole
        }
    }
}
You can possible rewrite this function to something like the one shown below. ```go func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) { filename := prefix + config.TaskDistConfig.FilenameExtension if logDir != "" { if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil { log.Fatal("Unable to create logFile: ", err) } else { cLog.LogFileName = logFile cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole } } } ```
balandi1 commented 2019-11-21 18:48:26 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:11:44 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:27:31 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-21 22:47:52 +00:00 (Migrated from github.com)

Done

Done
ridv commented 2019-11-24 18:46:34 +00:00 (Migrated from github.com)

looks good now thanks!

looks good now thanks!
logger.WithFields(logData).Println(message)
ridv commented 2019-11-19 03:01:56 +00:00 (Migrated from github.com)

Use struct literals instead of new as it's more descriptive:
&ClsfnTaskDistOverheadLogger{}

Use struct literals instead of new as it's more descriptive: `&ClsfnTaskDistOverheadLogger{}`
ridv commented 2019-11-19 03:49:35 +00:00 (Migrated from github.com)

Where is log dir coming from? Shouldn't be a global

Where is log dir coming from? Shouldn't be a global
balandi1 commented 2019-11-20 18:49:00 +00:00 (Migrated from github.com)

Okay, will do the changes

Okay, will do the changes
balandi1 commented 2019-11-20 18:52:01 +00:00 (Migrated from github.com)

It is defined in createLogDir.go. Since all these files belong to same package, I accessed it in this way.

It is defined in `createLogDir.go`. Since all these files belong to same package, I accessed it in this way.
pradykaushik commented 2019-11-21 00:50:06 +00:00 (Migrated from github.com)

I think it will be better if it is encapsulated.
Something like

type logDir struct {
    name string
    // other fields if necessary.
}
I think it will be better if it is encapsulated. Something like ```go type logDir struct { name string // other fields if necessary. } ```
pradykaushik commented 2019-11-21 00:52:08 +00:00 (Migrated from github.com)

Maybe refactor to ClsfnTaskDistrOverheadLogger so that it is clear that we are intending "Distribution" and now "Distance"?

Maybe refactor to `ClsfnTaskDistrOverheadLogger` so that it is clear that we are intending "Distribution" and now "Distance"?
pradykaushik commented 2019-11-21 00:57:11 +00:00 (Migrated from github.com)

You should use filepath.Join(...) to keep it generic.

You should use [filepath.Join(...)](https://golang.org/src/path/filepath/path.go?s=5893:5925#L199) to keep it generic.
pradykaushik commented 2019-11-21 01:06:38 +00:00 (Migrated from github.com)

You can possible rewrite this function to something like the one shown below.

func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) {
    filename := prefix + config.TaskDistConfig.FilenameExtension
    if logDir != "" {
        if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil {
            log.Fatal("Unable to create logFile: ", err)
        } else {
            cLog.LogFileName = logFile
            cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole
        }
    }
}
You can possible rewrite this function to something like the one shown below. ```go func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) { filename := prefix + config.TaskDistConfig.FilenameExtension if logDir != "" { if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil { log.Fatal("Unable to create logFile: ", err) } else { cLog.LogFileName = logFile cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole } } } ```
balandi1 commented 2019-11-21 18:48:26 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:11:44 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:27:31 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-21 22:47:52 +00:00 (Migrated from github.com)

Done

Done
ridv commented 2019-11-24 18:46:34 +00:00 (Migrated from github.com)

looks good now thanks!

looks good now thanks!
}
ridv commented 2019-11-19 03:01:56 +00:00 (Migrated from github.com)

Use struct literals instead of new as it's more descriptive:
&ClsfnTaskDistOverheadLogger{}

Use struct literals instead of new as it's more descriptive: `&ClsfnTaskDistOverheadLogger{}`
ridv commented 2019-11-19 03:49:35 +00:00 (Migrated from github.com)

Where is log dir coming from? Shouldn't be a global

Where is log dir coming from? Shouldn't be a global
balandi1 commented 2019-11-20 18:49:00 +00:00 (Migrated from github.com)

Okay, will do the changes

Okay, will do the changes
balandi1 commented 2019-11-20 18:52:01 +00:00 (Migrated from github.com)

It is defined in createLogDir.go. Since all these files belong to same package, I accessed it in this way.

It is defined in `createLogDir.go`. Since all these files belong to same package, I accessed it in this way.
pradykaushik commented 2019-11-21 00:50:06 +00:00 (Migrated from github.com)

I think it will be better if it is encapsulated.
Something like

type logDir struct {
    name string
    // other fields if necessary.
}
I think it will be better if it is encapsulated. Something like ```go type logDir struct { name string // other fields if necessary. } ```
pradykaushik commented 2019-11-21 00:52:08 +00:00 (Migrated from github.com)

Maybe refactor to ClsfnTaskDistrOverheadLogger so that it is clear that we are intending "Distribution" and now "Distance"?

Maybe refactor to `ClsfnTaskDistrOverheadLogger` so that it is clear that we are intending "Distribution" and now "Distance"?
pradykaushik commented 2019-11-21 00:57:11 +00:00 (Migrated from github.com)

You should use filepath.Join(...) to keep it generic.

You should use [filepath.Join(...)](https://golang.org/src/path/filepath/path.go?s=5893:5925#L199) to keep it generic.
pradykaushik commented 2019-11-21 01:06:38 +00:00 (Migrated from github.com)

You can possible rewrite this function to something like the one shown below.

func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) {
    filename := prefix + config.TaskDistConfig.FilenameExtension
    if logDir != "" {
        if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil {
            log.Fatal("Unable to create logFile: ", err)
        } else {
            cLog.LogFileName = logFile
            cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole
        }
    }
}
You can possible rewrite this function to something like the one shown below. ```go func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) { filename := prefix + config.TaskDistConfig.FilenameExtension if logDir != "" { if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil { log.Fatal("Unable to create logFile: ", err) } else { cLog.LogFileName = logFile cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole } } } ```
balandi1 commented 2019-11-21 18:48:26 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:11:44 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:27:31 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-21 22:47:52 +00:00 (Migrated from github.com)

Done

Done
ridv commented 2019-11-24 18:46:34 +00:00 (Migrated from github.com)

looks good now thanks!

looks good now thanks!
ridv commented 2019-11-19 03:01:56 +00:00 (Migrated from github.com)

Use struct literals instead of new as it's more descriptive:
&ClsfnTaskDistOverheadLogger{}

Use struct literals instead of new as it's more descriptive: `&ClsfnTaskDistOverheadLogger{}`
ridv commented 2019-11-19 03:49:35 +00:00 (Migrated from github.com)

Where is log dir coming from? Shouldn't be a global

Where is log dir coming from? Shouldn't be a global
balandi1 commented 2019-11-20 18:49:00 +00:00 (Migrated from github.com)

Okay, will do the changes

Okay, will do the changes
balandi1 commented 2019-11-20 18:52:01 +00:00 (Migrated from github.com)

It is defined in createLogDir.go. Since all these files belong to same package, I accessed it in this way.

It is defined in `createLogDir.go`. Since all these files belong to same package, I accessed it in this way.
pradykaushik commented 2019-11-21 00:50:06 +00:00 (Migrated from github.com)

I think it will be better if it is encapsulated.
Something like

type logDir struct {
    name string
    // other fields if necessary.
}
I think it will be better if it is encapsulated. Something like ```go type logDir struct { name string // other fields if necessary. } ```
pradykaushik commented 2019-11-21 00:52:08 +00:00 (Migrated from github.com)

Maybe refactor to ClsfnTaskDistrOverheadLogger so that it is clear that we are intending "Distribution" and now "Distance"?

Maybe refactor to `ClsfnTaskDistrOverheadLogger` so that it is clear that we are intending "Distribution" and now "Distance"?
pradykaushik commented 2019-11-21 00:57:11 +00:00 (Migrated from github.com)

You should use filepath.Join(...) to keep it generic.

You should use [filepath.Join(...)](https://golang.org/src/path/filepath/path.go?s=5893:5925#L199) to keep it generic.
pradykaushik commented 2019-11-21 01:06:38 +00:00 (Migrated from github.com)

You can possible rewrite this function to something like the one shown below.

func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) {
    filename := prefix + config.TaskDistConfig.FilenameExtension
    if logDir != "" {
        if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil {
            log.Fatal("Unable to create logFile: ", err)
        } else {
            cLog.LogFileName = logFile
            cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole
        }
    }
}
You can possible rewrite this function to something like the one shown below. ```go func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) { filename := prefix + config.TaskDistConfig.FilenameExtension if logDir != "" { if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil { log.Fatal("Unable to create logFile: ", err) } else { cLog.LogFileName = logFile cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole } } } ```
balandi1 commented 2019-11-21 18:48:26 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:11:44 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:27:31 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-21 22:47:52 +00:00 (Migrated from github.com)

Done

Done
ridv commented 2019-11-24 18:46:34 +00:00 (Migrated from github.com)

looks good now thanks!

looks good now thanks!
logger.SetOutput(cLog.LogFileName)
logger.WithFields(logData).Println(message)
}
@ -44,6 +44,6 @@ func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) {
ridv commented 2019-11-19 03:01:56 +00:00 (Migrated from github.com)

Use struct literals instead of new as it's more descriptive:
&ClsfnTaskDistOverheadLogger{}

Use struct literals instead of new as it's more descriptive: `&ClsfnTaskDistOverheadLogger{}`
ridv commented 2019-11-19 03:49:35 +00:00 (Migrated from github.com)

Where is log dir coming from? Shouldn't be a global

Where is log dir coming from? Shouldn't be a global
balandi1 commented 2019-11-20 18:49:00 +00:00 (Migrated from github.com)

Okay, will do the changes

Okay, will do the changes
balandi1 commented 2019-11-20 18:52:01 +00:00 (Migrated from github.com)

It is defined in createLogDir.go. Since all these files belong to same package, I accessed it in this way.

It is defined in `createLogDir.go`. Since all these files belong to same package, I accessed it in this way.
pradykaushik commented 2019-11-21 00:50:06 +00:00 (Migrated from github.com)

I think it will be better if it is encapsulated.
Something like

type logDir struct {
    name string
    // other fields if necessary.
}
I think it will be better if it is encapsulated. Something like ```go type logDir struct { name string // other fields if necessary. } ```
pradykaushik commented 2019-11-21 00:52:08 +00:00 (Migrated from github.com)

Maybe refactor to ClsfnTaskDistrOverheadLogger so that it is clear that we are intending "Distribution" and now "Distance"?

Maybe refactor to `ClsfnTaskDistrOverheadLogger` so that it is clear that we are intending "Distribution" and now "Distance"?
pradykaushik commented 2019-11-21 00:57:11 +00:00 (Migrated from github.com)

You should use filepath.Join(...) to keep it generic.

You should use [filepath.Join(...)](https://golang.org/src/path/filepath/path.go?s=5893:5925#L199) to keep it generic.
pradykaushik commented 2019-11-21 01:06:38 +00:00 (Migrated from github.com)

You can possible rewrite this function to something like the one shown below.

func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) {
    filename := prefix + config.TaskDistConfig.FilenameExtension
    if logDir != "" {
        if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil {
            log.Fatal("Unable to create logFile: ", err)
        } else {
            cLog.LogFileName = logFile
            cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole
        }
    }
}
You can possible rewrite this function to something like the one shown below. ```go func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) { filename := prefix + config.TaskDistConfig.FilenameExtension if logDir != "" { if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil { log.Fatal("Unable to create logFile: ", err) } else { cLog.LogFileName = logFile cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole } } } ```
balandi1 commented 2019-11-21 18:48:26 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:11:44 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:27:31 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-21 22:47:52 +00:00 (Migrated from github.com)

Done

Done
ridv commented 2019-11-24 18:46:34 +00:00 (Migrated from github.com)

looks good now thanks!

looks good now thanks!
ridv commented 2019-11-19 03:01:56 +00:00 (Migrated from github.com)

Use struct literals instead of new as it's more descriptive:
&ClsfnTaskDistOverheadLogger{}

Use struct literals instead of new as it's more descriptive: `&ClsfnTaskDistOverheadLogger{}`
ridv commented 2019-11-19 03:49:35 +00:00 (Migrated from github.com)

Where is log dir coming from? Shouldn't be a global

Where is log dir coming from? Shouldn't be a global
balandi1 commented 2019-11-20 18:49:00 +00:00 (Migrated from github.com)

Okay, will do the changes

Okay, will do the changes
balandi1 commented 2019-11-20 18:52:01 +00:00 (Migrated from github.com)

It is defined in createLogDir.go. Since all these files belong to same package, I accessed it in this way.

It is defined in `createLogDir.go`. Since all these files belong to same package, I accessed it in this way.
pradykaushik commented 2019-11-21 00:50:06 +00:00 (Migrated from github.com)

I think it will be better if it is encapsulated.
Something like

type logDir struct {
    name string
    // other fields if necessary.
}
I think it will be better if it is encapsulated. Something like ```go type logDir struct { name string // other fields if necessary. } ```
pradykaushik commented 2019-11-21 00:52:08 +00:00 (Migrated from github.com)

Maybe refactor to ClsfnTaskDistrOverheadLogger so that it is clear that we are intending "Distribution" and now "Distance"?

Maybe refactor to `ClsfnTaskDistrOverheadLogger` so that it is clear that we are intending "Distribution" and now "Distance"?
pradykaushik commented 2019-11-21 00:57:11 +00:00 (Migrated from github.com)

You should use filepath.Join(...) to keep it generic.

You should use [filepath.Join(...)](https://golang.org/src/path/filepath/path.go?s=5893:5925#L199) to keep it generic.
pradykaushik commented 2019-11-21 01:06:38 +00:00 (Migrated from github.com)

You can possible rewrite this function to something like the one shown below.

func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) {
    filename := prefix + config.TaskDistConfig.FilenameExtension
    if logDir != "" {
        if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil {
            log.Fatal("Unable to create logFile: ", err)
        } else {
            cLog.LogFileName = logFile
            cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole
        }
    }
}
You can possible rewrite this function to something like the one shown below. ```go func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) { filename := prefix + config.TaskDistConfig.FilenameExtension if logDir != "" { if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil { log.Fatal("Unable to create logFile: ", err) } else { cLog.LogFileName = logFile cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole } } } ```
balandi1 commented 2019-11-21 18:48:26 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:11:44 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:27:31 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-21 22:47:52 +00:00 (Migrated from github.com)

Done

Done
ridv commented 2019-11-24 18:46:34 +00:00 (Migrated from github.com)

looks good now thanks!

looks good now thanks!
log.Fatal("Unable to create logFile: ", err)
} else {
cLog.LogFileName = logFile
cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole
ridv commented 2019-11-19 03:01:56 +00:00 (Migrated from github.com)

Use struct literals instead of new as it's more descriptive:
&ClsfnTaskDistOverheadLogger{}

Use struct literals instead of new as it's more descriptive: `&ClsfnTaskDistOverheadLogger{}`
ridv commented 2019-11-19 03:49:35 +00:00 (Migrated from github.com)

Where is log dir coming from? Shouldn't be a global

Where is log dir coming from? Shouldn't be a global
balandi1 commented 2019-11-20 18:49:00 +00:00 (Migrated from github.com)

Okay, will do the changes

Okay, will do the changes
balandi1 commented 2019-11-20 18:52:01 +00:00 (Migrated from github.com)

It is defined in createLogDir.go. Since all these files belong to same package, I accessed it in this way.

It is defined in `createLogDir.go`. Since all these files belong to same package, I accessed it in this way.
pradykaushik commented 2019-11-21 00:50:06 +00:00 (Migrated from github.com)

I think it will be better if it is encapsulated.
Something like

type logDir struct {
    name string
    // other fields if necessary.
}
I think it will be better if it is encapsulated. Something like ```go type logDir struct { name string // other fields if necessary. } ```
pradykaushik commented 2019-11-21 00:52:08 +00:00 (Migrated from github.com)

Maybe refactor to ClsfnTaskDistrOverheadLogger so that it is clear that we are intending "Distribution" and now "Distance"?

Maybe refactor to `ClsfnTaskDistrOverheadLogger` so that it is clear that we are intending "Distribution" and now "Distance"?
pradykaushik commented 2019-11-21 00:57:11 +00:00 (Migrated from github.com)

You should use filepath.Join(...) to keep it generic.

You should use [filepath.Join(...)](https://golang.org/src/path/filepath/path.go?s=5893:5925#L199) to keep it generic.
pradykaushik commented 2019-11-21 01:06:38 +00:00 (Migrated from github.com)

You can possible rewrite this function to something like the one shown below.

func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) {
    filename := prefix + config.TaskDistConfig.FilenameExtension
    if logDir != "" {
        if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil {
            log.Fatal("Unable to create logFile: ", err)
        } else {
            cLog.LogFileName = logFile
            cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole
        }
    }
}
You can possible rewrite this function to something like the one shown below. ```go func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) { filename := prefix + config.TaskDistConfig.FilenameExtension if logDir != "" { if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil { log.Fatal("Unable to create logFile: ", err) } else { cLog.LogFileName = logFile cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole } } } ```
balandi1 commented 2019-11-21 18:48:26 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:11:44 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:27:31 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-21 22:47:52 +00:00 (Migrated from github.com)

Done

Done
ridv commented 2019-11-24 18:46:34 +00:00 (Migrated from github.com)

looks good now thanks!

looks good now thanks!
cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole
ridv commented 2019-11-19 03:01:56 +00:00 (Migrated from github.com)

Use struct literals instead of new as it's more descriptive:
&ClsfnTaskDistOverheadLogger{}

Use struct literals instead of new as it's more descriptive: `&ClsfnTaskDistOverheadLogger{}`
ridv commented 2019-11-19 03:49:35 +00:00 (Migrated from github.com)

Where is log dir coming from? Shouldn't be a global

Where is log dir coming from? Shouldn't be a global
balandi1 commented 2019-11-20 18:49:00 +00:00 (Migrated from github.com)

Okay, will do the changes

Okay, will do the changes
balandi1 commented 2019-11-20 18:52:01 +00:00 (Migrated from github.com)

It is defined in createLogDir.go. Since all these files belong to same package, I accessed it in this way.

It is defined in `createLogDir.go`. Since all these files belong to same package, I accessed it in this way.
pradykaushik commented 2019-11-21 00:50:06 +00:00 (Migrated from github.com)

I think it will be better if it is encapsulated.
Something like

type logDir struct {
    name string
    // other fields if necessary.
}
I think it will be better if it is encapsulated. Something like ```go type logDir struct { name string // other fields if necessary. } ```
pradykaushik commented 2019-11-21 00:52:08 +00:00 (Migrated from github.com)

Maybe refactor to ClsfnTaskDistrOverheadLogger so that it is clear that we are intending "Distribution" and now "Distance"?

Maybe refactor to `ClsfnTaskDistrOverheadLogger` so that it is clear that we are intending "Distribution" and now "Distance"?
pradykaushik commented 2019-11-21 00:57:11 +00:00 (Migrated from github.com)

You should use filepath.Join(...) to keep it generic.

You should use [filepath.Join(...)](https://golang.org/src/path/filepath/path.go?s=5893:5925#L199) to keep it generic.
pradykaushik commented 2019-11-21 01:06:38 +00:00 (Migrated from github.com)

You can possible rewrite this function to something like the one shown below.

func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) {
    filename := prefix + config.TaskDistConfig.FilenameExtension
    if logDir != "" {
        if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil {
            log.Fatal("Unable to create logFile: ", err)
        } else {
            cLog.LogFileName = logFile
            cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole
        }
    }
}
You can possible rewrite this function to something like the one shown below. ```go func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) { filename := prefix + config.TaskDistConfig.FilenameExtension if logDir != "" { if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil { log.Fatal("Unable to create logFile: ", err) } else { cLog.LogFileName = logFile cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole } } } ```
balandi1 commented 2019-11-21 18:48:26 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:11:44 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:27:31 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-21 22:47:52 +00:00 (Migrated from github.com)

Done

Done
ridv commented 2019-11-24 18:46:34 +00:00 (Migrated from github.com)

looks good now thanks!

looks good now thanks!
}
}

ridv commented 2019-11-19 03:01:56 +00:00 (Migrated from github.com)

Use struct literals instead of new as it's more descriptive:
&ClsfnTaskDistOverheadLogger{}

Use struct literals instead of new as it's more descriptive: `&ClsfnTaskDistOverheadLogger{}`
ridv commented 2019-11-19 03:49:35 +00:00 (Migrated from github.com)

Where is log dir coming from? Shouldn't be a global

Where is log dir coming from? Shouldn't be a global
balandi1 commented 2019-11-20 18:49:00 +00:00 (Migrated from github.com)

Okay, will do the changes

Okay, will do the changes
balandi1 commented 2019-11-20 18:52:01 +00:00 (Migrated from github.com)

It is defined in createLogDir.go. Since all these files belong to same package, I accessed it in this way.

It is defined in `createLogDir.go`. Since all these files belong to same package, I accessed it in this way.
pradykaushik commented 2019-11-21 00:50:06 +00:00 (Migrated from github.com)

I think it will be better if it is encapsulated.
Something like

type logDir struct {
    name string
    // other fields if necessary.
}
I think it will be better if it is encapsulated. Something like ```go type logDir struct { name string // other fields if necessary. } ```
pradykaushik commented 2019-11-21 00:52:08 +00:00 (Migrated from github.com)

Maybe refactor to ClsfnTaskDistrOverheadLogger so that it is clear that we are intending "Distribution" and now "Distance"?

Maybe refactor to `ClsfnTaskDistrOverheadLogger` so that it is clear that we are intending "Distribution" and now "Distance"?
pradykaushik commented 2019-11-21 00:57:11 +00:00 (Migrated from github.com)

You should use filepath.Join(...) to keep it generic.

You should use [filepath.Join(...)](https://golang.org/src/path/filepath/path.go?s=5893:5925#L199) to keep it generic.
pradykaushik commented 2019-11-21 01:06:38 +00:00 (Migrated from github.com)

You can possible rewrite this function to something like the one shown below.

func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) {
    filename := prefix + config.TaskDistConfig.FilenameExtension
    if logDir != "" {
        if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil {
            log.Fatal("Unable to create logFile: ", err)
        } else {
            cLog.LogFileName = logFile
            cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole
        }
    }
}
You can possible rewrite this function to something like the one shown below. ```go func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) { filename := prefix + config.TaskDistConfig.FilenameExtension if logDir != "" { if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil { log.Fatal("Unable to create logFile: ", err) } else { cLog.LogFileName = logFile cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole } } } ```
balandi1 commented 2019-11-21 18:48:26 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:11:44 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:27:31 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-21 22:47:52 +00:00 (Migrated from github.com)

Done

Done
ridv commented 2019-11-24 18:46:34 +00:00 (Migrated from github.com)

looks good now thanks!

looks good now thanks!
ridv commented 2019-11-19 03:01:56 +00:00 (Migrated from github.com)

Use struct literals instead of new as it's more descriptive:
&ClsfnTaskDistOverheadLogger{}

Use struct literals instead of new as it's more descriptive: `&ClsfnTaskDistOverheadLogger{}`
ridv commented 2019-11-19 03:49:35 +00:00 (Migrated from github.com)

Where is log dir coming from? Shouldn't be a global

Where is log dir coming from? Shouldn't be a global
balandi1 commented 2019-11-20 18:49:00 +00:00 (Migrated from github.com)

Okay, will do the changes

Okay, will do the changes
balandi1 commented 2019-11-20 18:52:01 +00:00 (Migrated from github.com)

It is defined in createLogDir.go. Since all these files belong to same package, I accessed it in this way.

It is defined in `createLogDir.go`. Since all these files belong to same package, I accessed it in this way.
pradykaushik commented 2019-11-21 00:50:06 +00:00 (Migrated from github.com)

I think it will be better if it is encapsulated.
Something like

type logDir struct {
    name string
    // other fields if necessary.
}
I think it will be better if it is encapsulated. Something like ```go type logDir struct { name string // other fields if necessary. } ```
pradykaushik commented 2019-11-21 00:52:08 +00:00 (Migrated from github.com)

Maybe refactor to ClsfnTaskDistrOverheadLogger so that it is clear that we are intending "Distribution" and now "Distance"?

Maybe refactor to `ClsfnTaskDistrOverheadLogger` so that it is clear that we are intending "Distribution" and now "Distance"?
pradykaushik commented 2019-11-21 00:57:11 +00:00 (Migrated from github.com)

You should use filepath.Join(...) to keep it generic.

You should use [filepath.Join(...)](https://golang.org/src/path/filepath/path.go?s=5893:5925#L199) to keep it generic.
pradykaushik commented 2019-11-21 01:06:38 +00:00 (Migrated from github.com)

You can possible rewrite this function to something like the one shown below.

func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) {
    filename := prefix + config.TaskDistConfig.FilenameExtension
    if logDir != "" {
        if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil {
            log.Fatal("Unable to create logFile: ", err)
        } else {
            cLog.LogFileName = logFile
            cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole
        }
    }
}
You can possible rewrite this function to something like the one shown below. ```go func (cLog *ClsfnTaskDistOverheadLogger) SetLogFile(prefix string) { filename := prefix + config.TaskDistConfig.FilenameExtension if logDir != "" { if logFile, err := os.Create(filepath.Join(logDir, filename)); err != nil { log.Fatal("Unable to create logFile: ", err) } else { cLog.LogFileName = logFile cLog.AllowOnConsole = config.TaskDistConfig.AllowOnConsole } } } ```
balandi1 commented 2019-11-21 18:48:26 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:11:44 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-21 20:27:31 +00:00 (Migrated from github.com)

Okay. Sure

Okay. Sure
balandi1 commented 2019-11-21 22:47:52 +00:00 (Migrated from github.com)

Done

Done
ridv commented 2019-11-24 18:46:34 +00:00 (Migrated from github.com)

looks good now thanks!

looks good now thanks!

View file

@ -1,8 +1,8 @@
pradykaushik commented 2019-11-21 01:18:14 +00:00 (Migrated from github.com)

I see why you are directly assigning true. However, to allow disabling console logs to stdout retrofit this to cLog.AllowOnConsole = config.ConsoleConfig.AllowOnConsole.

I see why you are directly assigning `true`. However, to allow disabling console logs to stdout retrofit this to `cLog.AllowOnConsole = config.ConsoleConfig.AllowOnConsole`.
pradykaushik commented 2019-11-21 01:31:25 +00:00 (Migrated from github.com)

Why the pointer receiver? Technically, this function should not lead to change of state.

Why the pointer receiver? Technically, this function should not lead to change of state.
balandi1 commented 2019-11-21 22:47:38 +00:00 (Migrated from github.com)

Sure

Sure
balandi1 commented 2019-11-21 22:52:32 +00:00 (Migrated from github.com)

Yeah, thats right. I will change it

Yeah, thats right. I will change it
pradykaushik commented 2019-11-21 01:18:14 +00:00 (Migrated from github.com)

I see why you are directly assigning true. However, to allow disabling console logs to stdout retrofit this to cLog.AllowOnConsole = config.ConsoleConfig.AllowOnConsole.

I see why you are directly assigning `true`. However, to allow disabling console logs to stdout retrofit this to `cLog.AllowOnConsole = config.ConsoleConfig.AllowOnConsole`.
pradykaushik commented 2019-11-21 01:31:25 +00:00 (Migrated from github.com)

Why the pointer receiver? Technically, this function should not lead to change of state.

Why the pointer receiver? Technically, this function should not lead to change of state.
balandi1 commented 2019-11-21 22:47:38 +00:00 (Migrated from github.com)

Sure

Sure
balandi1 commented 2019-11-21 22:52:32 +00:00 (Migrated from github.com)

Yeah, thats right. I will change it

Yeah, thats right. I will change it
package elektronLogging
import (
"os"
pradykaushik commented 2019-11-21 01:18:14 +00:00 (Migrated from github.com)

I see why you are directly assigning true. However, to allow disabling console logs to stdout retrofit this to cLog.AllowOnConsole = config.ConsoleConfig.AllowOnConsole.

I see why you are directly assigning `true`. However, to allow disabling console logs to stdout retrofit this to `cLog.AllowOnConsole = config.ConsoleConfig.AllowOnConsole`.
pradykaushik commented 2019-11-21 01:31:25 +00:00 (Migrated from github.com)

Why the pointer receiver? Technically, this function should not lead to change of state.

Why the pointer receiver? Technically, this function should not lead to change of state.
balandi1 commented 2019-11-21 22:47:38 +00:00 (Migrated from github.com)

Sure

Sure
balandi1 commented 2019-11-21 22:52:32 +00:00 (Migrated from github.com)

Yeah, thats right. I will change it

Yeah, thats right. I will change it
log "github.com/sirupsen/logrus"
"os"
pradykaushik commented 2019-11-21 01:18:14 +00:00 (Migrated from github.com)

I see why you are directly assigning true. However, to allow disabling console logs to stdout retrofit this to cLog.AllowOnConsole = config.ConsoleConfig.AllowOnConsole.

I see why you are directly assigning `true`. However, to allow disabling console logs to stdout retrofit this to `cLog.AllowOnConsole = config.ConsoleConfig.AllowOnConsole`.
pradykaushik commented 2019-11-21 01:31:25 +00:00 (Migrated from github.com)

Why the pointer receiver? Technically, this function should not lead to change of state.

Why the pointer receiver? Technically, this function should not lead to change of state.
balandi1 commented 2019-11-21 22:47:38 +00:00 (Migrated from github.com)

Sure

Sure
balandi1 commented 2019-11-21 22:52:32 +00:00 (Migrated from github.com)

Yeah, thats right. I will change it

Yeah, thats right. I will change it
)
type ConsoleLogger struct {
@ -20,10 +20,10 @@ func (cLog *ConsoleLogger) Log(logType int, level log.Level, logData log.Fields,
pradykaushik commented 2019-11-21 01:18:14 +00:00 (Migrated from github.com)

I see why you are directly assigning true. However, to allow disabling console logs to stdout retrofit this to cLog.AllowOnConsole = config.ConsoleConfig.AllowOnConsole.

I see why you are directly assigning `true`. However, to allow disabling console logs to stdout retrofit this to `cLog.AllowOnConsole = config.ConsoleConfig.AllowOnConsole`.
pradykaushik commented 2019-11-21 01:31:25 +00:00 (Migrated from github.com)

Why the pointer receiver? Technically, this function should not lead to change of state.

Why the pointer receiver? Technically, this function should not lead to change of state.
balandi1 commented 2019-11-21 22:47:38 +00:00 (Migrated from github.com)

Sure

Sure
balandi1 commented 2019-11-21 22:52:32 +00:00 (Migrated from github.com)

Yeah, thats right. I will change it

Yeah, thats right. I will change it
pradykaushik commented 2019-11-21 01:18:14 +00:00 (Migrated from github.com)

I see why you are directly assigning true. However, to allow disabling console logs to stdout retrofit this to cLog.AllowOnConsole = config.ConsoleConfig.AllowOnConsole.

I see why you are directly assigning `true`. However, to allow disabling console logs to stdout retrofit this to `cLog.AllowOnConsole = config.ConsoleConfig.AllowOnConsole`.
pradykaushik commented 2019-11-21 01:31:25 +00:00 (Migrated from github.com)

Why the pointer receiver? Technically, this function should not lead to change of state.

Why the pointer receiver? Technically, this function should not lead to change of state.
balandi1 commented 2019-11-21 22:47:38 +00:00 (Migrated from github.com)

Sure

Sure
balandi1 commented 2019-11-21 22:52:32 +00:00 (Migrated from github.com)

Yeah, thats right. I will change it

Yeah, thats right. I will change it
//logFields := cloneFields(logData)
logger.SetLevel(level)
pradykaushik commented 2019-11-21 01:18:14 +00:00 (Migrated from github.com)

I see why you are directly assigning true. However, to allow disabling console logs to stdout retrofit this to cLog.AllowOnConsole = config.ConsoleConfig.AllowOnConsole.

I see why you are directly assigning `true`. However, to allow disabling console logs to stdout retrofit this to `cLog.AllowOnConsole = config.ConsoleConfig.AllowOnConsole`.
pradykaushik commented 2019-11-21 01:31:25 +00:00 (Migrated from github.com)

Why the pointer receiver? Technically, this function should not lead to change of state.

Why the pointer receiver? Technically, this function should not lead to change of state.
balandi1 commented 2019-11-21 22:47:38 +00:00 (Migrated from github.com)

Sure

Sure
balandi1 commented 2019-11-21 22:52:32 +00:00 (Migrated from github.com)

Yeah, thats right. I will change it

Yeah, thats right. I will change it
pradykaushik commented 2019-11-21 01:18:14 +00:00 (Migrated from github.com)

I see why you are directly assigning true. However, to allow disabling console logs to stdout retrofit this to cLog.AllowOnConsole = config.ConsoleConfig.AllowOnConsole.

I see why you are directly assigning `true`. However, to allow disabling console logs to stdout retrofit this to `cLog.AllowOnConsole = config.ConsoleConfig.AllowOnConsole`.
pradykaushik commented 2019-11-21 01:31:25 +00:00 (Migrated from github.com)

Why the pointer receiver? Technically, this function should not lead to change of state.

Why the pointer receiver? Technically, this function should not lead to change of state.
balandi1 commented 2019-11-21 22:47:38 +00:00 (Migrated from github.com)

Sure

Sure
balandi1 commented 2019-11-21 22:52:32 +00:00 (Migrated from github.com)

Yeah, thats right. I will change it

Yeah, thats right. I will change it
logger.SetOutput(os.Stdout)
logger.WithFields(logData).Println(message)
pradykaushik commented 2019-11-21 01:18:14 +00:00 (Migrated from github.com)

I see why you are directly assigning true. However, to allow disabling console logs to stdout retrofit this to cLog.AllowOnConsole = config.ConsoleConfig.AllowOnConsole.

I see why you are directly assigning `true`. However, to allow disabling console logs to stdout retrofit this to `cLog.AllowOnConsole = config.ConsoleConfig.AllowOnConsole`.
pradykaushik commented 2019-11-21 01:31:25 +00:00 (Migrated from github.com)

Why the pointer receiver? Technically, this function should not lead to change of state.

Why the pointer receiver? Technically, this function should not lead to change of state.
balandi1 commented 2019-11-21 22:47:38 +00:00 (Migrated from github.com)

Sure

Sure
balandi1 commented 2019-11-21 22:52:32 +00:00 (Migrated from github.com)

Yeah, thats right. I will change it

Yeah, thats right. I will change it
pradykaushik commented 2019-11-21 01:18:14 +00:00 (Migrated from github.com)

I see why you are directly assigning true. However, to allow disabling console logs to stdout retrofit this to cLog.AllowOnConsole = config.ConsoleConfig.AllowOnConsole.

I see why you are directly assigning `true`. However, to allow disabling console logs to stdout retrofit this to `cLog.AllowOnConsole = config.ConsoleConfig.AllowOnConsole`.
pradykaushik commented 2019-11-21 01:31:25 +00:00 (Migrated from github.com)

Why the pointer receiver? Technically, this function should not lead to change of state.

Why the pointer receiver? Technically, this function should not lead to change of state.
balandi1 commented 2019-11-21 22:47:38 +00:00 (Migrated from github.com)

Sure

Sure
balandi1 commented 2019-11-21 22:52:32 +00:00 (Migrated from github.com)

Yeah, thats right. I will change it

Yeah, thats right. I will change it
logger.SetOutput(cLog.LogFileName)
logger.WithFields(logData).Println(message)
}
@ -42,6 +42,6 @@ func (cLog *ConsoleLogger) SetLogFile(prefix string) {
pradykaushik commented 2019-11-21 01:18:14 +00:00 (Migrated from github.com)

I see why you are directly assigning true. However, to allow disabling console logs to stdout retrofit this to cLog.AllowOnConsole = config.ConsoleConfig.AllowOnConsole.

I see why you are directly assigning `true`. However, to allow disabling console logs to stdout retrofit this to `cLog.AllowOnConsole = config.ConsoleConfig.AllowOnConsole`.
pradykaushik commented 2019-11-21 01:31:25 +00:00 (Migrated from github.com)

Why the pointer receiver? Technically, this function should not lead to change of state.

Why the pointer receiver? Technically, this function should not lead to change of state.
balandi1 commented 2019-11-21 22:47:38 +00:00 (Migrated from github.com)

Sure

Sure
balandi1 commented 2019-11-21 22:52:32 +00:00 (Migrated from github.com)

Yeah, thats right. I will change it

Yeah, thats right. I will change it
pradykaushik commented 2019-11-21 01:18:14 +00:00 (Migrated from github.com)

I see why you are directly assigning true. However, to allow disabling console logs to stdout retrofit this to cLog.AllowOnConsole = config.ConsoleConfig.AllowOnConsole.

I see why you are directly assigning `true`. However, to allow disabling console logs to stdout retrofit this to `cLog.AllowOnConsole = config.ConsoleConfig.AllowOnConsole`.
pradykaushik commented 2019-11-21 01:31:25 +00:00 (Migrated from github.com)

Why the pointer receiver? Technically, this function should not lead to change of state.

Why the pointer receiver? Technically, this function should not lead to change of state.
balandi1 commented 2019-11-21 22:47:38 +00:00 (Migrated from github.com)

Sure

Sure
balandi1 commented 2019-11-21 22:52:32 +00:00 (Migrated from github.com)

Yeah, thats right. I will change it

Yeah, thats right. I will change it
log.Fatal("Unable to create logFile: ", err)
} else {
cLog.LogFileName = logFile
cLog.AllowOnConsole = true
pradykaushik commented 2019-11-21 01:18:14 +00:00 (Migrated from github.com)

I see why you are directly assigning true. However, to allow disabling console logs to stdout retrofit this to cLog.AllowOnConsole = config.ConsoleConfig.AllowOnConsole.

I see why you are directly assigning `true`. However, to allow disabling console logs to stdout retrofit this to `cLog.AllowOnConsole = config.ConsoleConfig.AllowOnConsole`.
pradykaushik commented 2019-11-21 01:31:25 +00:00 (Migrated from github.com)

Why the pointer receiver? Technically, this function should not lead to change of state.

Why the pointer receiver? Technically, this function should not lead to change of state.
balandi1 commented 2019-11-21 22:47:38 +00:00 (Migrated from github.com)

Sure

Sure
balandi1 commented 2019-11-21 22:52:32 +00:00 (Migrated from github.com)

Yeah, thats right. I will change it

Yeah, thats right. I will change it
cLog.AllowOnConsole = true
pradykaushik commented 2019-11-21 01:18:14 +00:00 (Migrated from github.com)

I see why you are directly assigning true. However, to allow disabling console logs to stdout retrofit this to cLog.AllowOnConsole = config.ConsoleConfig.AllowOnConsole.

I see why you are directly assigning `true`. However, to allow disabling console logs to stdout retrofit this to `cLog.AllowOnConsole = config.ConsoleConfig.AllowOnConsole`.
pradykaushik commented 2019-11-21 01:31:25 +00:00 (Migrated from github.com)

Why the pointer receiver? Technically, this function should not lead to change of state.

Why the pointer receiver? Technically, this function should not lead to change of state.
balandi1 commented 2019-11-21 22:47:38 +00:00 (Migrated from github.com)

Sure

Sure
balandi1 commented 2019-11-21 22:52:32 +00:00 (Migrated from github.com)

Yeah, thats right. I will change it

Yeah, thats right. I will change it
}
}

pradykaushik commented 2019-11-21 01:18:14 +00:00 (Migrated from github.com)

I see why you are directly assigning true. However, to allow disabling console logs to stdout retrofit this to cLog.AllowOnConsole = config.ConsoleConfig.AllowOnConsole.

I see why you are directly assigning `true`. However, to allow disabling console logs to stdout retrofit this to `cLog.AllowOnConsole = config.ConsoleConfig.AllowOnConsole`.
pradykaushik commented 2019-11-21 01:31:25 +00:00 (Migrated from github.com)

Why the pointer receiver? Technically, this function should not lead to change of state.

Why the pointer receiver? Technically, this function should not lead to change of state.
balandi1 commented 2019-11-21 22:47:38 +00:00 (Migrated from github.com)

Sure

Sure
balandi1 commented 2019-11-21 22:52:32 +00:00 (Migrated from github.com)

Yeah, thats right. I will change it

Yeah, thats right. I will change it
pradykaushik commented 2019-11-21 01:18:14 +00:00 (Migrated from github.com)

I see why you are directly assigning true. However, to allow disabling console logs to stdout retrofit this to cLog.AllowOnConsole = config.ConsoleConfig.AllowOnConsole.

I see why you are directly assigning `true`. However, to allow disabling console logs to stdout retrofit this to `cLog.AllowOnConsole = config.ConsoleConfig.AllowOnConsole`.
pradykaushik commented 2019-11-21 01:31:25 +00:00 (Migrated from github.com)

Why the pointer receiver? Technically, this function should not lead to change of state.

Why the pointer receiver? Technically, this function should not lead to change of state.
balandi1 commented 2019-11-21 22:47:38 +00:00 (Migrated from github.com)

Sure

Sure
balandi1 commented 2019-11-21 22:52:32 +00:00 (Migrated from github.com)

Yeah, thats right. I will change it

Yeah, thats right. I will change it

View file

@ -1,10 +1,10 @@
ridv commented 2019-11-19 03:50:51 +00:00 (Migrated from github.com)

Why not use string.join([]string{...}, "") ?

Why not use `string.join([]string{...}, "")` ?
balandi1 commented 2019-11-20 18:52:16 +00:00 (Migrated from github.com)

Yeah, thats right

Yeah, thats right
pradykaushik commented 2019-11-21 01:10:18 +00:00 (Migrated from github.com)

Extend the comment to show how the format of the log directory name is going to look.

Extend the comment to show how the format of the log directory name is going to look.
pradykaushik commented 2019-11-21 01:19:20 +00:00 (Migrated from github.com)

Keep the alias for logrus import consistent. So, refactor this to "log".

Keep the alias for logrus import consistent. So, refactor this to "log".
balandi1 commented 2019-11-26 17:44:43 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:07:01 +00:00 (Migrated from github.com)

Done

Done
ridv commented 2019-11-19 03:50:51 +00:00 (Migrated from github.com)

Why not use string.join([]string{...}, "") ?

Why not use `string.join([]string{...}, "")` ?
balandi1 commented 2019-11-20 18:52:16 +00:00 (Migrated from github.com)

Yeah, thats right

Yeah, thats right
pradykaushik commented 2019-11-21 01:10:18 +00:00 (Migrated from github.com)

Extend the comment to show how the format of the log directory name is going to look.

Extend the comment to show how the format of the log directory name is going to look.
pradykaushik commented 2019-11-21 01:19:20 +00:00 (Migrated from github.com)

Keep the alias for logrus import consistent. So, refactor this to "log".

Keep the alias for logrus import consistent. So, refactor this to "log".
balandi1 commented 2019-11-26 17:44:43 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:07:01 +00:00 (Migrated from github.com)

Done

Done
package elektronLogging
import (
logrus "github.com/sirupsen/logrus"
ridv commented 2019-11-19 03:50:51 +00:00 (Migrated from github.com)

Why not use string.join([]string{...}, "") ?

Why not use `string.join([]string{...}, "")` ?
balandi1 commented 2019-11-20 18:52:16 +00:00 (Migrated from github.com)

Yeah, thats right

Yeah, thats right
pradykaushik commented 2019-11-21 01:10:18 +00:00 (Migrated from github.com)

Extend the comment to show how the format of the log directory name is going to look.

Extend the comment to show how the format of the log directory name is going to look.
pradykaushik commented 2019-11-21 01:19:20 +00:00 (Migrated from github.com)

Keep the alias for logrus import consistent. So, refactor this to "log".

Keep the alias for logrus import consistent. So, refactor this to "log".
balandi1 commented 2019-11-26 17:44:43 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:07:01 +00:00 (Migrated from github.com)

Done

Done
"os"
"strconv"
"time"
logrus "github.com/sirupsen/logrus"
ridv commented 2019-11-19 03:50:51 +00:00 (Migrated from github.com)

Why not use string.join([]string{...}, "") ?

Why not use `string.join([]string{...}, "")` ?
balandi1 commented 2019-11-20 18:52:16 +00:00 (Migrated from github.com)

Yeah, thats right

Yeah, thats right
pradykaushik commented 2019-11-21 01:10:18 +00:00 (Migrated from github.com)

Extend the comment to show how the format of the log directory name is going to look.

Extend the comment to show how the format of the log directory name is going to look.
pradykaushik commented 2019-11-21 01:19:20 +00:00 (Migrated from github.com)

Keep the alias for logrus import consistent. So, refactor this to "log".

Keep the alias for logrus import consistent. So, refactor this to "log".
balandi1 commented 2019-11-26 17:44:43 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:07:01 +00:00 (Migrated from github.com)

Done

Done
)
var logDir string

ridv commented 2019-11-19 03:50:51 +00:00 (Migrated from github.com)

Why not use string.join([]string{...}, "") ?

Why not use `string.join([]string{...}, "")` ?
balandi1 commented 2019-11-20 18:52:16 +00:00 (Migrated from github.com)

Yeah, thats right

Yeah, thats right
pradykaushik commented 2019-11-21 01:10:18 +00:00 (Migrated from github.com)

Extend the comment to show how the format of the log directory name is going to look.

Extend the comment to show how the format of the log directory name is going to look.
pradykaushik commented 2019-11-21 01:19:20 +00:00 (Migrated from github.com)

Keep the alias for logrus import consistent. So, refactor this to "log".

Keep the alias for logrus import consistent. So, refactor this to "log".
balandi1 commented 2019-11-26 17:44:43 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:07:01 +00:00 (Migrated from github.com)

Done

Done
ridv commented 2019-11-19 03:50:51 +00:00 (Migrated from github.com)

Why not use string.join([]string{...}, "") ?

Why not use `string.join([]string{...}, "")` ?
balandi1 commented 2019-11-20 18:52:16 +00:00 (Migrated from github.com)

Yeah, thats right

Yeah, thats right
pradykaushik commented 2019-11-21 01:10:18 +00:00 (Migrated from github.com)

Extend the comment to show how the format of the log directory name is going to look.

Extend the comment to show how the format of the log directory name is going to look.
pradykaushik commented 2019-11-21 01:19:20 +00:00 (Migrated from github.com)

Keep the alias for logrus import consistent. So, refactor this to "log".

Keep the alias for logrus import consistent. So, refactor this to "log".
balandi1 commented 2019-11-26 17:44:43 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:07:01 +00:00 (Migrated from github.com)

Done

Done

View file

@ -1,11 +1,11 @@
pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`
pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`
package elektronLogging
import (
"time"
pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`
"fmt"
pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`
"strconv"
pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`
. "github.com/spdfg/elektron/elektronLogging/types"
pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`
"fmt"
pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`
log "github.com/sirupsen/logrus"
. "github.com/spdfg/elektron/elektronLogging/types"
pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`
"strconv"
pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`
"time"
pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`
)
var config LoggerConfig
@ -14,25 +14,25 @@ var formatter ElektronFormatter
pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`
pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`
func BuildLogger() *LoggerImpl {
// read configuration from yaml
pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`
// read configuration from yaml
pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`
config.GetConfig()
pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`
// create the log directory
pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`
pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`
// create the log directory
pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`
startTime := time.Now()
formatter.TimestampFormat = "2006-01-02 15:04:05"
GetLogDir(startTime, "_")
prefix := fmt.Sprintf("_%d%d%s%s%s%s",startTime.Year(), startTime.Month(),strconv.Itoa(startTime.Day()),
pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`
strconv.Itoa(startTime.Hour()),strconv.Itoa(startTime.Minute()),strconv.Itoa(startTime.Second()))
pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`
pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`
//create a single logrus instance and set its formatter to ElektronFormatter
pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`
prefix := fmt.Sprintf("_%d%d%s%s%s%s", startTime.Year(), startTime.Month(), strconv.Itoa(startTime.Day()),
pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`
strconv.Itoa(startTime.Hour()), strconv.Itoa(startTime.Minute()), strconv.Itoa(startTime.Second()))
pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`
pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`
//create a single logrus instance and set its formatter to ElektronFormatter
pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`
logger = log.New()
logger.SetFormatter(&formatter)
// create a chain of loggers
pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`
// create a chain of loggers
pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`
head := new(LoggerImpl)
cLog := NewConsoleLogger(CONSOLE,prefix)
pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`
pLog := NewPcpLogger(PCP,prefix)
pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`
cLog := NewConsoleLogger(CONSOLE, prefix)
pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`
pLog := NewPcpLogger(PCP, prefix)
pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`
schedTraceLog := NewSchedTraceLogger(SCHED_TRACE, prefix)
spsLog := NewSchedPolicySwitchLogger(SPS, prefix)
schedWindowLog := NewSchedWindowLogger(SCHED_WINDOW, prefix)

pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`
pradykaushik commented 2019-11-21 01:22:14 +00:00 (Migrated from github.com)

Logger and Log are synonyms and therefore should not be used interchangeably.

Logger and Log are synonyms and therefore should not be used interchangeably.
pradykaushik commented 2019-11-21 01:23:28 +00:00 (Migrated from github.com)

Comments should start with capital letters and should end with a full stop.

Comments should start with capital letters and should end with a full stop.
pradykaushik commented 2019-11-21 01:26:47 +00:00 (Migrated from github.com)

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the -logPrefix flag.

The second argument to GetLogDir() is a prefix. How is "_" a prefix? This is probably why the log directory name is not ending up prefixed with the one specified with the `-logPrefix` flag.
pradykaushik commented 2019-11-21 01:33:09 +00:00 (Migrated from github.com)

What is the rationale behind having a dummy node as the head of the chain?

What is the rationale behind having a dummy node as the head of the chain?
balandi1 commented 2019-11-26 17:44:22 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 18:53:15 +00:00 (Migrated from github.com)

Nothing specific. I had kept ElektronLog as LoggerImpl type. But I have changed to ConsoleLogger rather. Works fine now

Nothing specific. I had kept `ElektronLog` as `LoggerImpl` type. But I have changed to `ConsoleLogger` rather. Works fine now
balandi1 commented 2019-11-26 18:58:23 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 19:05:09 +00:00 (Migrated from github.com)

Changed ElektronLog to ElektronLogger

Changed `ElektronLog` to `ElektronLogger`

View file

@ -12,10 +12,10 @@ type Logger interface {
ridv commented 2019-11-19 03:52:10 +00:00 (Migrated from github.com)

If the code isn't needed it shouldn't be left here. If the commented out code is still needed there should be some justification for it still being here.

If the code isn't needed it shouldn't be left here. If the commented out code is still needed there should be some justification for it still being here.
balandi1 commented 2019-11-20 18:52:44 +00:00 (Migrated from github.com)

Okay. Will remove the unnecessary code

Okay. Will remove the unnecessary code
pradykaushik commented 2019-11-21 02:36:05 +00:00 (Migrated from github.com)

As fields are optional, it is better to either have them as the last argument or not have them in the argument list at all.
I would in fact also maintain an internal data structure to store Fields that is cleared only after the log operation passes through the entire chain. You can then add a WithFields(...) method that wraps around logrus.WithFields(...).
I have created this sample code for reference. The sample code also shows how formatted strings are corresponding args can be passed and we can wrap around logrus.Logf(...) for that.

As fields are optional, it is better to either have them as the last argument or not have them in the argument list at all. I would in fact also maintain an internal data structure to store Fields that is cleared only after the log operation passes through the entire chain. You can then add a `WithFields(...)` method that wraps around `logrus.WithFields(...)`. I have created [this sample code](https://play.golang.org/p/RILTxcZtT2w) for reference. The sample code also shows how formatted strings are corresponding args can be passed and we can wrap around `logrus.Logf(...)` for that.
pradykaushik commented 2019-11-21 02:51:18 +00:00 (Migrated from github.com)

Refactor to LogFile as it is a pointer to os.File and not string.

Refactor to `LogFile` as it is a pointer to os.File and not string.
balandi1 commented 2019-11-26 17:46:53 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-12-04 18:18:20 +00:00 (Migrated from github.com)

Done

Done
ridv commented 2019-11-19 03:52:10 +00:00 (Migrated from github.com)

If the code isn't needed it shouldn't be left here. If the commented out code is still needed there should be some justification for it still being here.

If the code isn't needed it shouldn't be left here. If the commented out code is still needed there should be some justification for it still being here.
balandi1 commented 2019-11-20 18:52:44 +00:00 (Migrated from github.com)

Okay. Will remove the unnecessary code

Okay. Will remove the unnecessary code
pradykaushik commented 2019-11-21 02:36:05 +00:00 (Migrated from github.com)

As fields are optional, it is better to either have them as the last argument or not have them in the argument list at all.
I would in fact also maintain an internal data structure to store Fields that is cleared only after the log operation passes through the entire chain. You can then add a WithFields(...) method that wraps around logrus.WithFields(...).
I have created this sample code for reference. The sample code also shows how formatted strings are corresponding args can be passed and we can wrap around logrus.Logf(...) for that.

As fields are optional, it is better to either have them as the last argument or not have them in the argument list at all. I would in fact also maintain an internal data structure to store Fields that is cleared only after the log operation passes through the entire chain. You can then add a `WithFields(...)` method that wraps around `logrus.WithFields(...)`. I have created [this sample code](https://play.golang.org/p/RILTxcZtT2w) for reference. The sample code also shows how formatted strings are corresponding args can be passed and we can wrap around `logrus.Logf(...)` for that.
pradykaushik commented 2019-11-21 02:51:18 +00:00 (Migrated from github.com)

Refactor to LogFile as it is a pointer to os.File and not string.

Refactor to `LogFile` as it is a pointer to os.File and not string.
balandi1 commented 2019-11-26 17:46:53 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-12-04 18:18:20 +00:00 (Migrated from github.com)

Done

Done
SetLogFile(prefix string)
}
type LoggerImpl struct {
Type int
ridv commented 2019-11-19 03:52:10 +00:00 (Migrated from github.com)

If the code isn't needed it shouldn't be left here. If the commented out code is still needed there should be some justification for it still being here.

If the code isn't needed it shouldn't be left here. If the commented out code is still needed there should be some justification for it still being here.
balandi1 commented 2019-11-20 18:52:44 +00:00 (Migrated from github.com)

Okay. Will remove the unnecessary code

Okay. Will remove the unnecessary code
pradykaushik commented 2019-11-21 02:36:05 +00:00 (Migrated from github.com)

As fields are optional, it is better to either have them as the last argument or not have them in the argument list at all.
I would in fact also maintain an internal data structure to store Fields that is cleared only after the log operation passes through the entire chain. You can then add a WithFields(...) method that wraps around logrus.WithFields(...).
I have created this sample code for reference. The sample code also shows how formatted strings are corresponding args can be passed and we can wrap around logrus.Logf(...) for that.

As fields are optional, it is better to either have them as the last argument or not have them in the argument list at all. I would in fact also maintain an internal data structure to store Fields that is cleared only after the log operation passes through the entire chain. You can then add a `WithFields(...)` method that wraps around `logrus.WithFields(...)`. I have created [this sample code](https://play.golang.org/p/RILTxcZtT2w) for reference. The sample code also shows how formatted strings are corresponding args can be passed and we can wrap around `logrus.Logf(...)` for that.
pradykaushik commented 2019-11-21 02:51:18 +00:00 (Migrated from github.com)

Refactor to LogFile as it is a pointer to os.File and not string.

Refactor to `LogFile` as it is a pointer to os.File and not string.
balandi1 commented 2019-11-26 17:46:53 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-12-04 18:18:20 +00:00 (Migrated from github.com)

Done

Done
AllowOnConsole bool
ridv commented 2019-11-19 03:52:10 +00:00 (Migrated from github.com)

If the code isn't needed it shouldn't be left here. If the commented out code is still needed there should be some justification for it still being here.

If the code isn't needed it shouldn't be left here. If the commented out code is still needed there should be some justification for it still being here.
balandi1 commented 2019-11-20 18:52:44 +00:00 (Migrated from github.com)

Okay. Will remove the unnecessary code

Okay. Will remove the unnecessary code
pradykaushik commented 2019-11-21 02:36:05 +00:00 (Migrated from github.com)

As fields are optional, it is better to either have them as the last argument or not have them in the argument list at all.
I would in fact also maintain an internal data structure to store Fields that is cleared only after the log operation passes through the entire chain. You can then add a WithFields(...) method that wraps around logrus.WithFields(...).
I have created this sample code for reference. The sample code also shows how formatted strings are corresponding args can be passed and we can wrap around logrus.Logf(...) for that.

As fields are optional, it is better to either have them as the last argument or not have them in the argument list at all. I would in fact also maintain an internal data structure to store Fields that is cleared only after the log operation passes through the entire chain. You can then add a `WithFields(...)` method that wraps around `logrus.WithFields(...)`. I have created [this sample code](https://play.golang.org/p/RILTxcZtT2w) for reference. The sample code also shows how formatted strings are corresponding args can be passed and we can wrap around `logrus.Logf(...)` for that.
pradykaushik commented 2019-11-21 02:51:18 +00:00 (Migrated from github.com)

Refactor to LogFile as it is a pointer to os.File and not string.

Refactor to `LogFile` as it is a pointer to os.File and not string.
balandi1 commented 2019-11-26 17:46:53 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-12-04 18:18:20 +00:00 (Migrated from github.com)

Done

Done
LogFileName *os.File
ridv commented 2019-11-19 03:52:10 +00:00 (Migrated from github.com)

If the code isn't needed it shouldn't be left here. If the commented out code is still needed there should be some justification for it still being here.

If the code isn't needed it shouldn't be left here. If the commented out code is still needed there should be some justification for it still being here.
balandi1 commented 2019-11-20 18:52:44 +00:00 (Migrated from github.com)

Okay. Will remove the unnecessary code

Okay. Will remove the unnecessary code
pradykaushik commented 2019-11-21 02:36:05 +00:00 (Migrated from github.com)

As fields are optional, it is better to either have them as the last argument or not have them in the argument list at all.
I would in fact also maintain an internal data structure to store Fields that is cleared only after the log operation passes through the entire chain. You can then add a WithFields(...) method that wraps around logrus.WithFields(...).
I have created this sample code for reference. The sample code also shows how formatted strings are corresponding args can be passed and we can wrap around logrus.Logf(...) for that.

As fields are optional, it is better to either have them as the last argument or not have them in the argument list at all. I would in fact also maintain an internal data structure to store Fields that is cleared only after the log operation passes through the entire chain. You can then add a `WithFields(...)` method that wraps around `logrus.WithFields(...)`. I have created [this sample code](https://play.golang.org/p/RILTxcZtT2w) for reference. The sample code also shows how formatted strings are corresponding args can be passed and we can wrap around `logrus.Logf(...)` for that.
pradykaushik commented 2019-11-21 02:51:18 +00:00 (Migrated from github.com)

Refactor to LogFile as it is a pointer to os.File and not string.

Refactor to `LogFile` as it is a pointer to os.File and not string.
balandi1 commented 2019-11-26 17:46:53 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-12-04 18:18:20 +00:00 (Migrated from github.com)

Done

Done
next Logger
ridv commented 2019-11-19 03:52:10 +00:00 (Migrated from github.com)

If the code isn't needed it shouldn't be left here. If the commented out code is still needed there should be some justification for it still being here.

If the code isn't needed it shouldn't be left here. If the commented out code is still needed there should be some justification for it still being here.
balandi1 commented 2019-11-20 18:52:44 +00:00 (Migrated from github.com)

Okay. Will remove the unnecessary code

Okay. Will remove the unnecessary code
pradykaushik commented 2019-11-21 02:36:05 +00:00 (Migrated from github.com)

As fields are optional, it is better to either have them as the last argument or not have them in the argument list at all.
I would in fact also maintain an internal data structure to store Fields that is cleared only after the log operation passes through the entire chain. You can then add a WithFields(...) method that wraps around logrus.WithFields(...).
I have created this sample code for reference. The sample code also shows how formatted strings are corresponding args can be passed and we can wrap around logrus.Logf(...) for that.

As fields are optional, it is better to either have them as the last argument or not have them in the argument list at all. I would in fact also maintain an internal data structure to store Fields that is cleared only after the log operation passes through the entire chain. You can then add a `WithFields(...)` method that wraps around `logrus.WithFields(...)`. I have created [this sample code](https://play.golang.org/p/RILTxcZtT2w) for reference. The sample code also shows how formatted strings are corresponding args can be passed and we can wrap around `logrus.Logf(...)` for that.
pradykaushik commented 2019-11-21 02:51:18 +00:00 (Migrated from github.com)

Refactor to LogFile as it is a pointer to os.File and not string.

Refactor to `LogFile` as it is a pointer to os.File and not string.
balandi1 commented 2019-11-26 17:46:53 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-12-04 18:18:20 +00:00 (Migrated from github.com)

Done

Done
Type int
ridv commented 2019-11-19 03:52:10 +00:00 (Migrated from github.com)

If the code isn't needed it shouldn't be left here. If the commented out code is still needed there should be some justification for it still being here.

If the code isn't needed it shouldn't be left here. If the commented out code is still needed there should be some justification for it still being here.
balandi1 commented 2019-11-20 18:52:44 +00:00 (Migrated from github.com)

Okay. Will remove the unnecessary code

Okay. Will remove the unnecessary code
pradykaushik commented 2019-11-21 02:36:05 +00:00 (Migrated from github.com)

As fields are optional, it is better to either have them as the last argument or not have them in the argument list at all.
I would in fact also maintain an internal data structure to store Fields that is cleared only after the log operation passes through the entire chain. You can then add a WithFields(...) method that wraps around logrus.WithFields(...).
I have created this sample code for reference. The sample code also shows how formatted strings are corresponding args can be passed and we can wrap around logrus.Logf(...) for that.

As fields are optional, it is better to either have them as the last argument or not have them in the argument list at all. I would in fact also maintain an internal data structure to store Fields that is cleared only after the log operation passes through the entire chain. You can then add a `WithFields(...)` method that wraps around `logrus.WithFields(...)`. I have created [this sample code](https://play.golang.org/p/RILTxcZtT2w) for reference. The sample code also shows how formatted strings are corresponding args can be passed and we can wrap around `logrus.Logf(...)` for that.
pradykaushik commented 2019-11-21 02:51:18 +00:00 (Migrated from github.com)

Refactor to LogFile as it is a pointer to os.File and not string.

Refactor to `LogFile` as it is a pointer to os.File and not string.
balandi1 commented 2019-11-26 17:46:53 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-12-04 18:18:20 +00:00 (Migrated from github.com)

Done

Done
AllowOnConsole bool
ridv commented 2019-11-19 03:52:10 +00:00 (Migrated from github.com)

If the code isn't needed it shouldn't be left here. If the commented out code is still needed there should be some justification for it still being here.

If the code isn't needed it shouldn't be left here. If the commented out code is still needed there should be some justification for it still being here.
balandi1 commented 2019-11-20 18:52:44 +00:00 (Migrated from github.com)

Okay. Will remove the unnecessary code

Okay. Will remove the unnecessary code
pradykaushik commented 2019-11-21 02:36:05 +00:00 (Migrated from github.com)

As fields are optional, it is better to either have them as the last argument or not have them in the argument list at all.
I would in fact also maintain an internal data structure to store Fields that is cleared only after the log operation passes through the entire chain. You can then add a WithFields(...) method that wraps around logrus.WithFields(...).
I have created this sample code for reference. The sample code also shows how formatted strings are corresponding args can be passed and we can wrap around logrus.Logf(...) for that.

As fields are optional, it is better to either have them as the last argument or not have them in the argument list at all. I would in fact also maintain an internal data structure to store Fields that is cleared only after the log operation passes through the entire chain. You can then add a `WithFields(...)` method that wraps around `logrus.WithFields(...)`. I have created [this sample code](https://play.golang.org/p/RILTxcZtT2w) for reference. The sample code also shows how formatted strings are corresponding args can be passed and we can wrap around `logrus.Logf(...)` for that.
pradykaushik commented 2019-11-21 02:51:18 +00:00 (Migrated from github.com)

Refactor to LogFile as it is a pointer to os.File and not string.

Refactor to `LogFile` as it is a pointer to os.File and not string.
balandi1 commented 2019-11-26 17:46:53 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-12-04 18:18:20 +00:00 (Migrated from github.com)

Done

Done
LogFileName *os.File
ridv commented 2019-11-19 03:52:10 +00:00 (Migrated from github.com)

If the code isn't needed it shouldn't be left here. If the commented out code is still needed there should be some justification for it still being here.

If the code isn't needed it shouldn't be left here. If the commented out code is still needed there should be some justification for it still being here.
balandi1 commented 2019-11-20 18:52:44 +00:00 (Migrated from github.com)

Okay. Will remove the unnecessary code

Okay. Will remove the unnecessary code
pradykaushik commented 2019-11-21 02:36:05 +00:00 (Migrated from github.com)

As fields are optional, it is better to either have them as the last argument or not have them in the argument list at all.
I would in fact also maintain an internal data structure to store Fields that is cleared only after the log operation passes through the entire chain. You can then add a WithFields(...) method that wraps around logrus.WithFields(...).
I have created this sample code for reference. The sample code also shows how formatted strings are corresponding args can be passed and we can wrap around logrus.Logf(...) for that.

As fields are optional, it is better to either have them as the last argument or not have them in the argument list at all. I would in fact also maintain an internal data structure to store Fields that is cleared only after the log operation passes through the entire chain. You can then add a `WithFields(...)` method that wraps around `logrus.WithFields(...)`. I have created [this sample code](https://play.golang.org/p/RILTxcZtT2w) for reference. The sample code also shows how formatted strings are corresponding args can be passed and we can wrap around `logrus.Logf(...)` for that.
pradykaushik commented 2019-11-21 02:51:18 +00:00 (Migrated from github.com)

Refactor to LogFile as it is a pointer to os.File and not string.

Refactor to `LogFile` as it is a pointer to os.File and not string.
balandi1 commented 2019-11-26 17:46:53 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-12-04 18:18:20 +00:00 (Migrated from github.com)

Done

Done
next Logger
ridv commented 2019-11-19 03:52:10 +00:00 (Migrated from github.com)

If the code isn't needed it shouldn't be left here. If the commented out code is still needed there should be some justification for it still being here.

If the code isn't needed it shouldn't be left here. If the commented out code is still needed there should be some justification for it still being here.
balandi1 commented 2019-11-20 18:52:44 +00:00 (Migrated from github.com)

Okay. Will remove the unnecessary code

Okay. Will remove the unnecessary code
pradykaushik commented 2019-11-21 02:36:05 +00:00 (Migrated from github.com)

As fields are optional, it is better to either have them as the last argument or not have them in the argument list at all.
I would in fact also maintain an internal data structure to store Fields that is cleared only after the log operation passes through the entire chain. You can then add a WithFields(...) method that wraps around logrus.WithFields(...).
I have created this sample code for reference. The sample code also shows how formatted strings are corresponding args can be passed and we can wrap around logrus.Logf(...) for that.

As fields are optional, it is better to either have them as the last argument or not have them in the argument list at all. I would in fact also maintain an internal data structure to store Fields that is cleared only after the log operation passes through the entire chain. You can then add a `WithFields(...)` method that wraps around `logrus.WithFields(...)`. I have created [this sample code](https://play.golang.org/p/RILTxcZtT2w) for reference. The sample code also shows how formatted strings are corresponding args can be passed and we can wrap around `logrus.Logf(...)` for that.
pradykaushik commented 2019-11-21 02:51:18 +00:00 (Migrated from github.com)

Refactor to LogFile as it is a pointer to os.File and not string.

Refactor to `LogFile` as it is a pointer to os.File and not string.
balandi1 commented 2019-11-26 17:46:53 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-12-04 18:18:20 +00:00 (Migrated from github.com)

Done

Done
}
func (l *LoggerImpl) SetNext(logType Logger) {

ridv commented 2019-11-19 03:52:10 +00:00 (Migrated from github.com)

If the code isn't needed it shouldn't be left here. If the commented out code is still needed there should be some justification for it still being here.

If the code isn't needed it shouldn't be left here. If the commented out code is still needed there should be some justification for it still being here.
balandi1 commented 2019-11-20 18:52:44 +00:00 (Migrated from github.com)

Okay. Will remove the unnecessary code

Okay. Will remove the unnecessary code
pradykaushik commented 2019-11-21 02:36:05 +00:00 (Migrated from github.com)

As fields are optional, it is better to either have them as the last argument or not have them in the argument list at all.
I would in fact also maintain an internal data structure to store Fields that is cleared only after the log operation passes through the entire chain. You can then add a WithFields(...) method that wraps around logrus.WithFields(...).
I have created this sample code for reference. The sample code also shows how formatted strings are corresponding args can be passed and we can wrap around logrus.Logf(...) for that.

As fields are optional, it is better to either have them as the last argument or not have them in the argument list at all. I would in fact also maintain an internal data structure to store Fields that is cleared only after the log operation passes through the entire chain. You can then add a `WithFields(...)` method that wraps around `logrus.WithFields(...)`. I have created [this sample code](https://play.golang.org/p/RILTxcZtT2w) for reference. The sample code also shows how formatted strings are corresponding args can be passed and we can wrap around `logrus.Logf(...)` for that.
pradykaushik commented 2019-11-21 02:51:18 +00:00 (Migrated from github.com)

Refactor to LogFile as it is a pointer to os.File and not string.

Refactor to `LogFile` as it is a pointer to os.File and not string.
balandi1 commented 2019-11-26 17:46:53 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-12-04 18:18:20 +00:00 (Migrated from github.com)

Done

Done
ridv commented 2019-11-19 03:52:10 +00:00 (Migrated from github.com)

If the code isn't needed it shouldn't be left here. If the commented out code is still needed there should be some justification for it still being here.

If the code isn't needed it shouldn't be left here. If the commented out code is still needed there should be some justification for it still being here.
balandi1 commented 2019-11-20 18:52:44 +00:00 (Migrated from github.com)

Okay. Will remove the unnecessary code

Okay. Will remove the unnecessary code
pradykaushik commented 2019-11-21 02:36:05 +00:00 (Migrated from github.com)

As fields are optional, it is better to either have them as the last argument or not have them in the argument list at all.
I would in fact also maintain an internal data structure to store Fields that is cleared only after the log operation passes through the entire chain. You can then add a WithFields(...) method that wraps around logrus.WithFields(...).
I have created this sample code for reference. The sample code also shows how formatted strings are corresponding args can be passed and we can wrap around logrus.Logf(...) for that.

As fields are optional, it is better to either have them as the last argument or not have them in the argument list at all. I would in fact also maintain an internal data structure to store Fields that is cleared only after the log operation passes through the entire chain. You can then add a `WithFields(...)` method that wraps around `logrus.WithFields(...)`. I have created [this sample code](https://play.golang.org/p/RILTxcZtT2w) for reference. The sample code also shows how formatted strings are corresponding args can be passed and we can wrap around `logrus.Logf(...)` for that.
pradykaushik commented 2019-11-21 02:51:18 +00:00 (Migrated from github.com)

Refactor to LogFile as it is a pointer to os.File and not string.

Refactor to `LogFile` as it is a pointer to os.File and not string.
balandi1 commented 2019-11-26 17:46:53 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-12-04 18:18:20 +00:00 (Migrated from github.com)

Done

Done

View file

@ -1,68 +1,68 @@
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
package elektronLogging
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
import (
"gopkg.in/yaml.v2"
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
"io/ioutil"
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
log "github.com/sirupsen/logrus"
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
elekEnv "github.com/spdfg/elektron/environment"
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
log "github.com/sirupsen/logrus"
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
elekEnv "github.com/spdfg/elektron/environment"
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
"gopkg.in/yaml.v2"
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
"io/ioutil"
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
)
type LoggerConfig struct {
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
SchedTraceConfig struct {
Enabled bool `yaml:"enabled"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
FilenameExtension string `yaml:"filenameExtension"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
EnableColumnHeaders bool `yaml:"enableColumnHeaders"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
AllowOnConsole bool `yaml:"allowOnConsole"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
Enabled bool `yaml:"enabled"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
FilenameExtension string `yaml:"filenameExtension"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
EnableColumnHeaders bool `yaml:"enableColumnHeaders"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
AllowOnConsole bool `yaml:"allowOnConsole"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
} `yaml:"schedTrace"`
PCPConfig struct {
Enabled bool `yaml:"enabled"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
FilenameExtension string `yaml:"filenameExtension"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
EnableColumnHeaders bool `yaml:"enableColumnHeaders"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
AllowOnConsole bool `yaml:"allowOnConsole"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
Enabled bool `yaml:"enabled"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
FilenameExtension string `yaml:"filenameExtension"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
EnableColumnHeaders bool `yaml:"enableColumnHeaders"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
AllowOnConsole bool `yaml:"allowOnConsole"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
} `yaml:"pcp"`
ConsoleConfig struct {
Enabled bool `yaml:"enabled"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
FilenameExtension string `yaml:"filenameExtension"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
EnableColumnHeaders bool `yaml:"enableColumnHeaders"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
MinLogLevel string `yaml:"minLogLevel"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
Enabled bool `yaml:"enabled"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
FilenameExtension string `yaml:"filenameExtension"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
EnableColumnHeaders bool `yaml:"enableColumnHeaders"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
MinLogLevel string `yaml:"minLogLevel"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
} `yaml:"console"`
SPSConfig struct {
Enabled bool `yaml:"enabled"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
FilenameExtension string `yaml:"filenameExtension"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
EnableColumnHeaders bool `yaml:"enableColumnHeaders"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
AllowOnConsole bool `yaml:"allowOnConsole"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
Enabled bool `yaml:"enabled"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
FilenameExtension string `yaml:"filenameExtension"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
EnableColumnHeaders bool `yaml:"enableColumnHeaders"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
AllowOnConsole bool `yaml:"allowOnConsole"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
} `yaml:"sps"`
TaskDistConfig struct {
Enabled bool `yaml:"enabled"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
FilenameExtension string `yaml:"filenameExtension"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
EnableColumnHeaders bool `yaml:"enableColumnHeaders"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
AllowOnConsole bool `yaml:"allowOnConsole"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
Enabled bool `yaml:"enabled"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
FilenameExtension string `yaml:"filenameExtension"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
EnableColumnHeaders bool `yaml:"enableColumnHeaders"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
AllowOnConsole bool `yaml:"allowOnConsole"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
} `yaml:"clsfnTaskDistOverhead"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
SchedWindowConfig struct {
Enabled bool `yaml:"enabled"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
FilenameExtension string `yaml:"filenameExtension"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
EnableColumnHeaders bool `yaml:"enableColumnHeaders"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
AllowOnConsole bool `yaml:"allowOnConsole"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
Enabled bool `yaml:"enabled"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
FilenameExtension string `yaml:"filenameExtension"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
EnableColumnHeaders bool `yaml:"enableColumnHeaders"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
AllowOnConsole bool `yaml:"allowOnConsole"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
} `yaml:"schedWindow"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
Format[] string `yaml:"format"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
Format []string `yaml:"format"`
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
}
func (c *LoggerConfig) GetConfig() *LoggerConfig {
yamlFile, err := ioutil.ReadFile(elekEnv.LogConfigYaml)
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
if err != nil {
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
log.Printf("yamlFile.Get err #%v ", err)
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
}
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
err = yaml.Unmarshal(yamlFile, c)
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
if err != nil {
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
log.Fatalf("Unmarshal: %v", err)
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
}
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
yamlFile, err := ioutil.ReadFile(elekEnv.LogConfigYaml)
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
if err != nil {
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
log.Printf("yamlFile.Get err #%v ", err)
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
}
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
err = yaml.Unmarshal(yamlFile, c)
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
if err != nil {
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
log.Fatalf("Unmarshal: %v", err)
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
}
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
return c
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
return c
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
}

pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 02:43:54 +00:00 (Migrated from github.com)

Are column headers being added if enabled?

Are column headers being added if enabled?
pradykaushik commented 2019-11-21 02:45:05 +00:00 (Migrated from github.com)

Refactor to TaskDistrConfig for semantics.

Refactor to TaskDistrConfig for semantics.
pradykaushik commented 2019-11-21 02:45:19 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2019-11-21 02:47:43 +00:00 (Migrated from github.com)

The error message does not do justice in indicating the reason for the error.

The error message does not do justice in indicating the reason for the error.
pradykaushik commented 2019-11-21 02:47:53 +00:00 (Migrated from github.com)

ditto.

ditto.
balandi1 commented 2019-11-26 17:08:06 +00:00 (Migrated from github.com)

That was for future purpose. But I have removed it now

That was for future purpose. But I have removed it now
balandi1 commented 2019-11-26 17:45:42 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:45:56 +00:00 (Migrated from github.com)

Done

Done
balandi1 commented 2019-11-26 17:46:29 +00:00 (Migrated from github.com)

Changed the error message

Changed the error message
balandi1 commented 2019-11-26 17:46:41 +00:00 (Migrated from github.com)

Done

Done

View file

@ -1,8 +1,8 @@
pradykaushik commented 2019-11-21 02:51:27 +00:00 (Migrated from github.com)

Refactor to PCPLogger.

Refactor to `PCPLogger`.
pradykaushik commented 2019-11-21 02:56:21 +00:00 (Migrated from github.com)

Why not just do this?

return &PCPLogger{ 
    LoggerIml{
        Type: logType
        LogFile: CreateLogFile(prefix),
    }
}

Where func CreateLogFile(prefix string) string replaces func SetLogFile(prefix string).

Why not just do this? ```go return &PCPLogger{ LoggerIml{ Type: logType LogFile: CreateLogFile(prefix), } } ``` Where `func CreateLogFile(prefix string) string` replaces `func SetLogFile(prefix string)`.
balandi1 commented 2019-11-26 17:47:03 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 02:51:27 +00:00 (Migrated from github.com)

Refactor to PCPLogger.

Refactor to `PCPLogger`.
pradykaushik commented 2019-11-21 02:56:21 +00:00 (Migrated from github.com)

Why not just do this?

return &PCPLogger{ 
    LoggerIml{
        Type: logType
        LogFile: CreateLogFile(prefix),
    }
}

Where func CreateLogFile(prefix string) string replaces func SetLogFile(prefix string).

Why not just do this? ```go return &PCPLogger{ LoggerIml{ Type: logType LogFile: CreateLogFile(prefix), } } ``` Where `func CreateLogFile(prefix string) string` replaces `func SetLogFile(prefix string)`.
balandi1 commented 2019-11-26 17:47:03 +00:00 (Migrated from github.com)

Done

Done
package elektronLogging
import (
"os"
pradykaushik commented 2019-11-21 02:51:27 +00:00 (Migrated from github.com)

Refactor to PCPLogger.

Refactor to `PCPLogger`.
pradykaushik commented 2019-11-21 02:56:21 +00:00 (Migrated from github.com)

Why not just do this?

return &PCPLogger{ 
    LoggerIml{
        Type: logType
        LogFile: CreateLogFile(prefix),
    }
}

Where func CreateLogFile(prefix string) string replaces func SetLogFile(prefix string).

Why not just do this? ```go return &PCPLogger{ LoggerIml{ Type: logType LogFile: CreateLogFile(prefix), } } ``` Where `func CreateLogFile(prefix string) string` replaces `func SetLogFile(prefix string)`.
balandi1 commented 2019-11-26 17:47:03 +00:00 (Migrated from github.com)

Done

Done
log "github.com/sirupsen/logrus"
"os"
pradykaushik commented 2019-11-21 02:51:27 +00:00 (Migrated from github.com)

Refactor to PCPLogger.

Refactor to `PCPLogger`.
pradykaushik commented 2019-11-21 02:56:21 +00:00 (Migrated from github.com)

Why not just do this?

return &PCPLogger{ 
    LoggerIml{
        Type: logType
        LogFile: CreateLogFile(prefix),
    }
}

Where func CreateLogFile(prefix string) string replaces func SetLogFile(prefix string).

Why not just do this? ```go return &PCPLogger{ LoggerIml{ Type: logType LogFile: CreateLogFile(prefix), } } ``` Where `func CreateLogFile(prefix string) string` replaces `func SetLogFile(prefix string)`.
balandi1 commented 2019-11-26 17:47:03 +00:00 (Migrated from github.com)

Done

Done
)
type PcpLogger struct {
@ -20,11 +20,11 @@ func (pLog *PcpLogger) Log(logType int, level log.Level, logData log.Fields, mes
pradykaushik commented 2019-11-21 02:51:27 +00:00 (Migrated from github.com)

Refactor to PCPLogger.

Refactor to `PCPLogger`.
pradykaushik commented 2019-11-21 02:56:21 +00:00 (Migrated from github.com)

Why not just do this?

return &PCPLogger{ 
    LoggerIml{
        Type: logType
        LogFile: CreateLogFile(prefix),
    }
}

Where func CreateLogFile(prefix string) string replaces func SetLogFile(prefix string).

Why not just do this? ```go return &PCPLogger{ LoggerIml{ Type: logType LogFile: CreateLogFile(prefix), } } ``` Where `func CreateLogFile(prefix string) string` replaces `func SetLogFile(prefix string)`.
balandi1 commented 2019-11-26 17:47:03 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 02:51:27 +00:00 (Migrated from github.com)

Refactor to PCPLogger.

Refactor to `PCPLogger`.
pradykaushik commented 2019-11-21 02:56:21 +00:00 (Migrated from github.com)

Why not just do this?

return &PCPLogger{ 
    LoggerIml{
        Type: logType
        LogFile: CreateLogFile(prefix),
    }
}

Where func CreateLogFile(prefix string) string replaces func SetLogFile(prefix string).

Why not just do this? ```go return &PCPLogger{ LoggerIml{ Type: logType LogFile: CreateLogFile(prefix), } } ``` Where `func CreateLogFile(prefix string) string` replaces `func SetLogFile(prefix string)`.
balandi1 commented 2019-11-26 17:47:03 +00:00 (Migrated from github.com)

Done

Done
if pLog.Type == logType {
logger.SetLevel(level)
pradykaushik commented 2019-11-21 02:51:27 +00:00 (Migrated from github.com)

Refactor to PCPLogger.

Refactor to `PCPLogger`.
pradykaushik commented 2019-11-21 02:56:21 +00:00 (Migrated from github.com)

Why not just do this?

return &PCPLogger{ 
    LoggerIml{
        Type: logType
        LogFile: CreateLogFile(prefix),
    }
}

Where func CreateLogFile(prefix string) string replaces func SetLogFile(prefix string).

Why not just do this? ```go return &PCPLogger{ LoggerIml{ Type: logType LogFile: CreateLogFile(prefix), } } ``` Where `func CreateLogFile(prefix string) string` replaces `func SetLogFile(prefix string)`.
balandi1 commented 2019-11-26 17:47:03 +00:00 (Migrated from github.com)

Done

Done
if pLog.AllowOnConsole {
pradykaushik commented 2019-11-21 02:51:27 +00:00 (Migrated from github.com)

Refactor to PCPLogger.

Refactor to `PCPLogger`.
pradykaushik commented 2019-11-21 02:56:21 +00:00 (Migrated from github.com)

Why not just do this?

return &PCPLogger{ 
    LoggerIml{
        Type: logType
        LogFile: CreateLogFile(prefix),
    }
}

Where func CreateLogFile(prefix string) string replaces func SetLogFile(prefix string).

Why not just do this? ```go return &PCPLogger{ LoggerIml{ Type: logType LogFile: CreateLogFile(prefix), } } ``` Where `func CreateLogFile(prefix string) string` replaces `func SetLogFile(prefix string)`.
balandi1 commented 2019-11-26 17:47:03 +00:00 (Migrated from github.com)

Done

Done
logger.SetOutput(os.Stdout)
pradykaushik commented 2019-11-21 02:51:27 +00:00 (Migrated from github.com)

Refactor to PCPLogger.

Refactor to `PCPLogger`.
pradykaushik commented 2019-11-21 02:56:21 +00:00 (Migrated from github.com)

Why not just do this?

return &PCPLogger{ 
    LoggerIml{
        Type: logType
        LogFile: CreateLogFile(prefix),
    }
}

Where func CreateLogFile(prefix string) string replaces func SetLogFile(prefix string).

Why not just do this? ```go return &PCPLogger{ LoggerIml{ Type: logType LogFile: CreateLogFile(prefix), } } ``` Where `func CreateLogFile(prefix string) string` replaces `func SetLogFile(prefix string)`.
balandi1 commented 2019-11-26 17:47:03 +00:00 (Migrated from github.com)

Done

Done
logger.WithFields(logData).Println(message)
pradykaushik commented 2019-11-21 02:51:27 +00:00 (Migrated from github.com)

Refactor to PCPLogger.

Refactor to `PCPLogger`.
pradykaushik commented 2019-11-21 02:56:21 +00:00 (Migrated from github.com)

Why not just do this?

return &PCPLogger{ 
    LoggerIml{
        Type: logType
        LogFile: CreateLogFile(prefix),
    }
}

Where func CreateLogFile(prefix string) string replaces func SetLogFile(prefix string).

Why not just do this? ```go return &PCPLogger{ LoggerIml{ Type: logType LogFile: CreateLogFile(prefix), } } ``` Where `func CreateLogFile(prefix string) string` replaces `func SetLogFile(prefix string)`.
balandi1 commented 2019-11-26 17:47:03 +00:00 (Migrated from github.com)

Done

Done
}
pradykaushik commented 2019-11-21 02:51:27 +00:00 (Migrated from github.com)

Refactor to PCPLogger.

Refactor to `PCPLogger`.
pradykaushik commented 2019-11-21 02:56:21 +00:00 (Migrated from github.com)

Why not just do this?

return &PCPLogger{ 
    LoggerIml{
        Type: logType
        LogFile: CreateLogFile(prefix),
    }
}

Where func CreateLogFile(prefix string) string replaces func SetLogFile(prefix string).

Why not just do this? ```go return &PCPLogger{ LoggerIml{ Type: logType LogFile: CreateLogFile(prefix), } } ``` Where `func CreateLogFile(prefix string) string` replaces `func SetLogFile(prefix string)`.
balandi1 commented 2019-11-26 17:47:03 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 02:51:27 +00:00 (Migrated from github.com)

Refactor to PCPLogger.

Refactor to `PCPLogger`.
pradykaushik commented 2019-11-21 02:56:21 +00:00 (Migrated from github.com)

Why not just do this?

return &PCPLogger{ 
    LoggerIml{
        Type: logType
        LogFile: CreateLogFile(prefix),
    }
}

Where func CreateLogFile(prefix string) string replaces func SetLogFile(prefix string).

Why not just do this? ```go return &PCPLogger{ LoggerIml{ Type: logType LogFile: CreateLogFile(prefix), } } ``` Where `func CreateLogFile(prefix string) string` replaces `func SetLogFile(prefix string)`.
balandi1 commented 2019-11-26 17:47:03 +00:00 (Migrated from github.com)

Done

Done
if pLog.AllowOnConsole {
pradykaushik commented 2019-11-21 02:51:27 +00:00 (Migrated from github.com)

Refactor to PCPLogger.

Refactor to `PCPLogger`.
pradykaushik commented 2019-11-21 02:56:21 +00:00 (Migrated from github.com)

Why not just do this?

return &PCPLogger{ 
    LoggerIml{
        Type: logType
        LogFile: CreateLogFile(prefix),
    }
}

Where func CreateLogFile(prefix string) string replaces func SetLogFile(prefix string).

Why not just do this? ```go return &PCPLogger{ LoggerIml{ Type: logType LogFile: CreateLogFile(prefix), } } ``` Where `func CreateLogFile(prefix string) string` replaces `func SetLogFile(prefix string)`.
balandi1 commented 2019-11-26 17:47:03 +00:00 (Migrated from github.com)

Done

Done
logger.SetOutput(os.Stdout)
pradykaushik commented 2019-11-21 02:51:27 +00:00 (Migrated from github.com)

Refactor to PCPLogger.

Refactor to `PCPLogger`.
pradykaushik commented 2019-11-21 02:56:21 +00:00 (Migrated from github.com)

Why not just do this?

return &PCPLogger{ 
    LoggerIml{
        Type: logType
        LogFile: CreateLogFile(prefix),
    }
}

Where func CreateLogFile(prefix string) string replaces func SetLogFile(prefix string).

Why not just do this? ```go return &PCPLogger{ LoggerIml{ Type: logType LogFile: CreateLogFile(prefix), } } ``` Where `func CreateLogFile(prefix string) string` replaces `func SetLogFile(prefix string)`.
balandi1 commented 2019-11-26 17:47:03 +00:00 (Migrated from github.com)

Done

Done
logger.WithFields(logData).Println(message)
pradykaushik commented 2019-11-21 02:51:27 +00:00 (Migrated from github.com)

Refactor to PCPLogger.

Refactor to `PCPLogger`.
pradykaushik commented 2019-11-21 02:56:21 +00:00 (Migrated from github.com)

Why not just do this?

return &PCPLogger{ 
    LoggerIml{
        Type: logType
        LogFile: CreateLogFile(prefix),
    }
}

Where func CreateLogFile(prefix string) string replaces func SetLogFile(prefix string).

Why not just do this? ```go return &PCPLogger{ LoggerIml{ Type: logType LogFile: CreateLogFile(prefix), } } ``` Where `func CreateLogFile(prefix string) string` replaces `func SetLogFile(prefix string)`.
balandi1 commented 2019-11-26 17:47:03 +00:00 (Migrated from github.com)

Done

Done
}
pradykaushik commented 2019-11-21 02:51:27 +00:00 (Migrated from github.com)

Refactor to PCPLogger.

Refactor to `PCPLogger`.
pradykaushik commented 2019-11-21 02:56:21 +00:00 (Migrated from github.com)

Why not just do this?

return &PCPLogger{ 
    LoggerIml{
        Type: logType
        LogFile: CreateLogFile(prefix),
    }
}

Where func CreateLogFile(prefix string) string replaces func SetLogFile(prefix string).

Why not just do this? ```go return &PCPLogger{ LoggerIml{ Type: logType LogFile: CreateLogFile(prefix), } } ``` Where `func CreateLogFile(prefix string) string` replaces `func SetLogFile(prefix string)`.
balandi1 commented 2019-11-26 17:47:03 +00:00 (Migrated from github.com)

Done

Done
logger.SetOutput(pLog.LogFileName)
logger.WithFields(logData).Println(message)
@ -44,6 +44,6 @@ func (plog *PcpLogger) SetLogFile(prefix string) {
pradykaushik commented 2019-11-21 02:51:27 +00:00 (Migrated from github.com)

Refactor to PCPLogger.

Refactor to `PCPLogger`.
pradykaushik commented 2019-11-21 02:56:21 +00:00 (Migrated from github.com)

Why not just do this?

return &PCPLogger{ 
    LoggerIml{
        Type: logType
        LogFile: CreateLogFile(prefix),
    }
}

Where func CreateLogFile(prefix string) string replaces func SetLogFile(prefix string).

Why not just do this? ```go return &PCPLogger{ LoggerIml{ Type: logType LogFile: CreateLogFile(prefix), } } ``` Where `func CreateLogFile(prefix string) string` replaces `func SetLogFile(prefix string)`.
balandi1 commented 2019-11-26 17:47:03 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 02:51:27 +00:00 (Migrated from github.com)

Refactor to PCPLogger.

Refactor to `PCPLogger`.
pradykaushik commented 2019-11-21 02:56:21 +00:00 (Migrated from github.com)

Why not just do this?

return &PCPLogger{ 
    LoggerIml{
        Type: logType
        LogFile: CreateLogFile(prefix),
    }
}

Where func CreateLogFile(prefix string) string replaces func SetLogFile(prefix string).

Why not just do this? ```go return &PCPLogger{ LoggerIml{ Type: logType LogFile: CreateLogFile(prefix), } } ``` Where `func CreateLogFile(prefix string) string` replaces `func SetLogFile(prefix string)`.
balandi1 commented 2019-11-26 17:47:03 +00:00 (Migrated from github.com)

Done

Done
log.Fatal("Unable to create logFile: ", err)
} else {
plog.LogFileName = logFile
plog.AllowOnConsole = config.PCPConfig.AllowOnConsole
pradykaushik commented 2019-11-21 02:51:27 +00:00 (Migrated from github.com)

Refactor to PCPLogger.

Refactor to `PCPLogger`.
pradykaushik commented 2019-11-21 02:56:21 +00:00 (Migrated from github.com)

Why not just do this?

return &PCPLogger{ 
    LoggerIml{
        Type: logType
        LogFile: CreateLogFile(prefix),
    }
}

Where func CreateLogFile(prefix string) string replaces func SetLogFile(prefix string).

Why not just do this? ```go return &PCPLogger{ LoggerIml{ Type: logType LogFile: CreateLogFile(prefix), } } ``` Where `func CreateLogFile(prefix string) string` replaces `func SetLogFile(prefix string)`.
balandi1 commented 2019-11-26 17:47:03 +00:00 (Migrated from github.com)

Done

Done
plog.AllowOnConsole = config.PCPConfig.AllowOnConsole
pradykaushik commented 2019-11-21 02:51:27 +00:00 (Migrated from github.com)

Refactor to PCPLogger.

Refactor to `PCPLogger`.
pradykaushik commented 2019-11-21 02:56:21 +00:00 (Migrated from github.com)

Why not just do this?

return &PCPLogger{ 
    LoggerIml{
        Type: logType
        LogFile: CreateLogFile(prefix),
    }
}

Where func CreateLogFile(prefix string) string replaces func SetLogFile(prefix string).

Why not just do this? ```go return &PCPLogger{ LoggerIml{ Type: logType LogFile: CreateLogFile(prefix), } } ``` Where `func CreateLogFile(prefix string) string` replaces `func SetLogFile(prefix string)`.
balandi1 commented 2019-11-26 17:47:03 +00:00 (Migrated from github.com)

Done

Done
}
}

pradykaushik commented 2019-11-21 02:51:27 +00:00 (Migrated from github.com)

Refactor to PCPLogger.

Refactor to `PCPLogger`.
pradykaushik commented 2019-11-21 02:56:21 +00:00 (Migrated from github.com)

Why not just do this?

return &PCPLogger{ 
    LoggerIml{
        Type: logType
        LogFile: CreateLogFile(prefix),
    }
}

Where func CreateLogFile(prefix string) string replaces func SetLogFile(prefix string).

Why not just do this? ```go return &PCPLogger{ LoggerIml{ Type: logType LogFile: CreateLogFile(prefix), } } ``` Where `func CreateLogFile(prefix string) string` replaces `func SetLogFile(prefix string)`.
balandi1 commented 2019-11-26 17:47:03 +00:00 (Migrated from github.com)

Done

Done
pradykaushik commented 2019-11-21 02:51:27 +00:00 (Migrated from github.com)

Refactor to PCPLogger.

Refactor to `PCPLogger`.
pradykaushik commented 2019-11-21 02:56:21 +00:00 (Migrated from github.com)

Why not just do this?

return &PCPLogger{ 
    LoggerIml{
        Type: logType
        LogFile: CreateLogFile(prefix),
    }
}

Where func CreateLogFile(prefix string) string replaces func SetLogFile(prefix string).

Why not just do this? ```go return &PCPLogger{ LoggerIml{ Type: logType LogFile: CreateLogFile(prefix), } } ``` Where `func CreateLogFile(prefix string) string` replaces `func SetLogFile(prefix string)`.
balandi1 commented 2019-11-26 17:47:03 +00:00 (Migrated from github.com)

Done

Done

View file

@ -1,8 +1,8 @@
package elektronLogging
import (
"os"
log "github.com/sirupsen/logrus"
"os"
)
type SchedPolicySwitchLogger struct {
@ -20,11 +20,11 @@ func (sLog *SchedPolicySwitchLogger) Log(logType int, level log.Level, logData l
if sLog.Type == logType {
logger.SetLevel(level)
if sLog.AllowOnConsole {
logger.SetOutput(os.Stdout)
logger.WithFields(logData).Println(message)
}
if sLog.AllowOnConsole {
logger.SetOutput(os.Stdout)
logger.WithFields(logData).Println(message)
}
logger.SetOutput(sLog.LogFileName)
logger.WithFields(logData).Println(message)
@ -44,6 +44,6 @@ func (sLog *SchedPolicySwitchLogger) SetLogFile(prefix string) {
log.Fatal("Unable to create logFile: ", err)
} else {
sLog.LogFileName = logFile
sLog.AllowOnConsole = config.SPSConfig.AllowOnConsole
sLog.AllowOnConsole = config.SPSConfig.AllowOnConsole
}
}

View file

@ -1,8 +1,8 @@
package elektronLogging
import (
"os"
log "github.com/sirupsen/logrus"
"os"
)
type SchedTraceLogger struct {
@ -20,12 +20,12 @@ func (sLog *SchedTraceLogger) Log(logType int, level log.Level, logData log.Fiel
if sLog.Type == logType {
logger.SetLevel(level)
if sLog.AllowOnConsole {
logger.SetOutput(os.Stdout)
logger.WithFields(logData).Println(message)
}
if sLog.AllowOnConsole {
logger.SetOutput(os.Stdout)
logger.WithFields(logData).Println(message)
}
logger.SetOutput(sLog.LogFileName)
logger.WithFields(logData).Println(message)
}
@ -44,6 +44,6 @@ func (sLog *SchedTraceLogger) SetLogFile(prefix string) {
log.Fatal("Unable to create logFile: ", err)
} else {
sLog.LogFileName = logFile
sLog.AllowOnConsole = config.SchedTraceConfig.AllowOnConsole
sLog.AllowOnConsole = config.SchedTraceConfig.AllowOnConsole
}
}

View file

@ -1,8 +1,8 @@
package elektronLogging
import (
"os"
log "github.com/sirupsen/logrus"
"os"
)
type SchedWindowLogger struct {
@ -21,10 +21,10 @@ func (sLog *SchedWindowLogger) Log(logType int, level log.Level, logData log.Fie
logger.SetLevel(level)
if sLog.AllowOnConsole {
logger.SetOutput(os.Stdout)
logger.WithFields(logData).Println(message)
}
logger.SetOutput(os.Stdout)
logger.WithFields(logData).Println(message)
}
logger.SetOutput(sLog.LogFileName)
logger.WithFields(logData).Println(message)
}
@ -43,6 +43,6 @@ func (sLog *SchedWindowLogger) SetLogFile(prefix string) {
log.Fatal("Unable to create logFile: ", err)
} else {
sLog.LogFileName = logFile
sLog.AllowOnConsole = config.SchedWindowConfig.AllowOnConsole
sLog.AllowOnConsole = config.SchedWindowConfig.AllowOnConsole
}
}

View file

@ -1,16 +1,14 @@
package elektronLogging
const (
ERROR = iota
WARNING = iota
GENERAL = iota
SUCCESS = iota
CONSOLE = iota
PCP = iota
SCHED_TRACE = iota
SPS = iota
SCHED_WINDOW = iota
CLSFN_TASKDIST_OVERHEAD = iota
ERROR = iota
WARNING = iota
GENERAL = iota
SUCCESS = iota
CONSOLE = iota
PCP = iota
SCHED_TRACE = iota
SPS = iota
SCHED_WINDOW = iota
CLSFN_TASKDIST_OVERHEAD = iota
)

View file

@ -1,20 +1,20 @@
// Copyright (C) 2018 spdfg
//
//
// This file is part of Elektron.
//
//
// Elektron is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
//
// Elektron is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
//
// You should have received a copy of the GNU General Public License
// along with Elektron. If not, see <http://www.gnu.org/licenses/>.
//
//
package environment

View file

@ -1,20 +1,20 @@
// Copyright (C) 2018 spdfg
//
//
// This file is part of Elektron.
//
//
// Elektron is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
//
// Elektron is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
//
// You should have received a copy of the GNU General Public License
// along with Elektron. If not, see <http://www.gnu.org/licenses/>.
//
//
package pcp
@ -24,12 +24,12 @@ import (
"syscall"
"time"
"github.com/spdfg/elektron/elektronLogging"
log "github.com/sirupsen/logrus"
"github.com/spdfg/elektron/elektronLogging"
elekLogT "github.com/spdfg/elektron/elektronLogging/types"
log "github.com/sirupsen/logrus"
)
func Start(quit chan struct{}, logging *bool,pcpConfigFile string) {
func Start(quit chan struct{}, logging *bool, pcpConfigFile string) {
var pcpCommand string = "pmdumptext -m -l -f '' -t 1.0 -d , -c " + pcpConfigFile
cmd := exec.Command("sh", "-c", pcpCommand)
cmd.SysProcAttr = &syscall.SysProcAttr{Setpgid: true}
@ -47,9 +47,9 @@ func Start(quit chan struct{}, logging *bool,pcpConfigFile string) {
scanner.Scan()
// Write to logfile
elektronLogging.ElektronLog.Log(elekLogT.PCP,
log.InfoLevel,
log.Fields {}, scanner.Text())
elektronLogging.ElektronLog.Log(elekLogT.PCP,
log.InfoLevel,
log.Fields{}, scanner.Text())
// Throw away first set of results
scanner.Scan()
@ -60,18 +60,18 @@ func Start(quit chan struct{}, logging *bool,pcpConfigFile string) {
text := scanner.Text()
if *logging {
elektronLogging.ElektronLog.Log(elekLogT.PCP,
log.InfoLevel,
log.Fields {}, text)
elektronLogging.ElektronLog.Log(elekLogT.PCP,
log.InfoLevel,
log.Fields{}, text)
}
seconds++
}
}(logging)
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields {}, "PCP logging started")
log.Fields{}, "PCP logging started")
if err := cmd.Start(); err != nil {
log.Fatal(err)
@ -81,9 +81,9 @@ func Start(quit chan struct{}, logging *bool,pcpConfigFile string) {
select {
case <-quit:
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields {}, "Stopping PCP logging in 5 seconds")
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields{}, "Stopping PCP logging in 5 seconds")
time.Sleep(5 * time.Second)
// http://stackoverflow.com/questions/22470193/why-wont-go-kill-a-child-process-correctly

View file

@ -1,20 +1,20 @@
// Copyright (C) 2018 spdfg
//
//
// This file is part of Elektron.
//
//
// Elektron is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
//
// Elektron is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
//
// You should have received a copy of the GNU General Public License
// along with Elektron. If not, see <http://www.gnu.org/licenses/>.
//
//
package pcp

View file

@ -1,20 +1,20 @@
// Copyright (C) 2018 spdfg
//
//
// This file is part of Elektron.
//
//
// Elektron is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
//
// Elektron is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
//
// You should have received a copy of the GNU General Public License
// along with Elektron. If not, see <http://www.gnu.org/licenses/>.
//
//
package pcp

View file

@ -1,20 +1,20 @@
// Copyright (C) 2018 spdfg
//
//
// This file is part of Elektron.
//
//
// Elektron is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
//
// Elektron is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
//
// You should have received a copy of the GNU General Public License
// along with Elektron. If not, see <http://www.gnu.org/licenses/>.
//
//
package powerCap
@ -29,14 +29,14 @@ import (
"syscall"
"time"
log "github.com/sirupsen/logrus"
"github.com/spdfg/elektron/elektronLogging"
elekLogT "github.com/spdfg/elektron/elektronLogging/types"
"github.com/spdfg/elektron/pcp"
"github.com/spdfg/elektron/rapl"
"github.com/spdfg/elektron/elektronLogging"
elekLogT "github.com/spdfg/elektron/elektronLogging/types"
log "github.com/sirupsen/logrus"
)
func StartPCPLogAndExtremaDynamicCap(quit chan struct{}, logging *bool, hiThreshold, loThreshold float64,pcpConfigFile string) {
func StartPCPLogAndExtremaDynamicCap(quit chan struct{}, logging *bool, hiThreshold, loThreshold float64, pcpConfigFile string) {
var pcpCommand string = "pmdumptext -m -l -f '' -t 1.0 -d , -c " + pcpConfigFile
cmd := exec.Command("sh", "-c", pcpCommand, pcpConfigFile)
@ -44,8 +44,8 @@ func StartPCPLogAndExtremaDynamicCap(quit chan struct{}, logging *bool, hiThresh
if hiThreshold < loThreshold {
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields {}, "High threshold is lower than low threshold!")
log.InfoLevel,
log.Fields{}, "High threshold is lower than low threshold!")
}
pipe, err := cmd.StdoutPipe()
@ -61,9 +61,9 @@ func StartPCPLogAndExtremaDynamicCap(quit chan struct{}, logging *bool, hiThresh
scanner.Scan()
// Write to logfile
elektronLogging.ElektronLog.Log(elekLogT.PCP,
log.InfoLevel,
log.Fields {}, scanner.Text())
elektronLogging.ElektronLog.Log(elekLogT.PCP,
log.InfoLevel,
log.Fields{}, scanner.Text())
headers := strings.Split(scanner.Text(), ",")
@ -98,17 +98,17 @@ func StartPCPLogAndExtremaDynamicCap(quit chan struct{}, logging *bool, hiThresh
for scanner.Scan() {
if *logging {
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields {}, "Logging PCP...")
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields{}, "Logging PCP...")
text := scanner.Text()
split := strings.Split(text, ",")
elektronLogging.ElektronLog.Log(elekLogT.PCP,
log.InfoLevel,
log.Fields {}, text)
elektronLogging.ElektronLog.Log(elekLogT.PCP,
log.InfoLevel,
log.Fields{}, text)
totalPower := 0.0
for _, powerIndex := range powerIndexes {
@ -119,10 +119,10 @@ func StartPCPLogAndExtremaDynamicCap(quit chan struct{}, logging *bool, hiThresh
powerHistories[host].Value = power
powerHistories[host] = powerHistories[host].Next()
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields {"Host" : fmt.Sprintf("%s",indexToHost[powerIndex]), "Power" : fmt.Sprintf("%f",(power * pcp.RAPLUnits))},
"")
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields{"Host": fmt.Sprintf("%s", indexToHost[powerIndex]), "Power": fmt.Sprintf("%f", (power * pcp.RAPLUnits))},
"")
totalPower += power
}
@ -134,15 +134,15 @@ func StartPCPLogAndExtremaDynamicCap(quit chan struct{}, logging *bool, hiThresh
clusterMean := pcp.AverageClusterPowerHistory(clusterPowerHist)
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields {"Total power" : fmt.Sprintf("%f %d",clusterPower,clusterPowerHist.Len()),
"Sec Avg" : fmt.Sprintf("%f",clusterMean)},
"")
log.InfoLevel,
log.Fields{"Total power": fmt.Sprintf("%f %d", clusterPower, clusterPowerHist.Len()),
"Sec Avg": fmt.Sprintf("%f", clusterMean)},
"")
if clusterMean > hiThreshold {
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields {}, "Need to cap a node")
log.InfoLevel,
log.Fields{}, "Need to cap a node")
// Create statics for all victims and choose one to cap
victims := make([]pcp.Victim, 0, 8)
@ -164,13 +164,13 @@ func StartPCPLogAndExtremaDynamicCap(quit chan struct{}, logging *bool, hiThresh
cappedHosts[victim.Host] = true
orderCapped = append(orderCapped, victim.Host)
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields {"Capping Victim" : fmt.Sprintf("%s",victim.Host),
"Avg. Wattage" : fmt.Sprintf("%f", victim.Watts*pcp.RAPLUnits)}, "")
log.InfoLevel,
log.Fields{"Capping Victim": fmt.Sprintf("%s", victim.Host),
"Avg. Wattage": fmt.Sprintf("%f", victim.Watts*pcp.RAPLUnits)}, "")
if err := rapl.Cap(victim.Host, "rapl", 50); err != nil {
elektronLogging.ElektronLog.Log(elekLogT.ERROR,
log.ErrorLevel,
log.Fields {}, "Error capping host")
log.ErrorLevel,
log.Fields{}, "Error capping host")
}
break // Only cap one machine at at time.
}
@ -185,12 +185,12 @@ func StartPCPLogAndExtremaDynamicCap(quit chan struct{}, logging *bool, hiThresh
// User RAPL package to send uncap.
log.Printf("Uncapping host %s", host)
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields {"Uncapped host" : host}, "")
log.InfoLevel,
log.Fields{"Uncapped host": host}, "")
if err := rapl.Cap(host, "rapl", 100); err != nil {
elektronLogging.ElektronLog.Log(elekLogT.ERROR,
log.ErrorLevel,
log.Fields {}, "Error capping host")
log.ErrorLevel,
log.Fields{}, "Error capping host")
}
}
}
@ -201,8 +201,8 @@ func StartPCPLogAndExtremaDynamicCap(quit chan struct{}, logging *bool, hiThresh
}(logging, hiThreshold, loThreshold)
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields {}, "PCP logging started")
log.InfoLevel,
log.Fields{}, "PCP logging started")
if err := cmd.Start(); err != nil {
log.Fatal(err)
@ -213,8 +213,8 @@ func StartPCPLogAndExtremaDynamicCap(quit chan struct{}, logging *bool, hiThresh
select {
case <-quit:
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields {}, "Stopping PCP logging in 5 seconds")
log.InfoLevel,
log.Fields{}, "Stopping PCP logging in 5 seconds")
time.Sleep(5 * time.Second)
// http://stackoverflow.com/questions/22470193/why-wont-go-kill-a-child-process-correctly

View file

@ -1,20 +1,20 @@
// Copyright (C) 2018 spdfg
//
//
// This file is part of Elektron.
//
//
// Elektron is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
//
// Elektron is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
//
// You should have received a copy of the GNU General Public License
// along with Elektron. If not, see <http://www.gnu.org/licenses/>.
//
//
package powerCap
@ -30,13 +30,13 @@ import (
"syscall"
"time"
log "github.com/sirupsen/logrus"
"github.com/spdfg/elektron/constants"
"github.com/spdfg/elektron/elektronLogging"
elekLogT "github.com/spdfg/elektron/elektronLogging/types"
"github.com/spdfg/elektron/pcp"
"github.com/spdfg/elektron/rapl"
"github.com/spdfg/elektron/utilities"
"github.com/spdfg/elektron/elektronLogging"
elekLogT "github.com/spdfg/elektron/elektronLogging/types"
log "github.com/sirupsen/logrus"
)
func round(num float64) int {
@ -49,7 +49,7 @@ func getNextCapValue(curCapValue float64, precision int) float64 {
return float64(round(curCapValue*output)) / output
}
func StartPCPLogAndProgressiveExtremaCap(quit chan struct{}, logging *bool, hiThreshold, loThreshold float64,pcpConfigFile string) {
func StartPCPLogAndProgressiveExtremaCap(quit chan struct{}, logging *bool, hiThreshold, loThreshold float64, pcpConfigFile string) {
var pcpCommand string = "pmdumptext -m -l -f '' -t 1.0 -d , -c " + pcpConfigFile
cmd := exec.Command("sh", "-c", pcpCommand, pcpConfigFile)
@ -57,8 +57,8 @@ func StartPCPLogAndProgressiveExtremaCap(quit chan struct{}, logging *bool, hiTh
if hiThreshold < loThreshold {
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields {}, "High threshold is lower than low threshold!")
log.InfoLevel,
log.Fields{}, "High threshold is lower than low threshold!")
}
pipe, err := cmd.StdoutPipe()
@ -75,8 +75,8 @@ func StartPCPLogAndProgressiveExtremaCap(quit chan struct{}, logging *bool, hiTh
// Write to logfile
elektronLogging.ElektronLog.Log(elekLogT.PCP,
log.InfoLevel,
log.Fields {}, scanner.Text())
log.InfoLevel,
log.Fields{}, scanner.Text())
headers := strings.Split(scanner.Text(), ",")
@ -116,14 +116,14 @@ func StartPCPLogAndProgressiveExtremaCap(quit chan struct{}, logging *bool, hiTh
for scanner.Scan() {
if *logging {
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields {}, "Logging PCP...")
log.InfoLevel,
log.Fields{}, "Logging PCP...")
split := strings.Split(scanner.Text(), ",")
text := scanner.Text()
elektronLogging.ElektronLog.Log(elekLogT.PCP,
log.InfoLevel,
log.Fields {}, text)
log.InfoLevel,
log.Fields{}, text)
totalPower := 0.0
for _, powerIndex := range powerIndexes {
@ -135,9 +135,9 @@ func StartPCPLogAndProgressiveExtremaCap(quit chan struct{}, logging *bool, hiTh
powerHistories[host] = powerHistories[host].Next()
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields {"Host" : fmt.Sprintf("%s",indexToHost[powerIndex]), "Power" : fmt.Sprintf("%f",(power * pcp.RAPLUnits))},
"")
log.InfoLevel,
log.Fields{"Host": fmt.Sprintf("%s", indexToHost[powerIndex]), "Power": fmt.Sprintf("%f", (power * pcp.RAPLUnits))},
"")
totalPower += power
}
clusterPower := totalPower * pcp.RAPLUnits
@ -148,23 +148,23 @@ func StartPCPLogAndProgressiveExtremaCap(quit chan struct{}, logging *bool, hiTh
clusterMean := pcp.AverageClusterPowerHistory(clusterPowerHist)
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields {"Total power" : fmt.Sprintf("%f %d",clusterPower,clusterPowerHist.Len()),
"Sec Avg" : fmt.Sprintf("%f",clusterMean)},
"")
log.InfoLevel,
log.Fields{"Total power": fmt.Sprintf("%f %d", clusterPower, clusterPowerHist.Len()),
"Sec Avg": fmt.Sprintf("%f", clusterMean)},
"")
if clusterMean >= hiThreshold {
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields {}, "Need to cap a node")
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields {"Cap values of capped victims" : fmt.Sprintf("%v",cappedVictims)}, "")
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields {"Cap values of victims to uncap" : fmt.Sprintf("%v",orderCappedVictims)}, "")
log.InfoLevel,
log.Fields{}, "Need to cap a node")
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields{"Cap values of capped victims": fmt.Sprintf("%v", cappedVictims)}, "")
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields{"Cap values of victims to uncap": fmt.Sprintf("%v", orderCappedVictims)}, "")
// Create statics for all victims and choose one to cap
victims := make([]pcp.Victim, 0, 8)
@ -191,15 +191,15 @@ func StartPCPLogAndProgressiveExtremaCap(quit chan struct{}, logging *bool, hiTh
}
// Need to cap this victim.
if err := rapl.Cap(victims[i].Host, "rapl", 50.0); err != nil {
elektronLogging.ElektronLog.Log(elekLogT.ERROR,
log.ErrorLevel,
log.Fields {"Error capping host" : fmt.Sprintf("%s",victims[i].Host)}, "")
elektronLogging.ElektronLog.Log(elekLogT.ERROR,
log.ErrorLevel,
log.Fields{"Error capping host": fmt.Sprintf("%s", victims[i].Host)}, "")
} else {
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields {}, fmt.Sprintf("Capped host[%s] at %f", victims[i].Host, 50.0))
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields{}, fmt.Sprintf("Capped host[%s] at %f", victims[i].Host, 50.0))
// Keeping track of this victim and it's cap value
cappedVictims[victims[i].Host] = 50.0
newVictimFound = true
@ -222,15 +222,15 @@ func StartPCPLogAndProgressiveExtremaCap(quit chan struct{}, logging *bool, hiTh
if capValue > constants.LowerCapLimit {
newCapValue := getNextCapValue(capValue, 2)
if err := rapl.Cap(alreadyCappedHosts[i], "rapl", newCapValue); err != nil {
elektronLogging.ElektronLog.Log(elekLogT.ERROR,
log.ErrorLevel,
log.Fields {"Error capping host" : fmt.Sprintf("%s",alreadyCappedHosts[i])}, "")
elektronLogging.ElektronLog.Log(elekLogT.ERROR,
log.ErrorLevel,
log.Fields{"Error capping host": fmt.Sprintf("%s", alreadyCappedHosts[i])}, "")
} else {
// Successful cap
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields {}, fmt.Sprintf("Capped host[%s] at %f", alreadyCappedHosts[i], newCapValue))
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields{}, fmt.Sprintf("Capped host[%s] at %f", alreadyCappedHosts[i], newCapValue))
// Checking whether this victim can be capped further
if newCapValue <= constants.LowerCapLimit {
// Deleting victim from cappedVictims.
@ -253,23 +253,23 @@ func StartPCPLogAndProgressiveExtremaCap(quit chan struct{}, logging *bool, hiTh
}
}
if !canCapAlreadyCappedVictim {
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields {}, "No Victim left to cap")
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields{}, "No Victim left to cap")
}
}
} else if clusterMean < loThreshold {
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields {}, "Need to uncap a node")
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields {"Cap values of capped victims" : fmt.Sprintf("%v",cappedVictims)}, "")
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields {"Cap values of victims to uncap" : fmt.Sprintf("%v",orderCappedVictims)}, "")
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields{}, "Need to uncap a node")
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields{"Cap values of capped victims": fmt.Sprintf("%v", cappedVictims)}, "")
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields{"Cap values of victims to uncap": fmt.Sprintf("%v", orderCappedVictims)}, "")
if len(orderCapped) > 0 {
// We pick the host that is capped the most to uncap.
orderCappedToSort := utilities.GetPairList(orderCappedVictims)
@ -279,15 +279,15 @@ func StartPCPLogAndProgressiveExtremaCap(quit chan struct{}, logging *bool, hiTh
// This is a floating point operation and might suffer from precision loss.
newUncapValue := orderCappedVictims[hostToUncap] * 2.0
if err := rapl.Cap(hostToUncap, "rapl", newUncapValue); err != nil {
elektronLogging.ElektronLog.Log(elekLogT.ERROR,
log.ErrorLevel,
log.Fields {"Error uncapping host" : fmt.Sprintf("%s",hostToUncap)}, "")
elektronLogging.ElektronLog.Log(elekLogT.ERROR,
log.ErrorLevel,
log.Fields{"Error uncapping host": fmt.Sprintf("%s", hostToUncap)}, "")
} else {
// Successful uncap
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields {}, fmt.Sprintf("Uncapped host[%s] to %f", hostToUncap, newUncapValue))
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields{}, fmt.Sprintf("Uncapped host[%s] to %f", hostToUncap, newUncapValue))
// Can we uncap this host further. If not, then we remove its entry from orderCapped
if newUncapValue >= 100.0 { // can compare using ==
// Deleting entry from orderCapped
@ -308,9 +308,9 @@ func StartPCPLogAndProgressiveExtremaCap(quit chan struct{}, logging *bool, hiTh
}
}
} else {
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields {}, "No host staged for Uncapped")
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields{}, "No host staged for Uncapped")
}
}
}
@ -319,9 +319,9 @@ func StartPCPLogAndProgressiveExtremaCap(quit chan struct{}, logging *bool, hiTh
}(logging, hiThreshold, loThreshold)
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields {}, "PCP logging started")
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields{}, "PCP logging started")
if err := cmd.Start(); err != nil {
log.Fatal(err)
}
@ -330,9 +330,9 @@ func StartPCPLogAndProgressiveExtremaCap(quit chan struct{}, logging *bool, hiTh
select {
case <-quit:
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields {}, "Stopping PCP logging in 5 seconds")
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields{}, "Stopping PCP logging in 5 seconds")
time.Sleep(5 * time.Second)
// http://stackoverflow.com/questions/22470193/why-wont-go-kill-a-child-process-correctly

View file

@ -1,20 +1,20 @@
// Copyright (C) 2018 spdfg
//
//
// This file is part of Elektron.
//
//
// Elektron is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
//
// Elektron is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
//
// You should have received a copy of the GNU General Public License
// along with Elektron. If not, see <http://www.gnu.org/licenses/>.
//
//
package rapl

View file

@ -28,13 +28,13 @@ import (
"github.com/golang/protobuf/proto"
mesos "github.com/mesos/mesos-go/api/v0/mesosproto"
sched "github.com/mesos/mesos-go/api/v0/scheduler"
log "github.com/sirupsen/logrus"
"github.com/spdfg/elektron/def"
"github.com/spdfg/elektron/elektronLogging"
elekLogT "github.com/spdfg/elektron/elektronLogging/types"
"github.com/spdfg/elektron/pcp"
"github.com/spdfg/elektron/powerCap"
"github.com/spdfg/elektron/schedulers"
"github.com/spdfg/elektron/elektronLogging"
elekLogT "github.com/spdfg/elektron/elektronLogging/types"
log "github.com/sirupsen/logrus"
)
var master = flag.String("master", "", "Location of leading Mesos master -- <mesos-master>:<port>")
@ -283,10 +283,10 @@ func main() {
// Starting the scheduler driver.
if status, err := driver.Run(); err != nil {
elektronLogging.ElektronLog.Log(elekLogT.ERROR,
log.ErrorLevel,
log.Fields {"status" : status.String(), "error" : err.Error()}, "Framework stopped ")
log.ErrorLevel,
log.Fields{"status": status.String(), "error": err.Error()}, "Framework stopped ")
}
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields {}, "Exiting...")
log.Fields{}, "Exiting...")
}

View file

@ -1,20 +1,20 @@
// Copyright (C) 2018 spdfg
//
//
// This file is part of Elektron.
//
//
// Elektron is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
//
// Elektron is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
//
// You should have received a copy of the GNU General Public License
// along with Elektron. If not, see <http://www.gnu.org/licenses/>.
//
//
package schedulers

View file

@ -1,20 +1,20 @@
// Copyright (C) 2018 spdfg
//
//
// This file is part of Elektron.
//
//
// Elektron is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
//
// Elektron is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
//
// You should have received a copy of the GNU General Public License
// along with Elektron. If not, see <http://www.gnu.org/licenses/>.
//
//
package schedulers

View file

@ -1,20 +1,20 @@
// Copyright (C) 2018 spdfg
//
//
// This file is part of Elektron.
//
//
// Elektron is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
//
// Elektron is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
//
// You should have received a copy of the GNU General Public License
// along with Elektron. If not, see <http://www.gnu.org/licenses/>.
//
//
package schedulers
@ -28,12 +28,12 @@ import (
mesos "github.com/mesos/mesos-go/api/v0/mesosproto"
"github.com/mesos/mesos-go/api/v0/mesosutil"
sched "github.com/mesos/mesos-go/api/v0/scheduler"
log "github.com/sirupsen/logrus"
"github.com/spdfg/elektron/def"
"github.com/spdfg/elektron/elektronLogging"
elekLogT "github.com/spdfg/elektron/elektronLogging/types"
"github.com/spdfg/elektron/utilities"
"github.com/spdfg/elektron/utilities/schedUtils"
"github.com/spdfg/elektron/elektronLogging"
elekLogT "github.com/spdfg/elektron/elektronLogging/types"
log "github.com/sirupsen/logrus"
)
type BaseScheduler struct {
@ -251,14 +251,14 @@ func (s *BaseScheduler) StatusUpdate(driver sched.SchedulerDriver, status *mesos
func (s *BaseScheduler) LogTaskStarting(ts *def.Task, offer *mesos.Offer) {
lmt := elekLogT.GENERAL
if ts == nil {
elektronLogging.ElektronLog.Log(lmt, log.InfoLevel,
log.Fields {"host" : fmt.Sprintf("%s",offer.GetHostname())}, "TASKS STARTING...")
elektronLogging.ElektronLog.Log(lmt, log.InfoLevel,
log.Fields{"host": fmt.Sprintf("%s", offer.GetHostname())}, "TASKS STARTING...")
} else {
elektronLogging.ElektronLog.Log(lmt,
log.InfoLevel,
log.Fields {"task" : fmt.Sprintf("%s",ts.Name),
"Instance" : fmt.Sprintf("%d",*ts.Instances), "host" : fmt.Sprintf("%s",offer.GetHostname())},
"TASK STARTING... ")
log.InfoLevel,
log.Fields{"task": fmt.Sprintf("%s", ts.Name),
"Instance": fmt.Sprintf("%d", *ts.Instances), "host": fmt.Sprintf("%s", offer.GetHostname())},
"TASK STARTING... ")
}
}
@ -266,28 +266,28 @@ func (s *BaseScheduler) LogTaskWattsConsideration(ts def.Task, host string, watt
lmt := elekLogT.GENERAL
elektronLogging.ElektronLog.Log(lmt,
log.InfoLevel,
log.Fields {"task" : ts.Name, "host" : host, "Watts" : fmt.Sprintf("%f",wattsToConsider)}, "Watts considered for ")
log.Fields{"task": ts.Name, "host": host, "Watts": fmt.Sprintf("%f", wattsToConsider)}, "Watts considered for ")
}
func (s *BaseScheduler) LogOffersReceived(offers []*mesos.Offer) {
lmt := elekLogT.GENERAL
elektronLogging.ElektronLog.Log(lmt,
log.InfoLevel,
log.Fields {"Resource offers received" : fmt.Sprintf("%d",len(offers))}, "")
log.Fields{"Resource offers received": fmt.Sprintf("%d", len(offers))}, "")
}
func (s *BaseScheduler) LogNoPendingTasksDeclineOffers(offer *mesos.Offer) {
lmt := elekLogT.WARNING
elektronLogging.ElektronLog.Log(lmt,
log.WarnLevel,
log.Fields {"DECLINING OFFER for host" : fmt.Sprintf("%s",offer.GetHostname())}, "No tasks left to schedule ")
log.Fields{"DECLINING OFFER for host": fmt.Sprintf("%s", offer.GetHostname())}, "No tasks left to schedule ")
}
func (s *BaseScheduler) LogNumberOfRunningTasks() {
lmt := elekLogT.GENERAL
elektronLogging.ElektronLog.Log(lmt,
log.InfoLevel,
log.Fields {"Number of tasks still Running" : fmt.Sprintf("%d",s.tasksRunning)}, "")
log.Fields{"Number of tasks still Running": fmt.Sprintf("%d", s.tasksRunning)}, "")
}
func (s *BaseScheduler) LogCoLocatedTasks(slaveID string) {
@ -300,20 +300,20 @@ func (s *BaseScheduler) LogCoLocatedTasks(slaveID string) {
s.TasksRunningMutex.Unlock()
elektronLogging.ElektronLog.Log(lmt,
log.InfoLevel,
log.Fields {"Colocated with" : fmt.Sprintf("%s",buffer.String())}, "")
log.Fields{"Colocated with": fmt.Sprintf("%s", buffer.String())}, "")
}
func (s *BaseScheduler) LogSchedTrace(taskToSchedule *mesos.TaskInfo, offer *mesos.Offer) {
elektronLogging.ElektronLog.Log(elekLogT.SCHED_TRACE,
log.InfoLevel,
log.Fields {offer.GetHostname() : fmt.Sprintf("%s",taskToSchedule.GetTaskId().GetValue())}, "")
log.Fields{offer.GetHostname(): fmt.Sprintf("%s", taskToSchedule.GetTaskId().GetValue())}, "")
}
func (s *BaseScheduler) LogTerminateScheduler() {
lmt := elekLogT.GENERAL
elektronLogging.ElektronLog.Log(lmt,
log.InfoLevel,
log.Fields {}, "Done scheduling all tasks!")
log.Fields{}, "Done scheduling all tasks!")
}
func (s *BaseScheduler) LogInsufficientResourcesDeclineOffer(offer *mesos.Offer,
@ -323,72 +323,72 @@ func (s *BaseScheduler) LogInsufficientResourcesDeclineOffer(offer *mesos.Offer,
buffer.WriteString(fmt.Sprintf("<CPU: %f, RAM: %f, Watts: %f>", offerResources...))
elektronLogging.ElektronLog.Log(lmt,
log.WarnLevel,
log.Fields {"Offer Resources" : fmt.Sprintf("%s",buffer.String())}, "DECLINING OFFER... Offer has insufficient resources to launch a task")
log.Fields{"Offer Resources": fmt.Sprintf("%s", buffer.String())}, "DECLINING OFFER... Offer has insufficient resources to launch a task")
}
func (s *BaseScheduler) LogOfferRescinded(offerID *mesos.OfferID) {
lmt := elekLogT.ERROR
elektronLogging.ElektronLog.Log(lmt,
log.ErrorLevel,
log.Fields {"OfferID" : fmt.Sprintf("%s",offerID)}, "OFFER RESCINDED")
log.Fields{"OfferID": fmt.Sprintf("%s", offerID)}, "OFFER RESCINDED")
}
func (s *BaseScheduler) LogSlaveLost(slaveID *mesos.SlaveID) {
lmt := elekLogT.ERROR
elektronLogging.ElektronLog.Log(lmt,
log.ErrorLevel,
log.Fields {"SlaveID" : fmt.Sprintf("%s",slaveID)}, "SLAVE LOST")
log.Fields{"SlaveID": fmt.Sprintf("%s", slaveID)}, "SLAVE LOST")
}
func (s *BaseScheduler) LogExecutorLost(executorID *mesos.ExecutorID, slaveID *mesos.SlaveID) {
lmt := elekLogT.ERROR
elektronLogging.ElektronLog.Log(lmt,
elektronLogging.ElektronLog.Log(lmt,
log.ErrorLevel,
log.Fields {"ExecutorID" : fmt.Sprintf("%s",executorID), "SlaveID" : fmt.Sprintf("%s", slaveID)}, "EXECUTOR LOST")
log.Fields{"ExecutorID": fmt.Sprintf("%s", executorID), "SlaveID": fmt.Sprintf("%s", slaveID)}, "EXECUTOR LOST")
}
func (s *BaseScheduler) LogFrameworkMessage(executorID *mesos.ExecutorID,
slaveID *mesos.SlaveID, message string) {
lmt := elekLogT.GENERAL
elektronLogging.ElektronLog.Log(lmt,
elektronLogging.ElektronLog.Log(lmt,
log.InfoLevel,
log.Fields {"Received Framework message from executor" : executorID}, message)
log.Fields{"Received Framework message from executor": executorID}, message)
}
func (s *BaseScheduler) LogMesosError(err string) {
lmt := elekLogT.ERROR
elektronLogging.ElektronLog.Log(lmt,
elektronLogging.ElektronLog.Log(lmt,
log.ErrorLevel,
log.Fields {"MESOS ERROR" : fmt.Sprintf("%v", err)}, "")
log.Fields{"MESOS ERROR": fmt.Sprintf("%v", err)}, "")
}
func (s *BaseScheduler) LogElectronError(err error) {
lmt := elekLogT.ERROR
elektronLogging.ElektronLog.Log(lmt,
elektronLogging.ElektronLog.Log(lmt,
log.ErrorLevel,
log.Fields {"ELECTRON ERROR" : fmt.Sprintf("%v",err)}, "")
log.Fields{"ELECTRON ERROR": fmt.Sprintf("%v", err)}, "")
}
func (s *BaseScheduler) LogFrameworkRegistered(frameworkID *mesos.FrameworkID,
masterInfo *mesos.MasterInfo) {
lmt := elekLogT.SUCCESS
elektronLogging.ElektronLog.Log(lmt,
elektronLogging.ElektronLog.Log(lmt,
log.InfoLevel,
log.Fields {"frameworkID" : fmt.Sprintf("%s",frameworkID), "master" : fmt.Sprintf("%s",masterInfo)}, "FRAMEWORK REGISTERED!")
log.Fields{"frameworkID": fmt.Sprintf("%s", frameworkID), "master": fmt.Sprintf("%s", masterInfo)}, "FRAMEWORK REGISTERED!")
}
func (s *BaseScheduler) LogFrameworkReregistered(masterInfo *mesos.MasterInfo) {
lmt := elekLogT.GENERAL
elektronLogging.ElektronLog.Log(lmt,
elektronLogging.ElektronLog.Log(lmt,
log.InfoLevel,
log.Fields {"master" : fmt.Sprintf("%s",masterInfo)}, "Framework re-registered")
log.Fields{"master": fmt.Sprintf("%s", masterInfo)}, "Framework re-registered")
}
func (s *BaseScheduler) LogDisconnected() {
lmt := elekLogT.WARNING
elektronLogging.ElektronLog.Log(lmt,
elektronLogging.ElektronLog.Log(lmt,
log.WarnLevel,
log.Fields {}, "Framework disconnected with master")
log.Fields{}, "Framework disconnected with master")
}
func (s *BaseScheduler) LogTaskStatusUpdate(status *mesos.TaskStatus) {
@ -402,16 +402,16 @@ func (s *BaseScheduler) LogTaskStatusUpdate(status *mesos.TaskStatus) {
default:
lmt = elekLogT.GENERAL
}
elektronLogging.ElektronLog.Log(lmt,
elektronLogging.ElektronLog.Log(lmt,
log.InfoLevel,
log.Fields {"task" : fmt.Sprintf("%s",*status.TaskId.Value), "state" : NameFor(status.State)}, "Task Status received")
log.Fields{"task": fmt.Sprintf("%s", *status.TaskId.Value), "state": NameFor(status.State)}, "Task Status received")
}
func (s *BaseScheduler) LogSchedPolicySwitch(name string, nextPolicy SchedPolicyState) {
logSPS := func() {
elektronLogging.ElektronLog.Log(elekLogT.SPS,
log.InfoLevel,
log.Fields {"Name" : name}, "")
elektronLogging.ElektronLog.Log(elekLogT.SPS,
log.InfoLevel,
log.Fields{"Name": name}, "")
}
if s.hasReceivedResourceOffers && (s.curSchedPolicy != nextPolicy) {
logSPS()
@ -420,14 +420,14 @@ func (s *BaseScheduler) LogSchedPolicySwitch(name string, nextPolicy SchedPolicy
}
// Logging the size of the scheduling window and the scheduling policy
// that is going to schedule the tasks in the scheduling window.
elektronLogging.ElektronLog.Log(elekLogT.SCHED_WINDOW,
elektronLogging.ElektronLog.Log(elekLogT.SCHED_WINDOW,
log.InfoLevel,
log.Fields {"Window size" : fmt.Sprintf("%d",s.schedWindowSize), "Name" : name}, "")
log.Fields{"Window size": fmt.Sprintf("%d", s.schedWindowSize), "Name": name}, "")
}
func (s *BaseScheduler) LogClsfnAndTaskDistOverhead(overhead time.Duration) {
// Logging the overhead in microseconds.
elektronLogging.ElektronLog.Log(elekLogT.CLSFN_TASKDIST_OVERHEAD,
log.InfoLevel,
log.Fields {"Overhead in microseconds" : fmt.Sprintf("%f", float64(overhead.Nanoseconds())/1000.0)}, "")
log.Fields{"Overhead in microseconds": fmt.Sprintf("%f", float64(overhead.Nanoseconds())/1000.0)}, "")
}

View file

@ -1,20 +1,20 @@
// Copyright (C) 2018 spdfg
//
//
// This file is part of Elektron.
//
//
// Elektron is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
//
// Elektron is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
//
// You should have received a copy of the GNU General Public License
// along with Elektron. If not, see <http://www.gnu.org/licenses/>.
//
//
package schedulers

View file

@ -1,20 +1,20 @@
// Copyright (C) 2018 spdfg
//
//
// This file is part of Elektron.
//
//
// Elektron is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
//
// Elektron is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
//
// You should have received a copy of the GNU General Public License
// along with Elektron. If not, see <http://www.gnu.org/licenses/>.
//
//
package schedulers

View file

@ -1,20 +1,20 @@
// Copyright (C) 2018 spdfg
//
//
// This file is part of Elektron.
//
//
// Elektron is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
//
// Elektron is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
//
// You should have received a copy of the GNU General Public License
// along with Elektron. If not, see <http://www.gnu.org/licenses/>.
//
//
package schedulers

View file

@ -23,26 +23,26 @@ import (
mesos "github.com/mesos/mesos-go/api/v0/mesosproto"
sched "github.com/mesos/mesos-go/api/v0/scheduler"
"github.com/pkg/errors"
log "github.com/sirupsen/logrus"
"github.com/spdfg/elektron/constants"
"github.com/spdfg/elektron/def"
"github.com/spdfg/elektron/elektronLogging"
elekLogT "github.com/spdfg/elektron/elektronLogging/types"
"github.com/spdfg/elektron/utilities"
"github.com/spdfg/elektron/utilities/mesosUtils"
log "github.com/sirupsen/logrus"
"github.com/spdfg/elektron/elektronLogging"
elekLogT "github.com/spdfg/elektron/elektronLogging/types"
)
func coLocated(tasks map[string]bool, s BaseScheduler) {
for task := range tasks {
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields {"Task" : task}, "")
log.InfoLevel,
log.Fields{"Task": task}, "")
}
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields {}, "---------------------")
log.Fields{}, "---------------------")
}
// Get the powerClass of the given hostname.

View file

@ -1,20 +1,20 @@
// Copyright (C) 2018 spdfg
//
//
// This file is part of Elektron.
//
//
// Elektron is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
//
// Elektron is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
//
// You should have received a copy of the GNU General Public License
// along with Elektron. If not, see <http://www.gnu.org/licenses/>.
//
//
package schedulers
@ -24,10 +24,10 @@ import (
mesos "github.com/mesos/mesos-go/api/v0/mesosproto"
sched "github.com/mesos/mesos-go/api/v0/scheduler"
log "github.com/sirupsen/logrus"
"github.com/spdfg/elektron/def"
"github.com/spdfg/elektron/elektronLogging"
elekLogT "github.com/spdfg/elektron/elektronLogging/types"
log "github.com/sirupsen/logrus"
)
type SchedPolicyContext interface {
@ -92,7 +92,7 @@ func switchTaskDistBased(baseSchedRef *BaseScheduler) string {
baseSchedRef.LogClsfnAndTaskDistOverhead(time.Now().Sub(startTime))
elektronLogging.ElektronLog.Log(elekLogT.GENERAL,
log.InfoLevel,
log.Fields {"Task Distribution" : fmt.Sprintf("%f",taskDist)}, "Switching... ")
log.Fields{"Task Distribution": fmt.Sprintf("%f", taskDist)}, "Switching... ")
if err != nil {
// All the tasks in the window were only classified into 1 cluster.
// Max-Min and Max-GreedyMins would work the same way as Bin-Packing for this situation.

View file

@ -1,20 +1,20 @@
// Copyright (C) 2018 spdfg
//
//
// This file is part of Elektron.
//
//
// Elektron is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
//
// Elektron is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
//
// You should have received a copy of the GNU General Public License
// along with Elektron. If not, see <http://www.gnu.org/licenses/>.
//
//
package schedulers

View file

@ -1,20 +1,20 @@
// Copyright (C) 2018 spdfg
//
//
// This file is part of Elektron.
//
//
// Elektron is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
//
// Elektron is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
//
// You should have received a copy of the GNU General Public License
// along with Elektron. If not, see <http://www.gnu.org/licenses/>.
//
//
package schedulers

View file

@ -1,20 +1,20 @@
// Copyright (C) 2018 spdfg
//
//
// This file is part of Elektron.
//
//
// Elektron is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
//
// Elektron is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
//
// You should have received a copy of the GNU General Public License
// along with Elektron. If not, see <http://www.gnu.org/licenses/>.
//
//
package mesosUtils

View file

@ -1,31 +1,31 @@
// Copyright (C) 2018 spdfg
//
//
// This file is part of Elektron.
//
//
// Elektron is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
//
// Elektron is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
//
// You should have received a copy of the GNU General Public License
// along with Elektron. If not, see <http://www.gnu.org/licenses/>.
//
//
package offerUtils
import (
"strings"
"fmt"
"fmt"
mesos "github.com/mesos/mesos-go/api/v0/mesosproto"
log "github.com/sirupsen/logrus"
"github.com/spdfg/elektron/constants"
"github.com/spdfg/elektron/elektronLogging"
"github.com/spdfg/elektron/elektronLogging"
elekLogT "github.com/spdfg/elektron/elektronLogging/types"
log "github.com/sirupsen/logrus"
"strings"
)
func OfferAgg(offer *mesos.Offer) (float64, float64, float64) {
@ -90,14 +90,14 @@ func UpdateEnvironment(offer *mesos.Offer) {
var host = offer.GetHostname()
// If this host is not present in the set of hosts.
if _, ok := constants.Hosts[host]; !ok {
elektronLogging.ElektronLog.Log(elekLogT.GENERAL, log.InfoLevel,
log.Fields {"Adding host" : fmt.Sprintf("%s",host)}, "New host detected")
elektronLogging.ElektronLog.Log(elekLogT.GENERAL, log.InfoLevel,
log.Fields{"Adding host": fmt.Sprintf("%s", host)}, "New host detected")
// Add this host.
constants.Hosts[host] = struct{}{}
// Get the power class of this host.
class := PowerClass(offer)
elektronLogging.ElektronLog.Log(elekLogT.GENERAL, log.InfoLevel,
log.Fields {"host" : fmt.Sprintf("%s",host), "PowerClass" : fmt.Sprintf("%s", class)}, "Registering the power class...")
elektronLogging.ElektronLog.Log(elekLogT.GENERAL, log.InfoLevel,
log.Fields{"host": fmt.Sprintf("%s", host), "PowerClass": fmt.Sprintf("%s", class)}, "Registering the power class...")
// If new power class, register the power class.
if _, ok := constants.PowerClasses[class]; !ok {
constants.PowerClasses[class] = make(map[string]struct{})

View file

@ -1,20 +1,20 @@
// Copyright (C) 2018 spdfg
//
//
// This file is part of Elektron.
//
//
// Elektron is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
//
// Elektron is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
//
// You should have received a copy of the GNU General Public License
// along with Elektron. If not, see <http://www.gnu.org/licenses/>.
//
//
/*
A utility to calculate the running average.

View file

@ -1,30 +1,30 @@
// Copyright (C) 2018 spdfg
//
//
// This file is part of Elektron.
//
//
// Elektron is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
//
// Elektron is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
//
// You should have received a copy of the GNU General Public License
// along with Elektron. If not, see <http://www.gnu.org/licenses/>.
//
//
package schedUtils
import (
"fmt"
"fmt"
log "github.com/sirupsen/logrus"
"github.com/spdfg/elektron/def"
"github.com/spdfg/elektron/utilities"
"github.com/spdfg/elektron/elektronLogging"
"github.com/spdfg/elektron/elektronLogging"
elekLogT "github.com/spdfg/elektron/elektronLogging/types"
log "github.com/sirupsen/logrus"
"github.com/spdfg/elektron/utilities"
)
// Criteria for resizing the scheduling window.
@ -79,9 +79,9 @@ func (s *fillNextOfferCycle) apply(taskQueue []def.Task) (int, int) {
for _, task := range taskQueue {
numberOfTasksTraversed++
for i := *task.Instances; i > 0; i-- {
elektronLogging.ElektronLog.Log(elekLogT.GENERAL, log.InfoLevel,
log.Fields {}, fmt.Sprintf("Checking if Instance #%d of Task[%s] can be scheduled "+
"during the next offer cycle...", i, task.Name))
elektronLogging.ElektronLog.Log(elekLogT.GENERAL, log.InfoLevel,
log.Fields{}, fmt.Sprintf("Checking if Instance #%d of Task[%s] can be scheduled "+
"during the next offer cycle...", i, task.Name))
if canSchedule(task) {
filledCPU += task.CPU
filledRAM += task.RAM

View file

@ -1,20 +1,20 @@
// Copyright (C) 2018 spdfg
//
//
// This file is part of Elektron.
//
//
// Elektron is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
//
// Elektron is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
//
// You should have received a copy of the GNU General Public License
// along with Elektron. If not, see <http://www.gnu.org/licenses/>.
//
//
package utilities

View file

@ -1,20 +1,20 @@
// Copyright (C) 2018 spdfg
//
//
// This file is part of Elektron.
//
//
// Elektron is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
//
// Elektron is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
//
// You should have received a copy of the GNU General Public License
// along with Elektron. If not, see <http://www.gnu.org/licenses/>.
//
//
package utilities