ridv/gorealis-v2
1
0
Fork 0
Code Issues Pull requests Projects Releases 13 Packages Wiki Activity Actions

Changing the names of the protocol constants to be more descriptive.

Browse source
This commit is contained in:
Renan DelValle 2019-09-12 10:11:05 -07:00 • committed by Renan DelValle
parent 55cf9bcb70
commit f72fdacfb0
1 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

14
realis.go
View file

@ -80,9 +80,9 @@ var defaultBackoff = Backoff{
type TransportProtocol int type TransportProtocol int
const ( const (
unset TransportProtocol = iota unsetProtocol TransportProtocol = iota
json jsonProtocol
binary binaryProtocol
) )
type ClientOption func(*clientConfig) type ClientOption func(*clientConfig)
@ -128,13 +128,13 @@ func ZKUrl(url string) ClientOption {
func ThriftJSON() ClientOption { func ThriftJSON() ClientOption {
return func(config *clientConfig) { return func(config *clientConfig) {
config.transportProtocol = json config.transportProtocol = jsonProtocol
} }
} }
func ThriftBinary() ClientOption { func ThriftBinary() ClientOption {
return func(config *clientConfig) { return func(config *clientConfig) {
config.transportProtocol = binary config.transportProtocol = binaryProtocol
} }
} }
@ -293,14 +293,14 @@ func NewClient(options ...ClientOption) (*Client, error) {
} }
switch config.transportProtocol { switch config.transportProtocol {
case binary: case binaryProtocol:
trans, err := newTBinTransport(url, config.timeout, config) trans, err := newTBinTransport(url, config.timeout, config)
if err != nil { if err != nil {
return nil, NewTemporaryError(errors.Wrap(err, "error creating realis")) return nil, NewTemporaryError(errors.Wrap(err, "error creating realis"))
} }
config.transport = trans config.transport = trans
config.protoFactory = thrift.NewTBinaryProtocolFactoryDefault() config.protoFactory = thrift.NewTBinaryProtocolFactoryDefault()
case json: case jsonProtocol:
fallthrough fallthrough
default: default:
trans, err := newTJSONTransport(url, config.timeout, config) trans, err := newTJSONTransport(url, config.timeout, config)