ridv/gorealis-v2
1
0
Fork 0
Code Issues Pull requests Projects Releases 13 Packages Wiki Activity Actions
gorealis-v2/.github/PULL_REQUEST_TEMPLATE.md
Renan DelValle c338c03355
Thrift API update and Pull Request template. (#43) 
* Adding a Pull request template to serve as a reminder of what
to do before creating the pull request.

* Updating our thrift API to match changes made by Aurora.

* Update go bindings to match update thrift API.
2017-12-14 14:37:08 -08:00

532 B
Raw Blame History

Before submitting, please make sure you run a vagrant box running Aurora with the latest version shown in .auroraversion and run go test from the project root.

To run an Aurora Vagrant image, follow the instructions here: http://aurora.apache.org/documentation/latest/getting-started/vagrant/

  • Have you run goformat on the project before submitting?

  • Have you run go test on the project before submitting? Do all tests pass?

  • Does the Pull Request require a test to be added to the end to end tests? If so, has it been added?