ridv/gorealis
1
0
Fork 0
Code Issues Pull requests Projects Releases 23 Packages Wiki Activity Actions

Reducing line size. in some files and shadowing in some test cases.

Browse source
This commit is contained in:
Renan DelValle 2019-06-11 15:59:57 -07:00
parent fc574490f8
commit 0e916ebd76
No known key found for this signature in database
GPG key ID: C240AD6D6F443EC9
2 changed files with 12 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

6
monitors.go
View file

@ -21,8 +21,10 @@ import (
"github.com/pkg/errors" "github.com/pkg/errors"
) )
// Monitor is a wrapper for the Realis client which allows us to have functions with the same name for Monitoring purposes. // Monitor is a wrapper for the Realis client which allows us to have functions
// TODO(rdelvalle): Deprecate monitors and instead add prefix Monitor to all functions in this file like it is done in V2. // with the same name for Monitoring purposes.
// TODO(rdelvalle): Deprecate monitors and instead add prefix Monitor to
// all functions in this file like it is done in V2.
type Monitor struct { type Monitor struct {
Client Realis Client Realis
} }

16
realis_e2e_test.go
View file

@ -77,17 +77,17 @@ func TestNonExistentEndpoint(t *testing.T) {
t.Run("WithRetries", func(t *testing.T) { t.Run("WithRetries", func(t *testing.T) {
// Attempt to connect to a bad endpoint // Attempt to connect to a bad endpoint
r, err := realis.NewRealisClient( badClient, err := realis.NewRealisClient(
realis.SchedulerUrl(badEndpoint), realis.SchedulerUrl(badEndpoint),
realis.TimeoutMS(200000), realis.TimeoutMS(200000),
realis.BackOff(backoff), realis.BackOff(backoff),
) )
require.NoError(t, err) require.NoError(t, err)
require.NotNil(t, r) require.NotNil(t, badClient)
defer r.Close() defer badClient.Close()
_, err = r.GetTasksWithoutConfigs(taskQ) _, err = badClient.GetTasksWithoutConfigs(taskQ)
// Check that we do error out of retrying // Check that we do error out of retrying
require.Error(t, err) require.Error(t, err)
@ -101,7 +101,7 @@ func TestNonExistentEndpoint(t *testing.T) {
t.Run("FailOnLookup", func(t *testing.T) { t.Run("FailOnLookup", func(t *testing.T) {
// Attempt to connect to a bad endpoint // Attempt to connect to a bad endpoint
r, err := realis.NewRealisClient( badClient, err := realis.NewRealisClient(
realis.SchedulerUrl(badEndpoint), realis.SchedulerUrl(badEndpoint),
realis.TimeoutMS(200000), realis.TimeoutMS(200000),
realis.BackOff(backoff), realis.BackOff(backoff),
@ -109,10 +109,10 @@ func TestNonExistentEndpoint(t *testing.T) {
) )
require.NoError(t, err) require.NoError(t, err)
require.NotNil(t, r) require.NotNil(t, badClient)
defer r.Close() defer badClient.Close()
_, err = r.GetTasksWithoutConfigs(taskQ) _, err = badClient.GetTasksWithoutConfigs(taskQ)
// Check that we do error out of retrying // Check that we do error out of retrying
require.Error(t, err) require.Error(t, err)