Moving the r.Close() call in the retry mechanism created a deadlock since r.Close() also uses the client lock to avoid multiple routines closing at the same time.
This commit reverts that change.
* Updating readme to reflect changes made to the Aurora Scheduler project.
* Changing dependency of mod to point to forked version of the Thrift library while 0.14.0 is released.
* Updating Changelog to reflect what's changing in 1.22.1
* Bug fix: Setting the same constraint multiple times is no longer allowed.
* Constraints map has been added to handle constraints being added to Aurora Jobs.
* Lowering timeout to avoid flaky test for bad payload timeout.
* Adding attributes to Mesos agents in order to test limits by constraint.
* Make two instances schedulable per zone in order to experience flaky behavior.
* Updating thrift definitions to add autopause for batch based update strategies.
* Adding batch calculator utility and test cases for it.
* Adding PauseUpdateMonitor which allows users to poll Aurora for information on an active Update being carried out until it enters the ROLL_FORWARD_PAUSED state.
* Tests for PauseUpdateMonitor and VariableBatchStep added to the end to end tests.
* Adding TerminalUpdateStates function which returns a slice containing all terminal states for an update. Changed signature of JobUpdateStatus from using a map for desired states to a slice. A map is no longer necessary with the new version of thrift and only adds complexity.
* Changing generateBinding.sh check to check for thrift 0.12.0 and adding support for Variable Batch updates.
* Adding update strategies change to changelog, changed docker-compose to point to aurora 0.22.0 snapshot. Added test coverage for update strategies.
* Simplifying documentation for getting started: Removed outdated information about install Golang on different platforms and instead included a link to the official Golang website which has more up to date information. Instructions for installing docker-compose have also been added.
* Added documentation to all exported functions and structs.
* Unexported some structures and functions that were needlessly exported.
* Adding golang CI default configuration which can be useful while developing and may be turned on later in the CI.
* Moving build process in CI to xenial.
* Reducing line size. in some files and shadowing in some test cases.
* Adding Aurora URL validator in order to handle scenarios where incomplete information is passed to the client. The client will do its best to guess the missing information such as protocol and port.
* Upgraded to testify 1.3.0.
* Added configuration to fail on a non-temporary error. This is reverting to the original behavior of the retry mechanism. However, this allows the user to opt to fail in a non-temporary error.
* Bumped up version to 1.21.1
* Moving admin functions to a new file. They are still part of the same pointer receiver type.
* Removing dead code and fixing some comments to add space between backslash and comment.
* Adding set up and tear down to run tests script. It sets up a pod, runs all tests, and then tears down the pod.
* Added `--rm` to run tests Mac script.
* Removing cookie jar from transport layer as it's not needed.
* Changing all error messages to start with a lower case letter. Changing some messages around to be more descriptive.
* Adding an argument to allow the retry mechanism to stop if a timeout has been encountered. This is useful for mutating API calls. Only StartUpdate and CreateService have enabled by default stop at timeout.
* Added 2 tests for when a call goes through despite the client timing out. One is with a good payload, one is with a bad payload.
* Updating changelog with information about the error type returned.
* Adding test for duplicate metadata.
* Refactored JobUpdateStatus monitor to use a new monitor called JobUpdateQuery. Update monitor will now still continue if it does not find an update to monitor. Furthermore, it has been optimized to reduce returning payloads from the scheduler as much as possible. This is through using the GetJobUpdateSummaries API instead of JobUpdateDetails and by including a the statuses we're searching for as part of the query.
* Added documentation as to how to handle a timeout on an API request.
* Optimized GetInstancesIds to create a copy of the JobKey being passed down in order to avoid unexpected behavior. Instead of setting every variable name separately, now a JobKey array is being created.
* Adding parameter for Aurora so that we're able to run SLA aware updates with less than 20 instances. Lowered time it takes to run test by reducing watch time per instance as well.
* Reducing the number of instances and time for SLA aware instances in docker-compose set up.
* Adding another Mesos agent to the docker-compose setup.
* Huge thanks to @zircote for this contribution.
* Ported all code from Thrift 0.9.3 to Thrift 0.12.0 while backporting some fixes from gorealis v2
* Removing git.apache.org dependency from Vendor folder as this dependency has migrated to github.
* Adding github.com thrift dependency back but now it points to github.com
* Removing unnecessary files from Thrift Vendor folder and adding them to .gitignore.
* Updating dep dependencies to include Thrift 0.12.0 from github.com
* Adding changelog.
* End to end tests: Adding coverage for killinstances.
* End to end tests: Deleting instances after partition policy recovers them.
* End to end tests: Adding more coverage to the realis API.
* End to end tests: Allowing arguments to be passed to runTestMac so that '-run <test name>' can be passed in.
* End to end tests: Reducing the resources used by CreateJob test.
* End to end tests: Adding coverage for Pause and Resume update.
* End to end tests: Removed checks for Aurora_OK response as that should always be handled by the error returned by the API. Changed names to be less verbose and repetitive.
* End to end tests: Reducing watch time for instance running when creating service for reducing time it takes to run end to end test.
* Making abort job synchronous to avoid scenarios where kill is received before job update lock is released.
* Adding missing cases for terminal update statues to JobUpdate monitor.
* Monitors now return errors which provide context through behavior.
* Adding notes to the doc explaining what happens when AbortJob times out.
* Add trace level to print out response thrift objects. Allows user to control whether these are printed or not to avoid pollution.
* Using named parameters to be more explicit about what is being set for LevelLogger.
* Adding TracePrint and TracePrintln. Inlined library level prefixes.
* Detecting if the transport error was not temporary in which case we stop retrying. Changed bug where get results was being called before we checked for an error.
* Adding exception for EOF error. All EOF errors will be retried.
* Addressing race conditions that may happen when client is closed or connection is re-established.
* Adding documentation about how this particular implemantion of the realis client uses retries in scenarios where a temporary error is found.
* Bugfix: switch statements were missing fallthrough statement thus making them retry non-retriable errors. Using a list to catch cases now.
* Adding tests for CreateService, createService when the executor doesn't exist, and createJob when the executor doesn't exist. Renamed Pulse test to reflect that it's using CreateService instead of CreateJob.
* Repsonse propagate back up to caller for context for CreateJob, CreateService, and StartJobUpdate.
* Deleting PR template as Travis CI takes care of running tests and formatting tests now.
