spdf/elektron
Archived
1
0
Fork 0
Code Issues 4 Pull requests 1 Projects Releases Packages Wiki Activity

Rapl node capping daemon #21

Merged
ridv merged 18 commits from raplDaemon into master 2020-01-19 19:52:32 +00:00
Conversation 15 Commits 18 Files changed 5 +14 -5
1 changed files with 14 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit b3de44bac6 - Show all commits

19
rapl-daemon/util_test.go
View file

@ -4,6 +4,7 @@ import (
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)
Copy link

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)
Copy link

Good point, fixed.

Good point, fixed.
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)
Copy link

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)
Copy link

Good point, fixed.

Good point, fixed.
"io/ioutil"
"math"
"os"
"path/filepath"
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)
Copy link

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)
Copy link

Good point, fixed.

Good point, fixed.
"strconv"
"strings"
"testing"
@ -15,11 +16,20 @@ import (
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)
Copy link

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)
Copy link

Good point, fixed.

Good point, fixed.
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)
Copy link

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)
Copy link

Good point, fixed.

Good point, fixed.
// that mimic the powercap subsystem and create test to operate on it.
func TestCapNode(t *testing.T) {
err := capNode("/sys/devices/virtual/powercap/intel-rapl", 95)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)
Copy link

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)
Copy link

Good point, fixed.

Good point, fixed.
RAPLdir, err := ioutil.TempDir("", "intel-rapl")
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)
Copy link

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)
Copy link

Good point, fixed.

Good point, fixed.
assert.NoError(t, err)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)
Copy link

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)
Copy link

Good point, fixed.

Good point, fixed.
defer os.RemoveAll(RAPLdir)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)
Copy link

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)
Copy link

Good point, fixed.

Good point, fixed.
if err != nil {
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)
Copy link

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)
Copy link

Good point, fixed.

Good point, fixed.
t.Fail()
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)
Copy link

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)
Copy link

Good point, fixed.

Good point, fixed.
}
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)
Copy link

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)
Copy link

Good point, fixed.

Good point, fixed.
zonePath := filepath.Join(RAPLdir, raplPrefixCPU+":0")
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)
Copy link

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)
Copy link

Good point, fixed.

Good point, fixed.
err = os.Mkdir(zonePath, 755)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)
Copy link

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)
Copy link

Good point, fixed.

Good point, fixed.
assert.NoError(t, err)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)
Copy link

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)
Copy link

Good point, fixed.

Good point, fixed.
err = ioutil.WriteFile(filepath.Join(zonePath, maxPowerFileShortWindow), []byte("1500000"), 0444)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)
Copy link

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)
Copy link

Good point, fixed.

Good point, fixed.
assert.NoError(t, err)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)
Copy link

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)
Copy link

Good point, fixed.

Good point, fixed.
err = ioutil.WriteFile(filepath.Join(zonePath, powerLimitFileShortWindow), []byte("1500000"), 0644)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)
Copy link

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)
Copy link

Good point, fixed.

Good point, fixed.
assert.NoError(t, err)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)
Copy link

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)
Copy link

Good point, fixed.

Good point, fixed.
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)
Copy link

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)
Copy link

Good point, fixed.

Good point, fixed.
err = capNode(RAPLdir, 95)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)
Copy link

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)
Copy link

Good point, fixed.

Good point, fixed.
assert.NoError(t, err)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)
Copy link

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)
Copy link

Good point, fixed.

Good point, fixed.
}
func TestMaxPower(t *testing.T) {
@ -42,7 +52,6 @@ func TestMaxPower(t *testing.T) {
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)
Copy link

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)
Copy link

Good point, fixed.

Good point, fixed.
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)
Copy link

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)
Copy link

Good point, fixed.

Good point, fixed.
}
func TestCapZone(t *testing.T) {
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)
Copy link

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)
Copy link

Good point, fixed.

Good point, fixed.
const maxPower float64 = 1500000
const percentage float64 = .50

pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)
Copy link

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)
Copy link

Good point, fixed.

Good point, fixed.
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)
Copy link

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)
Copy link

Good point, fixed.

Good point, fixed.