Rapl node capping daemon #21

Merged
ridv merged 18 commits from raplDaemon into master 2020-01-19 19:52:32 +00:00
5 changed files with 311 additions and 0 deletions

1
go.sum
View file

@ -1,5 +1,6 @@
github.com/davecgh/go-spew v1.1.0 h1:ZDRjVQ15GmhC3fiQ8ni8+OwkZQO4DARzQgrnXU1Liz8=
github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
github.com/fatih/color v1.7.0 h1:DkWD4oS2D8LGGgTQ6IvwJJXSL5Vp2ffcQg58nFV38Ys=
github.com/fatih/color v1.7.0/go.mod h1:Zm6kSWBoL9eyXnKyktHP6abPY2pDugNf5KwzbycvMj4=

39
rapl-daemon/README.md Normal file
View file

@ -0,0 +1,39 @@
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing
# RAPL Daemon
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing
This runs a server that is capable of changing the percentage at which
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing
a node is being throttled to using RAPL. This daemon should be installed
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing
on all worker nodes.
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing
### Sample payload for testing:
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing
```
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing
curl --header "Content-Type: application/json" \
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing
--request POST \
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing
--data '{"percentage":75}' \
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing
http://localhost:9090/powercap
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing
```
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing
### Payload
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing
```json
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing
{
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing
"percentage":75
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing
}
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing
```
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing
### Response
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing
The daemon will respond with a json payload containing zones that were
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing
successfully capped as well as the zones that were not capped.
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing
```json
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing
{
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing
"cappedZones": null,
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing
"failedZones": [
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing
"intel-rapl:0",
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing
"intel-rapl:1"
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing
],
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing
"error": "some zones were not able to be powercapped"
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing
}
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing
```
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing
Field error will not exist if failed zones is empty.
pradykaushik commented 2020-01-13 19:09:54 +00:00 (Migrated from github.com)

capable of changing

capable **of** changing

60
rapl-daemon/main.go Normal file
View file

@ -0,0 +1,60 @@
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
package main
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
import (
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
"encoding/json"
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
"fmt"
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
"html"
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
"log"
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
"net/http"
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
)
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
const powercapDir = "/sys/class/powercap/"
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
// Cap is a payload that is expected from Elektron to cap a node.
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
type Cap struct {
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
Percentage int
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
}
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
// CapResponse is the payload sent with information about the capping call
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
type CapResponse struct {
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
CappedZones []string `json:"cappedZones"`
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
FailedZones []string `json:"failedZones"`
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
Error *string `json:"error"`
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
}
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
func main() {
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
http.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) {
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
fmt.Fprintf(w, "Unsupported endpoint %s", html.EscapeString(r.URL.Path))
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
pradykaushik commented 2020-01-13 19:12:52 +00:00 (Migrated from github.com)

error messages should be lowercase.

error messages should be lowercase.
ridv commented 2020-01-17 17:25:49 +00:00 (Migrated from github.com)

In this case this is some http content being served back to to the client that made the request. I did make it lower case though.

In this case this is some http content being served back to to the client that made the request. I did make it lower case though.
})
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
http.HandleFunc("/powercap", powercapEndpoint)
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
log.Fatal(http.ListenAndServe(":9090", nil))
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
}
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
// Handler for the powercapping HTTP API endpoint.
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
func powercapEndpoint(w http.ResponseWriter, r *http.Request) {
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
w.Header().Set("Content-Type", "application/json")
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
var payload Cap
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
var response CapResponse
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
decoder := json.NewDecoder(r.Body)
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
err := decoder.Decode(&payload)
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
if err != nil {
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
errorMsg := "error parsing payload: " + err.Error()
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
response.Error = &errorMsg
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
json.NewEncoder(w).Encode(response)
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
return
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
}
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
cappedZones, failedZones, err := capNode(powercapDir, payload.Percentage)
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
if err != nil {
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
errorMsg := err.Error()
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
response.Error = &errorMsg
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
}
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
response.CappedZones = cappedZones
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
response.FailedZones = failedZones
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
json.NewEncoder(w).Encode(response)
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.
}
pradykaushik commented 2020-01-13 19:11:14 +00:00 (Migrated from github.com)

missing period at the end of the sentence.

missing period at the end of the sentence.
pradykaushik commented 2020-01-13 19:13:15 +00:00 (Migrated from github.com)

missing period at end of sentence.

missing period at end of sentence.

110
rapl-daemon/util.go Normal file
View file

@ -0,0 +1,110 @@
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
package main
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
import (
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
"fmt"
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
"io/ioutil"
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
"math"
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
"os"
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
"path/filepath"
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
"strconv"
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
"strings"
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
)
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
const raplPrefixCPU = "intel-rapl"
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
// constraint_0 is usually the longer window while constraint_1 is usually the shorter window
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
const maxPowerFileLongWindow = "constraint_0_max_power_uw"
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
const powerLimitFileLongWindow = "constraint_0_power_limit_uw"
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
// capNode uses pseudo files made available by the Linux kernel
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
// in order to capNode CPU power. More information is available at:
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
// https://www.kernel.org/doc/html/latest/power/powercap/powercap.html
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
func capNode(base string, percentage int) ([]string, []string, error) {
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
if percentage <= 0 || percentage > 100 {
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
return nil, nil, fmt.Errorf("cap percentage must be between 0 (non-inclusive) and 100 (inclusive): %d", percentage)
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
}
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
files, err := ioutil.ReadDir(base)
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
if err != nil {
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
return nil, nil, err
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
}
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
var capped, failed []string
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
for _, file := range files {
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
fields := strings.Split(file.Name(), ":")
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
// Fields should be in the form intel-rapl:X where X is the power zone
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
// We ignore sub-zones which follow the form intel-rapl:X:Y
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
if len(fields) != 2 {
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
continue
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
}
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
if fields[0] == raplPrefixCPU {
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
maxPower, err := maxPower(filepath.Join(base, file.Name(), maxPowerFileLongWindow))
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
if err != nil {
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
failed = append(failed, file.Name())
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
fmt.Println("unable to retreive max power for zone ", err)
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
pradykaushik commented 2020-01-13 19:40:01 +00:00 (Migrated from github.com)

any reason for just printing the error and not returning it?
Basically, the question is whether we need to continue to attempt to powercap if an error occurs anywhere in the process.

any reason for just printing the error and not returning it? Basically, the question is whether we need to continue to attempt to powercap if an error occurs anywhere in the process.
ridv commented 2020-01-17 17:39:01 +00:00 (Migrated from github.com)

Agreed, I don't know what the right path to take is here. If the file write fails, we could be left in an inconsistent state. The only options here are to bail and return an error right away, or to continue trying to cap the node and then returning an array of zones where were unable to cap the node in.

Agreed, I don't know what the right path to take is here. If the file write fails, we could be left in an inconsistent state. The only options here are to bail and return an error right away, or to continue trying to cap the node and then returning an array of zones where were unable to cap the node in.
pradykaushik commented 2020-01-17 22:15:38 +00:00 (Migrated from github.com)

Any chance we can roll back the power limits set to the previous values if and when any of the file writes fail?

Any chance we can roll back the power limits set to the previous values if and when any of the file writes fail?
ridv commented 2020-01-18 01:21:04 +00:00 (Migrated from github.com)

If the write fails, we're sort of left in limbo. If the write to modify it failed, then most likely the write to restore the value will fail too. We can try reading it and seeing if that's the same value as before.

If the write fails, we're sort of left in limbo. If the write to modify it failed, then most likely the write to restore the value will fail too. We can try reading it and seeing if that's the same value as before.
continue
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
}
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
// We use floats to mitigate the possibility of an integer overflow.
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
powercap := uint64(math.Ceil(float64(maxPower) * (float64(percentage) / 100)))
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
if err := capZone(filepath.Join(base, file.Name(), powerLimitFileLongWindow), powercap); err != nil {
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
failed = append(failed, file.Name())
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
fmt.Println("unable to write powercap value: ", err)
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
pradykaushik commented 2020-01-13 19:41:13 +00:00 (Migrated from github.com)

same here regarding whether the error to continue if error occurs or should we just return it.

same here regarding whether the error to continue if error occurs or should we just return it.
continue
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
}
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
capped = append(capped, file.Name())
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
}
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
}
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
if len(failed) > 0 {
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
return capped, failed, fmt.Errorf("some zones were not able to be powercapped")
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
}
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
return capped, nil, nil
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
}
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
// maxPower returns the value in float of the maximum watts a power zone can use.
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
func maxPower(maxFile string) (uint64, error) {
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
maxPower, err := ioutil.ReadFile(maxFile)
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
if err != nil {
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
return 0, err
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
}
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
maxPoweruW, err := strconv.ParseUint(strings.TrimSpace(string(maxPower)), 10, 64)
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
if err != nil {
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
return 0, err
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
}
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
return maxPoweruW, nil
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
}
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
// capZone caps a power zone to a specific amount of watts specified by value
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
func capZone(limitFile string, value uint64) error {
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
if _, err := os.Stat(limitFile); os.IsNotExist(err) {
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
return err
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
}
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
err := ioutil.WriteFile(limitFile, []byte(strconv.FormatUint(value, 10)), 0644)
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
if err != nil {
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
return err
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
}
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
return nil
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
}
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
func currentCap(limit string) (uint64, error) {
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
powercap, err := ioutil.ReadFile(limit)
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
if err != nil {
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
return 0, err
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
}
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
powercapuW, err := strconv.ParseUint(strings.TrimSpace(string(powercap)), 10, 64)
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
if err != nil {
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
return 0, err
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
}
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
return powercapuW, nil
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it
}
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)

I'll revert it

I'll revert it

101
rapl-daemon/util_test.go Normal file
View file

@ -0,0 +1,101 @@
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
package main
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
import (
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
"io/ioutil"
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
"log"
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
"math"
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
"os"
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
"path/filepath"
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
"strconv"
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
"testing"
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
"github.com/stretchr/testify/assert"
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
var raplDir string
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
const maxWattage uint64 = 1500000
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
func TestMain(m *testing.M) {
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
var err error
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
raplDir, err = ioutil.TempDir("", raplPrefixCPU)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
if err != nil {
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
log.Fatal(err)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
}
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
defer os.RemoveAll(raplDir)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
// Create temporary directory that mocks powercap subsytem
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
zonePath := filepath.Join(raplDir, raplPrefixCPU+":0")
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
err = os.Mkdir(zonePath, 755)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
if err != nil {
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
log.Fatal(err)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
}
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
initialWatts := strconv.FormatUint(maxWattage, 10)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
err = ioutil.WriteFile(filepath.Join(zonePath, maxPowerFileLongWindow), []byte(initialWatts), 0444)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
if err != nil {
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
log.Fatal(err)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
}
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
err = ioutil.WriteFile(filepath.Join(zonePath, powerLimitFileLongWindow), []byte(initialWatts), 0644)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
if err != nil {
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
log.Fatal(err)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
}
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
os.Exit(m.Run())
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
}
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
// TODO(rdelvalle): Add tests where capping fails
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
func TestCapNode(t *testing.T) {
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
capped, failed, err := capNode(raplDir, 95)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
assert.NoError(t, err)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
assert.Len(t, capped, 1)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
assert.Nil(t, failed)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
t.Run("bad-percentage", func(t *testing.T) {
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
capped, failed, err := capNode(raplDir, 1000)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
assert.Error(t, err)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
assert.Nil(t, capped)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
assert.Nil(t, failed)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
})
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
t.Run("zero-percent", func(t *testing.T) {
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
capped, failed, err := capNode(raplDir, 0)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
assert.Error(t, err)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
assert.Nil(t, capped)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
assert.Nil(t, failed)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
})
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
}
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
func TestMaxPower(t *testing.T) {
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
maxFile := filepath.Join(raplDir, raplPrefixCPU+":0", maxPowerFileLongWindow)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
maxWatts, err := maxPower(maxFile)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
assert.NoError(t, err)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
assert.Equal(t, maxWattage, maxWatts)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
t.Run("name-does-not-exist", func(t *testing.T) {
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
_, err := maxPower("madeupname")
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
assert.Error(t, err)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
})
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
}
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
func TestCapZone(t *testing.T) {
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
const percentage float64 = .50
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
pradykaushik commented 2020-01-13 19:53:17 +00:00 (Migrated from github.com)

The payload declares percentage as an integer. So, we would never hit this scenario.
Should the percentage in the payload be an integer?

The payload declares `percentage` as an integer. So, we would never hit this scenario. Should the percentage in the payload be an integer?
ridv commented 2020-01-17 17:42:53 +00:00 (Migrated from github.com)

The payload does indeed take an integer, but when we calculate powercap, I'd rather multiply by a fraction than to multiply by a (0,100] integer and then divide by 100. This is done in the next line and it's just for testing.

The payload does indeed take an integer, but when we calculate powercap, I'd rather multiply by a fraction than to multiply by a (0,100] integer and then divide by 100. This is done in the next line and it's just for testing.
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
powercap := uint64(math.Ceil(float64(maxWattage) * percentage))
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
limitFile := filepath.Join(raplDir, raplPrefixCPU+":0", powerLimitFileLongWindow)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
err := capZone(limitFile, powercap)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
assert.NoError(t, err)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
newCap, err := currentCap(limitFile)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
assert.NoError(t, err)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
assert.Equal(t, powercap, newCap)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
t.Run("name-does-not-exist", func(t *testing.T) {
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
err := capZone("madeupname", powercap)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
assert.Error(t, err)
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
})
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.
}
pradykaushik commented 2020-01-13 19:45:13 +00:00 (Migrated from github.com)

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default.
Although, I do not mind the camelcasing.

I think it's safe to use spaces ("bad percentage") as the words are hyphenated by default. Although, I do not mind the camelcasing.
ridv commented 2020-01-18 01:22:53 +00:00 (Migrated from github.com)

Good point, fixed.

Good point, fixed.