spdf/elektron
Archived
1
0
Fork 0
Code Issues 4 Pull requests 1 Projects Releases Packages Wiki Activity

Rapl node capping daemon #21

Merged
ridv merged 18 commits from raplDaemon into master 2020-01-19 19:52:32 +00:00
Conversation 15 Commits 18 Files changed 5 -1
1 changed files with 0 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit cf4ffe61c0 - Show all commits

1
rapl-daemon/util.go
View file

@ -54,7 +54,6 @@ func capNode(base string, percentage int) error {
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)
Copy link

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)
Copy link

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)
Copy link

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)
Copy link

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)
Copy link

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)
Copy link

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)
Copy link

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)
Copy link

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)
Copy link

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)
Copy link

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)
Copy link

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)
Copy link

I'll revert it

I'll revert it
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)
Copy link

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)
Copy link

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)
Copy link

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)
Copy link

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)
Copy link

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)
Copy link

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)
Copy link

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)
Copy link

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)
Copy link

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)
Copy link

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)
Copy link

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)
Copy link

I'll revert it

I'll revert it
fmt.Println("unable to write powercap value: ", err)
continue
}
pradykaushik commented 2020-01-13 19:41:13 +00:00 (Migrated from github.com)
Copy link

same here regarding whether the error to continue if error occurs or should we just return it.

same here regarding whether the error to continue if error occurs or should we just return it.
fmt.Println(file.Name(), ": ", int(maxPower), ", ", int(powercap))
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)
Copy link

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)
Copy link

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)
Copy link

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)
Copy link

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)
Copy link

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)
Copy link

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)
Copy link

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)
Copy link

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)
Copy link

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)
Copy link

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)
Copy link

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)
Copy link

I'll revert it

I'll revert it
}
}

pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)
Copy link

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)
Copy link

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)
Copy link

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)
Copy link

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)
Copy link

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)
Copy link

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)
Copy link

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)
Copy link

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)
Copy link

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)
Copy link

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)
Copy link

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)
Copy link

I'll revert it

I'll revert it
pradykaushik commented 2020-01-13 19:22:44 +00:00 (Migrated from github.com)
Copy link

constraint_1 is the shorter window.

constraint_1 is the shorter window.
pradykaushik commented 2020-01-13 19:23:24 +00:00 (Migrated from github.com)
Copy link

maybe just say cap percentage must be in the range (0, 100].

maybe just say **cap percentage must be in the range (0, 100]**.
pradykaushik commented 2020-01-13 19:29:52 +00:00 (Migrated from github.com)
Copy link

constraint_0 is the longer window.
Going by this we are intending to use the longer window for running average calculations.
So, change the variable name to maxPowerFileLongWindow?

constraint_0 is the longer window. Going by [this](https://github.com/spdfg/elektron/blob/master/scripts/RAPL_PKG_Throttle.py#L48) we are intending to use the longer window for running average calculations. So, change the variable name to `maxPowerFileLongWindow`?
pradykaushik commented 2020-01-13 19:32:00 +00:00 (Migrated from github.com)
Copy link

ditto.

ditto.
pradykaushik commented 2020-01-13 19:32:28 +00:00 (Migrated from github.com)
Copy link

overflows

overflow~s~
pradykaushik commented 2020-01-13 19:38:12 +00:00 (Migrated from github.com)
Copy link

fits on a single line.

fits on a single line.
ridv commented 2020-01-17 17:34:53 +00:00 (Migrated from github.com)
Copy link

Can you expand on this comment?

Can you expand on this comment?
pradykaushik commented 2020-01-17 22:19:20 +00:00 (Migrated from github.com)
Copy link

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.

Actually, your way of representing the ranges is more explicit and clear. One is not well-versed with range expressions would still be able to understand your explanation. So, ignore my previous statement and leave it as is.
pradykaushik commented 2020-01-17 22:20:18 +00:00 (Migrated from github.com)
Copy link

Either change overflows to overflow, or get rid of the "an".

Either change **overflows** to **overflow**, or get rid of the "an".
ridv commented 2020-01-18 01:21:46 +00:00 (Migrated from github.com)
Copy link

Good catch, fixed.

Good catch, fixed.
ridv commented 2020-01-18 01:22:14 +00:00 (Migrated from github.com)
Copy link

Fixed this, definitely a mistake on my part. Thanks for catching it!

Fixed this, definitely a mistake on my part. Thanks for catching it!
ridv commented 2020-01-18 01:22:28 +00:00 (Migrated from github.com)
Copy link

I'll revert it

I'll revert it